From nobody Fri Nov 1 04:39:17 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1522970062123901.5601804801282; Thu, 5 Apr 2018 16:14:22 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id E52C02265A8DD; Thu, 5 Apr 2018 16:14:09 -0700 (PDT) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 67EB622526484 for ; Thu, 5 Apr 2018 16:14:07 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2018 16:14:06 -0700 Received: from jcarsey-desk1.amr.corp.intel.com ([10.7.159.141]) by orsmga004.jf.intel.com with ESMTP; 05 Apr 2018 16:14:05 -0700 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,412,1517904000"; d="scan'208";a="189047089" From: Jaben Carsey To: edk2-devel@lists.01.org Date: Thu, 5 Apr 2018 16:13:52 -0700 Message-Id: <1fd8614ac264e99740a1ba5026c80a0fe23f48e8.1522969978.git.jaben.carsey@intel.com> X-Mailer: git-send-email 2.16.2.windows.1 In-Reply-To: References: In-Reply-To: References: Subject: [edk2] [PATCH v1 04/14] BaseTools: sets are faster to check via "in" due to hashing X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Liming Gao MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" switch list to set: 1)we dont care about order 2)we only check for membership. then remove ".keys()" from dict looping: allow generators opportunity to optimize Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/= Python/AutoGen/AutoGen.py index 91a0742a33be..bd720a4dd295 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -354,9 +354,9 @@ class WorkspaceAutoGen(AutoGen): MetaFile_cache =3D {} for Arch in self.ArchList: Platform_cache[Arch] =3D self.BuildDatabase[self.M= etaFile, Arch, Target, Toolchain] - MetaFile_cache[Arch] =3D [] - for Pkey in Platform_cache[Arch].Modules.keys(): - MetaFile_cache[Arch].append(Platform_cache[Arc= h].Modules[Pkey].MetaFile) + MetaFile_cache[Arch] =3D set() + for Pkey in Platform_cache[Arch].Modules: + MetaFile_cache[Arch].add(Platform_cache[Arch].= Modules[Pkey].MetaFile) for Inf in self.FdfProfile.InfDict[key]: ModuleFile =3D PathClass(NormPath(Inf), GlobalData= .gWorkspace, Arch) for Arch in self.ArchList: @@ -371,9 +371,9 @@ class WorkspaceAutoGen(AutoGen): for Arch in self.ArchList: if Arch =3D=3D key: Platform =3D self.BuildDatabase[self.MetaFile,= Arch, Target, Toolchain] - MetaFileList =3D [] - for Pkey in Platform.Modules.keys(): - MetaFileList.append(Platform.Modules[Pkey]= .MetaFile) + MetaFileList =3D set() + for Pkey in Platform.Modules: + MetaFileList.add(Platform.Modules[Pkey].Me= taFile) for Inf in self.FdfProfile.InfDict[key]: ModuleFile =3D PathClass(NormPath(Inf), Gl= obalData.gWorkspace, Arch) if ModuleFile in MetaFileList: --=20 2.16.2.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel