From nobody Thu Apr 25 14:40:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+89557+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+89557+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1651846918; cv=none; d=zohomail.com; s=zohoarc; b=n2/2T+BLjewg/mRMcXTscZa9P6IfJbIvMiANm1FwzjLLdtzURa3FyfnsInAimwYCiZrTDPqeoPW+hojLt/pA1M8vtF0A4xRQd/qc7YURMspQxfk3/lfTu22Z59yPtzVsZo71y/Cl3oIi3bIaGVHoTOMXo9AZKQf23XawfaJL2NI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651846918; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=u9/L1fOC21N2H7YpQmEM8jVYWSrl3qmfVhkIpNrXaYk=; b=CwqkGrXkLxmO7bsWI7PFVQhvZp7vTXW6hRBqZsCLeeZfAu4h51+vtUjgMd/qTm4TZTnQvtA5OBWfzEPFX0x6Gth8kMkgKI7uNjwSLxLTjbtRYr3Qqxd+V85rsx0tNMW5T5dW3suRVONgvqYmAteP4BYxqBRkanSWs9x8GfTzRZ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+89557+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1651846917908317.5037204595235; Fri, 6 May 2022 07:21:57 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id XJHpYY1788612xGl3NvMovz4; Fri, 06 May 2022 07:21:57 -0700 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.2182.1651786197946782570 for ; Thu, 05 May 2022 14:29:58 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="248791443" X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="248791443" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 14:29:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="891523872" X-Received: from gguo-desk.gar.corp.intel.com ([10.5.215.23]) by fmsmga005.fm.intel.com with ESMTP; 05 May 2022 14:29:55 -0700 From: guo.guo@intel.com To: devel@edk2.groups.io Cc: Gua Guo Subject: [edk2-devel] [PATCH] MdeModulePkg/PCD: Pcd initialize DXE have assert Date: Fri, 6 May 2022 05:29:51 +0800 Message-Id: <1ee1661a007ada580eb29579198e5f4b4c074b1b.1651786183.git.gua.guo@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guo.guo@intel.com X-Gm-Message-State: e4HMZx12V4c03bPi7kxM3yezx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1651846917; bh=dn7KZ7283RnClPl+FEjZzQwTpWHY4ny6KbiZ9QUz/2o=; h=Cc:Date:From:Reply-To:Subject:To; b=uomdrL+fpDpMQh38i3wEcoTAqOzKDXkcrsi/Hloxm4r5Mvr0dsrC9Kx9SEeudwa4Rdm 408h6Sm/Oq8/fMxpa5HFyaCWy3cJxbRrS8jRiId1mEwEoG4Rydmphy591g4BF8eoYIiBa 5BDbAbGSLfmVoyyBP779FenqA4/MCChIqjk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1651846920086100003 Content-Type: text/plain; charset="utf-8" From: Gua Guo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3917 When PlatformPkg.dsc has multiple SKU IDs but didn't exist delta PCD, System will hang on BuildPcdDxeDataBase. Ideally, if didn't exist delta PCD by different SKU ID, UpdatePcdDatabase () shouldn't return EFI_NOT_FOUND. Signed-off-by: Gua Guo --- MdeModulePkg/Universal/PCD/Dxe/Service.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/MdeModulePkg/Universal/PCD/Dxe/Service.c b/MdeModulePkg/Univer= sal/PCD/Dxe/Service.c index 3965846b93..5ade8d988b 100644 --- a/MdeModulePkg/Universal/PCD/Dxe/Service.c +++ b/MdeModulePkg/Universal/PCD/Dxe/Service.c @@ -817,6 +817,11 @@ UpdatePcdDatabase ( // Index =3D (mPcdDatabase.DxeDb->Length + 7) & (~7); SkuDelta =3D NULL; + + if (Index =3D=3D mDxePcdDbSize) { + return EFI_SUCCESS; + } + while (Index < mDxePcdDbSize) { SkuDelta =3D (PCD_DATABASE_SKU_DELTA *)((UINT8 *)mDxePcdDbBinary + Ind= ex); if ((SkuDelta->SkuId =3D=3D SkuId) && (SkuDelta->SkuIdCompared =3D=3D = 0)) { --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89557): https://edk2.groups.io/g/devel/message/89557 Mute This Topic: https://groups.io/mt/90934230/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-