From nobody Sat May 18 04:46:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+77065+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+77065+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1624542430; cv=none; d=zohomail.com; s=zohoarc; b=IaLHN9vBdogspExZRotC8y/ZAh5FMgdPWNNZz6mvAHtnd+6WOkII6rf4/AFCeYEysH2ZP7SqiALOm2geWDlebMFHc2weuELAPAb/UscHV2TUp/MgkUjXRD9vg8Jk1zqTZkX8SbMtzXNjYis+b2E8FFoquxGU6jBKqnyj62VyZW4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624542430; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=k94sfEgB/Hm5vtf/WEMfvLPTArddNv+XS1/l0j4ryHs=; b=eezR3KxQxCD30CJ84GEYERhu2S9uKK1ToCN1JPCVrMX+yCB4JzEybG8EaLlVoD1h0gxVfC8Fjlpvcw4tTbbjTME31ZiE9Gz4+mH5VpPR1Uwv5WzDipi7uBRwly8vGhq35vA94nCxKU0a7Wc5y4RwzKnbeTmKWWNNjYGL2e3Uyio= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+77065+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1624542430320990.6931110713846; Thu, 24 Jun 2021 06:47:10 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ER7nYY1788612xurBthezdmW; Thu, 24 Jun 2021 06:47:10 -0700 X-Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mx.groups.io with SMTP id smtpd.web11.4200.1624520013248077586 for ; Thu, 24 Jun 2021 00:33:33 -0700 X-Received: by mail-pg1-f172.google.com with SMTP id e33so4023312pgm.3 for ; Thu, 24 Jun 2021 00:33:33 -0700 (PDT) X-Gm-Message-State: g006v9yEUGXRKIkQee1yiLQRx1787277AA= X-Google-Smtp-Source: ABdhPJxEc/Q5D9uNErjyPHpEm9tJS1zhkB7d1lHR/VXoytutjHRZT919i2qVLXCC99whlOrLjh6ukA== X-Received: by 2002:a63:104d:: with SMTP id 13mr3584938pgq.318.1624520012419; Thu, 24 Jun 2021 00:33:32 -0700 (PDT) X-Received: from UTILFW-8301.in.megatrends.com ([171.78.178.148]) by smtp.gmail.com with ESMTPSA id cq4sm4319858pjb.1.2021.06.24.00.33.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 00:33:32 -0700 (PDT) From: "INDIA\\sivaramann" X-Google-Original-From: "INDIA\\sivaramann" To: devel@edk2.groups.io Cc: Sivaraman Subject: [edk2-devel] [PATCH v2] NetworkPkg:UEFIPXEBC Date: Thu, 24 Jun 2021 13:03:29 +0530 Message-Id: <1b052eda1c038b2d9e3502c679e0014db143a39b.1624516592.git.sivaramann@ami.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,emergingsiva@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1624542430; bh=eJVL+WzKnGtPenOmPp2ZOOAojNyUUOg7ZaL4LboiVLM=; h=Cc:Date:From:Reply-To:Subject:To; b=NBEgKBmtQeSFIVlRTo8bbkPOIiqgRwJ3OOyPwjM+VcAzwcrHUifoMkqRRguJcUUeGeT cBbC7iGN3ULpCxlW69wFpzlzm+gX5gMTnBW7UT0IdoqgduzAlUhZ7opY4GU2eqXMDuSe7 ckw67tp23bBstvlFfDd2DqAyIWEyPbXXyIk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Issue on the PxeBcDhcp4CallBack() functions of UEFIPXEBC Driver. In this function any non allowed events are recieved as input it will exit in beginning itself. But the switch case handling the default and Dhcp4SendRequest which is not reachable. Signed-off-by: Sivaraman --- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c b/NetworkPkg/UefiPxeBcDxe= /PxeBcDhcp4.c index fb63cf61a9..e85176f9bb 100644 --- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c @@ -1256,19 +1256,10 @@ PxeBcDhcp4CallBack ( =20 // // Cache the DHCPv4 discover packet to mode data directly. - // It need to check SendGuid as well as Dhcp4SendRequest. + // It need to check SendGuid. // CopyMem (&Mode->DhcpDiscover.Dhcpv4, &Packet->Dhcp4, Packet->Length); =20 - case Dhcp4SendRequest: - if (Packet->Length > PXEBC_DHCP4_PACKET_MAX_SIZE) { - // - // If the to be sent packet exceeds the maximum length, abort the DH= CP process. - // - Status =3D EFI_ABORTED; - break; - } - if (Mode->SendGUID) { // // Send the system Guid instead of the MAC address as the hardware a= ddress if required. @@ -1332,6 +1323,7 @@ PxeBcDhcp4CallBack ( break; =20 default: + ASSERT (FALSE); break; } =20 --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77065): https://edk2.groups.io/g/devel/message/77065 Mute This Topic: https://groups.io/mt/83760651/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-