From nobody Fri May 17 06:43:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+100038+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100038+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1676065386548919.2501825454247; Fri, 10 Feb 2023 13:43:06 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id lD8aYY1788612xOD6uedpkFv; Fri, 10 Feb 2023 13:43:06 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.89]) by mx.groups.io with SMTP id smtpd.web10.7095.1676065384925571210 for ; Fri, 10 Feb 2023 13:43:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LPKf1PvgoMsW9KMeFfCULj1oJt1rNWHw16nFKA7lWq6lEPAD7pX8TU2QnFCS4DkcntplOpAj47aobBMPJNjs/edX08M3wdgc7/yQIW80ERf0m43+D7hGTXGfRWd/1lwWfCOoqvv5YjNjB6Xw5jyGDAvopvrDEQCDS34eHquC5/lPB1pgeR0g0jQw8r7e6OdzoOzlkCVSB9mQ3V/VTbEMtPkB9k9dHIxDNkKap2m7ZrCiMetQQGrv6IYytdovucoNKEW0Uxxw4pgeYVI68bQRPWk3nOJO7EvzQgwioe5JG5e4M1lvFmk8Sh/Fz7fRbwkjjYLPfrqUlejYPnBnLoFgaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fu0tvFdNaJ5CNoc9sczs9g0aeTRRoIKF+ZknSIxCgD4=; b=VguqUzv8njrk9tzHPZt1YgHDqbxVCkIID5U/0X9+XiUai8NYeEhsxjY+tJDnkRWrz4eCeNsqAuP6jU7ZH0IW14OBANieIOUQ2BUADvEzftooAen8P4BhCsGqD4Nk81b/bXXVV8Lw9tQ8BO535g53S9r4TdOg+ZhYo/kBTt3KcaKeKjpcfwgoKB22iOuVPziGt3E/bNhJkQ57UZXpMLZEOl34fIYdiwO8gVEIvh47nF2vUR9oY8pvCjz1tkea7DK2QjBVOkM1VXdK0XaeUHmbVRGWomuKUmSSy5G0PjzXBICOr3Qxms2k4DLafw1VlVLA4mCK6ZwwSpXuc3aTtI3FpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by PH0PR10MB5846.namprd10.prod.outlook.com (2603:10b6:510:14c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.16; Fri, 10 Feb 2023 21:43:02 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::3318:8f42:7036:dbbf]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::3318:8f42:7036:dbbf%7]) with mapi id 15.20.6111.007; Fri, 10 Feb 2023 21:43:01 +0000 From: "Igor Kulchytskyy via groups.io" To: "devel@edk2.groups.io" CC: Abner Chang , Nickle Wang Subject: [edk2-devel] [PATCH] RedfishPkg/RedfishConfigHandler: fix FreePool issue Thread-Topic: [PATCH] RedfishPkg/RedfishConfigHandler: fix FreePool issue Thread-Index: AQHZPZilEIQF9jbSNUWIb1BsPDQTjQ== Date: Fri, 10 Feb 2023 21:43:01 +0000 Message-ID: <1676065369-10396-1-git-send-email-igork@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|PH0PR10MB5846:EE_ x-ms-office365-filtering-correlation-id: f923c5c2-511a-451f-62b8-08db0bafc87d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: YY4+m+yz+oded0l2mAO5lP+yOtDXjjWxrXDlY+J4qIVtGidk1SbVjc0fd9TKb/5uApiL9V43IgVGf58KkC6dw/vbaCBLaPk5BGa5jdryLm0m/x/caq0pRVwrqBokNQgS3w9B3fI6GsucWyo3McWLm36P2XWU137Ay+6tyFR/9lhf21m6ST6xD3pCpqfKGvnLWJ7caMtxBNBsHcXiLhMeihy1LK7c2D6SEF2hLnS+1xEqYNwjgFdbaCJt0LVkNcpyOe8L8QI8ItUfHSlMsNK2ceW3BlcMoZFOI/8JIHBXwqBeIsWLvYfqOL3qRGBidSXcdI8SvuYw0CxDr6LyRnXCAa34oZs6lW2k2tpHffaai7mF0M4xvbUp1ZXcCaupptBSNt2Ik8wDoHwsoFS4j/+dK02WF1Epil/EDRbfbWjZLMRco5Vkc0g9ZARSdRmFBZXzBdxMj3VWeweUmjkSo1+4IfASxh+gTn9TdBXdhjncNK9AfFULV5DUJBGDaBRIXEmSPlKloQW1vp0ekifIjg6JuJvVYwmjmO1+vXrfZJJ4Md2d1RlTXLgbTd2bjpWiKcIVdCZ4KrAeHa4DQhmhKML6XU5inRCT/iZ5WOAykVNusFFytdHO8ys+6QUbsNGc9u7oorIOSJIdD8DBRyIfSD84zwWbZHBthZnknJBILOv+hO4Kg6p0bZBhe/hrk1WdpCzZWgYAYu2kBdfCcGFU7u3B1w== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?7aMEGQxrdsifUb5KQAaBKJvKPWFOfM/CE/lMmL8mbqJFwpUMSG5pibnfvn?= =?iso-8859-1?Q?ZjyYm9+GNvdJOvpZgp4owigYWgowFaRLGsoZ5ghHIduA35f0aTHG3d7isc?= =?iso-8859-1?Q?C4DdwM09W1RvNxErG/MU3i5Rt7Au4AW1QCgX6Z8LdhdROyG2kXcTZURqkN?= =?iso-8859-1?Q?qz6406cDg508R3M1FuobTuSEp/x9zt/n5V3Dk/B7cDFVw9z9y7dPvtm2TQ?= =?iso-8859-1?Q?y+10EtFNnEUxAUYfrpFsLeZ+Y8krBl/tQEK3H8tGW+fbSi10yV1nmi6CXa?= =?iso-8859-1?Q?RVIxOLNzSZYxD3t87KYHtVxt+vWwqZKDTN87zXPscUeh+T0Vb9IVeF7bux?= =?iso-8859-1?Q?Sr/KoOY+Fc7QBn20jjpU+uVMMEk+Ae0NdQjcSvANGolrWWCpPAScsd97QI?= =?iso-8859-1?Q?5aMYSlHyjOgU2y+YECdewXlJ5brmFURGPAjKIiQ23QGKRMq+OCs00hhr8J?= =?iso-8859-1?Q?of3Xr65jPSPsf737F5hvsKzTXhxQ2QGz1IDZGYm1s4dRqjNv7atUeZP77B?= =?iso-8859-1?Q?yUEhK09d7Q7NuFiSZfzVPr2pQaFbswgbWhKTXjFWsDGjTOAZvC/7EZ8EMw?= =?iso-8859-1?Q?V+eW2d9kL8OzTIXzVhpbfKNMd/NrsjgWOi1nn43iCmGo4RMVJsvRS28TRp?= =?iso-8859-1?Q?6BTa1hQVa6llF7jYOdA0f5jaMur1gzsZ2RQhS+yb1yZHjfMTSzbUYSRzq6?= =?iso-8859-1?Q?Kn5ulEit3dQXGMMFBi9DmqoXSrto/KJOolCsSmsvQeU0Rbi7h4MwJQDvvd?= =?iso-8859-1?Q?RUh5+XLII6zw3qbAUUHE6JJAm15WpZRfsOP6cZYsnoDrRJ4hkJQNPXPSYr?= =?iso-8859-1?Q?WzZEIuf1WKtmQuyt4SQdJB0OBa/6hzq5AJdUhEx07wEO+7RVlf8J4ULw1G?= =?iso-8859-1?Q?2eaEgJ9BCzJiUq4vInjCmZQy3IkDeA9jISRlYIQWe1dWfhcxXYQ7YGCoay?= =?iso-8859-1?Q?s5EWXTtEVzrig3Dl+vOxaHQLfTQ+4Xq6FPo+0D8nnseYJW66G/KiX0ilCa?= =?iso-8859-1?Q?Deb7Wwq+3fv9BZaaJkikNocZzQYufDtx3Ef47hzpFBCFmYYv1rtCPE/+qV?= =?iso-8859-1?Q?YJJliAlW1Rz3cwqbFYUhnv01CuTzvgHoaxJCNla74acoMp6d10Wh8o9gWl?= =?iso-8859-1?Q?lYEhUVA6meP4NKEIQdKPy5p93FLuUvSBQpeecX5TFjImrp6ZXYQUu3vCMc?= =?iso-8859-1?Q?+d0oLBzgOw8CGPp2PSH9BFbtZ7fi9xGC7ETAPebJFkkIj3uMGsEhS2AVcD?= =?iso-8859-1?Q?9mTyHiuWPT3LAhSe1t+b5DgezY8z5v8BEkcv52mFMSPH8QMZs5Yh/y+OF0?= =?iso-8859-1?Q?IKLYLUmHfBmtfQgUy3yjw9ANkE7LoSUUFcU2aDBsmIXWZuRYF1Sr4Hqwx+?= =?iso-8859-1?Q?xnZNls3X6MQXx7aOt3UR8eW7ZMStINs8vl1P65P2BVBtEJvYNgMKPp7G8l?= =?iso-8859-1?Q?u3KQJHSBFV9XkFmNeEmoHQH3sN+zZsm9+sFACEqUzzP0gqjGGJjlTWfuu5?= =?iso-8859-1?Q?T1htdZT2wcGu3Wzm9hlRbncy8j1sMG8PMvHNOW1SlvHYgwjhG2dm9plUN1?= =?iso-8859-1?Q?HrjPM3zzZDTEDmPDyCCCrJV5R1iGisGvEeuAzmpGL/nUeuRGbTh2EfWbiC?= =?iso-8859-1?Q?jiqokLt11Py7epktHIfAtftJ9Xft3MCBLL?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f923c5c2-511a-451f-62b8-08db0bafc87d X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2023 21:43:01.3587 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xqPlE/OQrJ4V0JzRzoBUGAZF7DJGBaKK5edc5eNpN9a0pGZCQHcrKA3yX5C8F8tw X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5846 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com X-Gm-Message-State: 0sfM8L5zRhofKAdNnC6zTa8Ix1787277AA= Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1676065386; bh=+YJ1/3Nxe9kSdncB2NhGVlX3grGvLeX8VEwW6iTz4Ho=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=UScyfHkniHYRH0BRK/ZxoK90+7NjBWziGMzhNT7IQWkFeyHJpEQpQXGLrQ+VWCfjQEr DJazVwusxH0ltZze28lasuHxB8IKdBxSauTYOxjRJcV5ZwNE3KfruY7vtx87bWuEl474i MYx4WrZhlFBVc3Lgl+RZtMaDQosC+twmEZo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1676065387452100001 Content-Type: text/plain; charset="utf-8" gRedfishDiscoveredToken buffer is allocated as one piece during protocol installed process, but deleted by parts during driver unload process. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c b= /RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c index 96ac70f418..64b7fb7841 100644 --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c @@ -481,6 +481,7 @@ RedfishDiscoverProtocolInstalled ( ErrorReturn: if (gRedfishDiscoveredToken !=3D NULL) { FreePool (gRedfishDiscoveredToken); + gRedfishDiscoveredToken =3D NULL; } } @@ -511,10 +512,10 @@ RedfishConfigHandlerDriverUnload ( gBS->CloseEvent (ThisRedfishDiscoveredToken->Event); } - FreePool (ThisRedfishDiscoveredToken); ThisRedfishDiscoveredToken++; } + FreePool (gRedfishDiscoveredToken); gRedfishDiscoveredToken =3D NULL; } -- 2.37.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100038): https://edk2.groups.io/g/devel/message/100038 Mute This Topic: https://groups.io/mt/96886534/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-