From nobody Thu May 2 05:28:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92392+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92392+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 166032509683987.0617700322216; Fri, 12 Aug 2022 10:24:56 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 72HmYY1788612xtdCEBhG3FN; Fri, 12 Aug 2022 10:24:56 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web12.2042.1660325094168827344 for ; Fri, 12 Aug 2022 10:24:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UajThLNtAA1Z4v1mVxgctFHLTU9ANq22VZkoMReKgsJQUgjtL7CGDLLVr6DJ5YG75tIZ7N8U7ZMIBS5ieLdwSuVACHH8MNzli58ZHgXpM1RRKm7ef8K7lhV+WreBV9q7DHxu5feneAxCyWAhdft0PMxSCsFH8rbgaEPfP0ZPylLp+KbuqDIr+ZD+MPIqd93EaEd7MEEFlzOntp489bWQ01hrqgLR4vmfTmfsITfKnc7Ldg6UDZixzFGj2IarFieN1kByuSuaLQYk5x/5uhABxyb0FYeY4jYQ0uSvdcUGrA7ffj0xLrJ8MtVzMyx+QDNzV7SwZOQ4S34+9PFkAMQpjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tuENDFCMiL2kOVXBsc12Ix18600jbgKgfttuBLKDwlg=; b=JT+a20x2TT/hiVw0rZ1YRuVxvflTkkfMmcMopnys0Zlqpiy1mGdqsDjPvtHzu1ANVEUdxJxWfTRkCETc/kevFZbdE066wwEqTglV3IH/cTHMwpNMoykcby4pG7Gx5Iyjfg4Cm3w5+aebff43rvhY7eO+CyOXYJmPkdKC9/oslO5ZnKCcFZOSEwJ0PzlPq/ywTLbeqC/tHxPMYeAbRo9Hd+S42MhLl2E41l7T3424KHlbdNTcYw8NIrYjBJwWiEJApkaaB1WAFWk8cUIRCSsgRNS89JHuFKtP2ti09W/Brq/rdk3pnb6kGx3uRYoOyeKqkilaUx7qpwb5jCl46kVsSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by BYAPR10MB3383.namprd10.prod.outlook.com (2603:10b6:a03:15c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11; Fri, 12 Aug 2022 17:24:50 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::3007:4429:73e9:503e]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::3007:4429:73e9:503e%3]) with mapi id 15.20.5525.011; Fri, 12 Aug 2022 17:24:49 +0000 From: "Igor Kulchytskyy via groups.io" To: "devel@edk2.groups.io" CC: "Abner.Chang@amd.com" , "nickle.wang@hpe.com" , Igor Kulchytskyy , Abner Chang Subject: [edk2-devel] [PATCH V3] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Topic: [PATCH V3] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Index: AQHYrnBt4bS3+gJhfkSTogLvgxu6IQ== Date: Fri, 12 Aug 2022 17:24:49 +0000 Message-ID: <1660325080-8432-1-git-send-email-igork@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e81d79ae-ee2a-42ef-c3ee-08da7c878fa6 x-ms-traffictypediagnostic: BYAPR10MB3383:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: WiIf1o9B2t9hCa+a16ND/F4UKIsqCgbHqO+jeEE5qSXfUc8um4+jABAV5NLHYWKFQjkxKDrAyBUKHkSSAG0P71LeFM/U8/2iwDmmIeD4xCYEbMASyTRXl8o3hwXwyNTpwRh7dYAT9V2WjtE2iFQUZLQ2zARu93qkPpoHm/j8SUvT/yC92W9BYi7bxZfscd1toMDuOZtDJf0bd6wCmNcSOjotLafy3rteaqNoDfcSwPy/ZWLsRs2laQrliDSNYTW8/ToEe+PI0Sqq/5hnUZ6R10bePzlz05jqIHq1elwlUdzmpUekqiU28exE9G87+leS5Tl/ERfvGsWjWwlzpQ2BPr8vwpT8hHrrjnReHVWMGAQyaGHbsQVPCxLwDDw6hpxwIMNltZyRaUqoh7KWkVTua892+tRdNTCFXABzIzXGGL0p3mLRX8+1Rx+pen2X3w5EzBkVzWJgYLusb3cW0yme8irGSRI9E4mV40W8qKeXU3Iljwn9clMeijOcoXSKBfKRGyE3esTUVVN+wC5f5QHh1Vc0oljvAPm2dS3F4HtCN7f2RLpfRWmS2aBk5b+mRr5N7+prcyEdssnJBltHhQVL8GQLwRhKtW/nEVPnQBbolK+/Vi7t8FXY7UcSSXfrKZDY4FkRrVN5wEt3/FY1EQjoPBS2h4KBVGy11zMbbYc7JqgMxZHC/HrK/30TkaqOGIas3Xrd/DxPab36OfkExTlJWuXb/u0bH/gtp6X6nMktwDD9PaIoIXUZ4dIdP+N9nUEevjcxdpHqiBcQ5uw9XI33fYjHvdhWSDlRNVNp31W6CnpfQAoCSYVIg2r3/xc3efHc x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?KeKLzBk8scR830QMRu8pk6TdvrhD8vFW3wZpz/eN9wPCheHDswIL77Ymij?= =?iso-8859-1?Q?mjpQGGIMPWbUxbOZzfft5ObbUN6MV6sU2DE3k/XXY/LEydPgrweSnWLwhV?= =?iso-8859-1?Q?E3HZ+YykQDPv2pqFbLwW3LuN6JKMuIWszVuS3IxnwMhF7orNeEdI7u96T5?= =?iso-8859-1?Q?1n8M22ij4TO6SFPEkRJoAsGmfV9y2CzqRCmU2063/YViSAIhmXhM4zZVWt?= =?iso-8859-1?Q?pGhyAJ6iOEHt2Fhzfi0ZguJ1JJ4ySqiyb/WLsFg2IPOqQZkGM+Jvp8vuRE?= =?iso-8859-1?Q?JywLqBkwIM/p4qLRCEz5aZRq6lvFV393Vvv0e5QA3QJUd2lOJ/zN0nMGZ3?= =?iso-8859-1?Q?nXBFNexxSn/mag+OuTfgt7VxQRmRBMD8v2cBP/naPj3v8Zmu0seRdQNmIX?= =?iso-8859-1?Q?9P/AvR/KJbamNFDt34oHOd8P1caT7sA+LL/QExFuITMjPKtGZSijKLV4IO?= =?iso-8859-1?Q?NqkIfBDtj+f+6shtNgWOZqIyyANmUBWr2PoXBiLKLR7Vxt4XL8iwKTH83T?= =?iso-8859-1?Q?bhD6JeTwdvtbKo4MmyZnOq/OPQ0wS9YlBSZzBkVEMu3uRtsqCQHUGB44k+?= =?iso-8859-1?Q?HkjipZbPxMuJPjtdf3a5V9knHuiQvaC/IsLkfBrti7z1KxS0MIp0sShvtO?= =?iso-8859-1?Q?8ks9e0cp6YvRoKs581VD/XrQ3kmj9AgGb/OmypLdTF02SvHNlfLMmIBiOI?= =?iso-8859-1?Q?7aLfYV2KkZ1WqSjhfBT/xFDgBFZF3lIZkpup+siS3oPAKi08AMJQzeTiH0?= =?iso-8859-1?Q?j+FlJozSfWjeAgMeEwTKLZA5oqotB/KVE2REBoGJ69Zc0O03xasb22OdBC?= =?iso-8859-1?Q?rrXJFaVwn9Zj655bpArZZFtcDTfhTGEsSPol2oO43pUrPByNGbJfXAZQHl?= =?iso-8859-1?Q?IB06zwFPUHiEFUKXfrEhiWeCApH7UbSt6q5n2GZgfOaHx/FZyFFHCQ3Qw9?= =?iso-8859-1?Q?cD/BKPGzasNEm6mrtZOTqalMW29USNZTOUBu6uJ6GQUuRqecHncExAr6xZ?= =?iso-8859-1?Q?Kugs5doDCsugDigKW6e/VXgzyvMod++57bKGahOrePOpOFwqKEXUdaeDnb?= =?iso-8859-1?Q?s2Qn5C0aRMmp07JV4FCnOohog8pKbXETrFHEQ9ulcdU9qpN7BDSeQp8Rbw?= =?iso-8859-1?Q?43r/W0EeoBQQac1V2LpNjdBHWEBmEKnjVOGKQ9xM+VTyBDXtMYOySojMXe?= =?iso-8859-1?Q?21xusllJwYrqihUwOG/kPZcXHEAv76Ux06PvN09lfAC9Oso/nZ3EImw7Qz?= =?iso-8859-1?Q?/6kCsjeqkh/FB3pYHpiKpTZ1jQ/CtuYIeNz82qtpdQnyKooixcroRf8B4t?= =?iso-8859-1?Q?eH+7cgQlU75IRgXgi7f3foiSUqocRJL+utbLy03v+o341dVMY5Gy1bw1ts?= =?iso-8859-1?Q?dGqCsn3d+d6u6VIT62XcwGpaD0bZISsqouoDcecBHDGI8Twrb0PmC3bhfa?= =?iso-8859-1?Q?YSAUZNaZTSi5Jl4lvnkws4wCrNjWCdMhlxNVdTOAHl8LYjA3BPtRe+F6+q?= =?iso-8859-1?Q?eRf6sdiUmRGvt8wY6ltKg3FLWP7C9J+t4dGGB6dUjToU+ItJ6VCYW/DWDI?= =?iso-8859-1?Q?VyMX6SNkaXj1voD9PGjt35sqWPii6LQnCCQEEoOq1SzZUreaSet/9LhbZL?= =?iso-8859-1?Q?HWyPcDgNL67/KcaFgaCI5aQ6Gm+LeZuGnK?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e81d79ae-ee2a-42ef-c3ee-08da7c878fa6 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2022 17:24:49.8534 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JPHVCLg9MZMKek2T9wdailCBNCzfJ8C8a+7qsm/Ult6fWzMiUsaRBacrrjD5zqVt X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3383 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com X-Gm-Message-State: MqkUQuz09vAjv3fVRRgz01Kex1787277AA= Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1660325096; bh=jIRZzBNE7+V6nLw7NEL+/Qh5Ay3BEzYTCmdMO694Dqw=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=nx/75C0w5adJYw3B8Y/6fgucPvbfehW+HZM+/HpiwBFvl8cnHF4qAOvxx2d2NthQhfe k/VCN2Dq9A8zuDEP+l9o0+gAHvITrSyC5J5Kw6a17LT6K/65Gi0cOwsxVTxNej9gdrdp2 JrVXldrNFAhYVFTu580weHUIunzECMOVvJM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1660325097523100001 Content-Type: text/plain; charset="utf-8" Host Interface details are described by the SMBIOS Type 42 table. The table is published by the RedfishHostInterfaceDxe driver. That driver supports PCI-E and USB host interface types. The table is consumed by the RedfishGetHostInterfaceProtocolData function in the RedfishDiscoverDxe driver. The function only supports PCI-E host interface type. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Igor Kulchytskyy Reviewed-by: Abner Chang --- RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c b/R= edfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c index d79750b..0090525 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c @@ -65,10 +65,14 @@ RedfishGetHostInterfaceProtocolData ( RecordTmp =3D (UINT8 *)Record + Offset; // - // Check Device Type, only PCI/PCIe Network Interface v2 is suppor= ted now. + // Check Device Type, PCI/PCIe and USB Network Interface v2 is sup= ported. // - if (*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_= V2) { - ASSERT (SpecificDataLen =3D=3D sizeof (PCI_OR_PCIE_INTERFACE_DEV= ICE_DESCRIPTOR_V2) + 1); + if ((*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE= _V2) || (*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2)) { + if (*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCI= E_V2) { + ASSERT (SpecificDataLen =3D=3D sizeof (PCI_OR_PCIE_INTERFACE= _DEVICE_DESCRIPTOR_V2) + 1); + } else { + ASSERT (SpecificDataLen > sizeof (REDFISH_HOST_INTERFACE_DEV= ICE_TYPE_USB_V2) + 1); + } *DeviceDescriptor =3D (REDFISH_INTERFACE_DATA *)RecordTmp; Offset =3D Offset + SpecificDataLen; RecordTmp =3D (UINT8 *)Record + Offset; -- 2.6.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92392): https://edk2.groups.io/g/devel/message/92392 Mute This Topic: https://groups.io/mt/92984581/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-