From nobody Sat May 4 01:41:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92309+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92309+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1660162270964116.25619630492054; Wed, 10 Aug 2022 13:11:10 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id CbQ2YY1788612xwVz3i22idU; Wed, 10 Aug 2022 13:11:10 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web08.3150.1660162269274259662 for ; Wed, 10 Aug 2022 13:11:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AaKT3eCDvLSwyIeJEiYcPsNGSP6RsbYsGTRHs5I/lRsAHMmciuMnKXLUzPRx+R5F2xAOyA8Wusse4i/k6CpttNch1ZbteuNoTHB8nFDtSNGEpkhRpyxi+L4v/qdFr6YbJKimwVqwl+xDHq++KgDphhfmiiYZdolybOGTA1FmCTp+VHauvRaWwJSZuAfpptCSNmaon7zUFHZEgg+1m4pYHUSRJLOczKf+z1dZL/k5xJBkeQ6YIsXF1/4n6vI359+H7LqiiodI/bMZSfDZWR/MkP1/nA8+pDfEs3rX5ZMvK82qfiRNPhX8GJvW6PMaP/N4cmYQ8upIlZFyhg9G/Ka6xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OmCM4ZouBaoyxOS7Phj3wOgtGcLiRN6IANjRzA3z0ZI=; b=aHwKpo91zCuSr4uGkYgYFbrk3MXRsw0KwhD7mATC0Vyey7Djbervu4vmunl0Hq9CyBZao0EnAG0Ss66e/bE0TA3mqQ2x4qSyzWT4/FtXglAvqWGoP1KoHhOaYwcgWRn/D7/4GgiT9a+Z3WUI9Vfhmlj7V8TF+92cU9PXgX2RquFaVz+wpedwcfDxmRubOzHgCYxWZqaPZTDzl9OEmRwuNcGEMzUlbVkccBT36N63l/NqtuxFRM/RpGApzANol9c5FTY1Zn+5MJ9HR1EutP9f69nFoZeEtQ9JS/iEDrjCzaYADQNbTNR77CoqMiuMseQaqm/I0aax8HdwFBCTfZqKMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by CO1PR10MB4642.namprd10.prod.outlook.com (2603:10b6:303:6f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Wed, 10 Aug 2022 20:11:06 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::3007:4429:73e9:503e]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::3007:4429:73e9:503e%3]) with mapi id 15.20.5525.011; Wed, 10 Aug 2022 20:11:06 +0000 From: "Igor Kulchytskyy via groups.io" To: "devel@edk2.groups.io" CC: "Abner.Chang@amd.com" , "nickle.wang@hpe.com" , Igor Kulchytskyy , Abner Chang Subject: [edk2-devel] [PATCH V2] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Topic: [PATCH V2] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Index: AQHYrPVSkYqCIEsaE0CVehSJl7+jQA== Date: Wed, 10 Aug 2022 20:11:06 +0000 Message-ID: <1660162257-21424-1-git-send-email-igork@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c174c0f2-543a-4ff0-5503-08da7b0c7565 x-ms-traffictypediagnostic: CO1PR10MB4642:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: xsOvisY8paowb23HsAzhtUVuuDTXOxjMZfK5cwWvSROIfsbNLuIPpWNJZIgxbuW4I3hFBtLTaGw3NQo3n5eeBKCy6SpgwwTWHZawwWVL+Goy+8Fi3Vh8NH0vHIc64Be8PegjxkEQ84hwcz7m6K6Jv0AeSswDZqYnYbqPMTqwRy4g7gJyd72cg5irsZK62A/ddhAG9DAAmwH4lhXDxJ/rkrYgpquKPmsVjXnrlBJXcTlJAgHaelWPEXeR7Sjw9KgOYWLiMhq4S/bA09DYHb2gxZaJFhi+kdW/M2DFFp0r4K9M7KjQA5JnEuAZiDSZl8jKWjX/+B0ny5PoVR9ahIfex0qifFXxVxTgNEbA3TfK1nqaii83KaVrBH0LXP31+CawCJJptu1qxGlF7L2JY1adJZBmaoOVsRDPNZoj7ukbNzdduS9acg4TTMk+A6C17NQoA2REHTJ5yFVaahPh3ReS1slUhyORITMaFP1YAHxKIRaWvQ5SBuDFb0OtXn4ZS9Oi7+cn8PFGc9v5uqAovlGt/86NA78sXL+FE/MW6LxgOUob3X4mElRSVs60h1eSA3xoTDjORj5W6lD9pfbU28Ho1VrIjeFEONsZ81Iu2CxkwlxCn/5U7UsUko09vFZn3uRg8470yfxctT3k6vG3bhtNlv8b4OzpAvTZhAnmGVulPZC/Je9z3SpPyFMd+I5HM1peMSEwQ2/c+D2Dc7RjiEij16twIM+UhhXINR2eLOULrucNUhpacZvhV8sQtpRpCAaemiL5UiiWwA4VKi4C5Uw0dPdLaG8dktTx/hFLJEQrpYofKQe5RBkEHCk/8upiju/5 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?V9Z2To1HXg5wmK4QIpQiDTyFJMJ2RE5WR4AHiv7liyzVPaafUIsmOBeOtj?= =?iso-8859-1?Q?1HR51oPbapfJ5go+TZpnJRTz/J7Mj8LvqCYVdXzNzQnP3xGsGhH2xEE/Ky?= =?iso-8859-1?Q?+FNr9MaratDbPjN0p+Gc6HvaIrjJqWw67Qrsh+FJIy/JQq7wDXkIyUS80M?= =?iso-8859-1?Q?Ha+NPF4HMONdSbFvJ8ZJeRl55uLgSqLmGYjs50NrNVr9VLWe/gaL+IX4Ev?= =?iso-8859-1?Q?8LM5hvVHD0xkNM8ztZv61dDJcQ/pk5vJ3E21tA6RAJoW09iZ2Uh6+1dqc6?= =?iso-8859-1?Q?dV/wlj65nVZgOCmC20V23rfrfYK49x8hae1TikgnUamljmzpuei5PkZHJV?= =?iso-8859-1?Q?M045u8PjDT7bVSt4I1VqjTTb/FPHtJkCXdM33NSfB49HVEktPdf/IHeij6?= =?iso-8859-1?Q?Q4UDzwawae30GFugplwViCPL4plOqh0L5cRIxMC3XJhCp15EEEQ1u16RRd?= =?iso-8859-1?Q?HsQBvxAxJOBrFnLnE4YPIuMAQst4L8J2m5gqFlBJj5UD6CTMm7P7Wak4Yg?= =?iso-8859-1?Q?AQ0SALiXN89g+raWbVvCU7NRoIibnWcrI+3iVCVZXesLPeNt91OA98GMKm?= =?iso-8859-1?Q?v7c7MMSZtfabkq8U2TKvOnlclauBu1mqlf/QhqIMi3LtNdl3C4p0JsfH9S?= =?iso-8859-1?Q?kTb5DCBPc5sPetcMm6oJOC2vLRDA05TILi3RjdPV2ZrLDkJ/8ZzpCTjUXj?= =?iso-8859-1?Q?+cgqLIAk5tWvAQfgaMDd+bZHeWiJkX4keXJ3SttR+QlLNs8sWBkgZx6OFn?= =?iso-8859-1?Q?419EfFHJWH7jCzjGAPlkxhVX9pXnAKn5XpKbZX/4iTbbcJ/hfezko/2OD2?= =?iso-8859-1?Q?VRmfEp/5jQbtft/4UIPTzqO0EVaRZcdC4ep64eoNna10eN/SebUo4cJVK0?= =?iso-8859-1?Q?d2RuxdvSQ1c1HF1GLYFmf2U5BWG7rCP8+KxHX/kKSK5O9VATZC1XEmpH4m?= =?iso-8859-1?Q?QJ+2oU3c3HYhFVt0CFKubd54IZog/8nz2h6JzkQXnV8OgZGXJlxRx31sbX?= =?iso-8859-1?Q?q1QkOH3ry4vPo8yLWsLojefjRXEg9SKkKQlEU0BTajYLXB2r29qjZjpm3y?= =?iso-8859-1?Q?Fl0ZwMJaA3vLyc7E3br1vBbfjs/TaiWXkcdgLUViOo0x6Y/TvzGgkwX2pf?= =?iso-8859-1?Q?mogLwH/e1B6jXzURDpxGevpOv2jtNJmUP14bKsESRaR2BG5W9DcWBVOC8f?= =?iso-8859-1?Q?EtOk6DFRNzfum3PWY6e4n7/De811Fx0B6KloG2bpA0dKZP1WnXdZLQdW4v?= =?iso-8859-1?Q?slXmLD4kIRBytXymqFx3nE19gLXrPhZ2Nvu/LLbHTymG6UinI0A/gwLkL1?= =?iso-8859-1?Q?AxnqiDul6gvPvxOwFDb2/lypq/xgcenz0tDra+M6qCvoPf2s/VA3YsFFJQ?= =?iso-8859-1?Q?mzmJvCeDIR+ZLSSiS7zZZRCpfLO5bk5NM0QazWLZwBq80hswn9JbERXE74?= =?iso-8859-1?Q?imQZRBZJ2zPdouGjvbrAAepuzs4/4NigYQWc8+RNYirSZ+9OXP08+MHqkO?= =?iso-8859-1?Q?MEAdoN8cYaEKgMb5b2pt5YiKg7baih89iHoflS7vxZ1h8jdye4gQVAAPqo?= =?iso-8859-1?Q?7K0rC0CAV7Tkt5zArajJYOhXkJu/XQI2Huut/oC4rjF0/Sfm1T/0l5eyvF?= =?iso-8859-1?Q?zOmnsGqLvIW0vqpcuGGmN+1255fanr2oCn?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c174c0f2-543a-4ff0-5503-08da7b0c7565 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2022 20:11:06.5433 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6+g1oxck/A70BzL6jqEDYbXf7KtL2iN1MzflRnLxmXOCcfLMLkEFXl4SjGRZrNLw X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4642 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com X-Gm-Message-State: snWf0plYyMtp2MdmSj6kq5Bsx1787277AA= Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1660162270; bh=DMddPFZ5M9hKaxrB+q9Y+wP6hMr6pnd1JOktfMiK+Cc=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=g/G74Yszs7Y5y8W36q+MNiAO4yn8YyvEq38H2lZDDmrp4zCrmfx3B7xv7b93KcP2RF8 E5zI2R0a0Dgl0plmes8/WPqkvVsOqAivWqGUxYzHMATD+s37uCfL9y3eeSyu3+NAFTBAc k8u5UV7sb/8Gh2JcuOfMGtS6mQg7kdbAgUI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1660162272213100001 Content-Type: text/plain; charset="utf-8" Host Interface details are described by the SMBIOS Type 43 table. The table is published by the RedfishHostInterfaceDxe driver. That driver supports PCI-E and USB host interface types. The table is comsumed by the RedfishGetHostInterfaceProtocolData function in the RedfishDiscoverDxe driver. The function only supports PCI-E interface. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c b/R= edfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c index d79750b..636a1ac 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c @@ -65,10 +65,15 @@ RedfishGetHostInterfaceProtocolData ( RecordTmp =3D (UINT8 *)Record + Offset; // - // Check Device Type, only PCI/PCIe Network Interface v2 is suppor= ted now. + // Check Device Type, PCI/PCIe and USB Network Interface v2 is sup= ported. // - if (*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_= V2) { - ASSERT (SpecificDataLen =3D=3D sizeof (PCI_OR_PCIE_INTERFACE_DEV= ICE_DESCRIPTOR_V2) + 1); + if ((*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE= _V2) || (*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2)) { + if (*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCI= E_V2){ + ASSERT (SpecificDataLen =3D=3D sizeof (PCI_OR_PCIE_INTERFACE= _DEVICE_DESCRIPTOR_V2) + 1); + } + else{ + ASSERT (SpecificDataLen > sizeof (REDFISH_HOST_INTERFACE_DEV= ICE_TYPE_USB_V2) + 1); + } *DeviceDescriptor =3D (REDFISH_INTERFACE_DATA *)RecordTmp; Offset =3D Offset + SpecificDataLen; RecordTmp =3D (UINT8 *)Record + Offset; -- 2.6.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92309): https://edk2.groups.io/g/devel/message/92309 Mute This Topic: https://groups.io/mt/92944861/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-