From nobody Sat Apr 20 11:49:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92121+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92121+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1659629493980710.6636557611331; Thu, 4 Aug 2022 09:11:33 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id OyFFYY1788612xeTfdHLds6J; Thu, 04 Aug 2022 09:11:33 -0700 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.79]) by mx.groups.io with SMTP id smtpd.web09.6259.1659626715805104966 for ; Thu, 04 Aug 2022 08:25:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jkKmVrAhlc72fcOBqWBYqGW9sI8hZ1j27yu0kiHJcwNnaL53lqv+kCRNXLEJeCriHSiSqxCc1VFUh/4dMUsMe9UaFh6dpHRFhokXkleehSJrMMxgTg1yXqkC+22TbvTasqQWfJK2O1Zx0Rj9UR15NfRWrSu9UJFtQomfjxgP7w9Dw5+oArKKj8PiU7gHvclq1RHDOyYvE96Qds4ThHn6ywY9ROtDZSAZlH99tLJM/PYisLqEyu1A/qlc5UD023D3AXbEOoPA9P2q/xWAmCAggPx2kmBP4Hptx6/yfqIkkiYQJrWaV6EkfY2DnuhOLLExQDyzNk58hPPDXIMkDJcLAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8UmW2BEgdBss1ccvTkm0eS1mtyu9dz/btRBtkLCTxUU=; b=PcGo2ewkdKZ2wmHXMY69DH67vL3H4MnhjJy7Xn1XKphLDgiipOV6F67uMSTHx8bxOUbxS36sXQZj8Ao9KU1wqRO6XrfTaI+TTrzvCQuGNtWJjO50/KpojXckiIcY7WEYPN8kfLk5CBrZJEEHqHISXMwl0FJyLTSkgDsiWOlKZIuFIS6bk8Wg2aMZ4W2STMFhSI3E+jXa2BG7YL5VXyeorb+GPcYWqiFkyzL/GQWM+SJt0E4slpveRjMRgp9c7WxNmBaFpJYmZ5bcxLc22cTPj8GdY1b7MX95bUrhIXnEXL0SbQdOPA7JKWfqfK8oRsUwAK9PUE92I7XslZgRHwxxqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by DM8PR10MB5448.namprd10.prod.outlook.com (2603:10b6:8:39::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Thu, 4 Aug 2022 15:25:13 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::9da7:b02b:d292:d57c]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::9da7:b02b:d292:d57c%7]) with mapi id 15.20.5504.016; Thu, 4 Aug 2022 15:25:13 +0000 From: "Igor Kulchytskyy via groups.io" To: "Abner.Chang@amd.com" CC: "nickle.wang@hpe.com" , Igor Kulchytskyy , "devel@edk2.groups.io" Subject: [edk2-devel] [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Topic: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Index: AQHYqBZkooOwOPqdpUetZUJUGJMh9A== Date: Thu, 4 Aug 2022 15:25:13 +0000 Message-ID: <1659626705-20532-1-git-send-email-igork@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7c2b8220-f6d0-4e8f-dc07-08da762d86fd x-ms-traffictypediagnostic: DM8PR10MB5448:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: dqZP1WBhQaEhZ1hHCJqb7pxzf1XmiZV31PQ6M6Dsm8uRX0i+1mohQTtTQTr4sFB3xRNMrigI2aE167f89suLqQXKn+Kami/b5x+pgmHm8HhbP2Kl2CVvC9wgrQdTPcqVOrlo2ampuaJ8d/1w9BfEDE9lh3ivx5rOm5s+hrIpiT5Dm5QQaadAaZXE1ZDlC9UaJtHO3aS4JMjqc1wJ5NJHmpiXOQQ16zp+3AhiAbo89zrEM6LAaEXftLyG5Ln9DJVKBFcSVwQrHJ+1QtvzmwM0rOYDPZH5EKRxr+rhi4ry/irsOjuuu7H68gXWfNk8/lCDdAFOxNtgwmNQVAzghh1N7I+KTkNoI/FKzzp6ZpzWow7OnhjnQIiztfLaip9JEU8tQKFcdms20pJSlu6x2A+BsQU1c7wa2x/CwV/kuCbya0KfeCDKdO4uS1pQfAcB1FVsDlbvnJvg7hMkz1J3E+sK+8m1XdIJSiDB/wTsFTmlO+XwVSdfpjOubj5UnbAQLaPIIG7C6MHvLQ8n3wvBGWHaMDqa7V+2WB+wr3t4h4h+21ISV/8ynsplFMSHqhJ67nqESgY/UNpxRVzRXoZPeEdclkqMdfxNYRhx2qhSsmLFki+xHsB8Y6ScZqiY5Os2ZZCX/E/06ueRLdwvCB/SEeL2Ja0hpZSMq/LvO4h0JOVs5EJ68Eg4xNHzcEBP81yNRSTpBHNRHjE9TZ1iAEHYc5VQRvXHh/06y/z24lrdTysgci+87160PpI2dl0bjGP1bmPhhlvQ6+bbZxpoPp9QRzJDzrdG64xFtWUYl6nS3CPtGrasHr7JGE9g8UFqjITxNoBw x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?JItKEsp8u0XvHDSkkGTHPjOSYWiOKcfz/x+kcu1Hkwn8K4hkJCKj1dl6Vh?= =?iso-8859-1?Q?2B4In1DHCaMK7t9hrHJ0BZPNEdbfD8RWHNhn0URGHuHpECbP81UKdVqXVg?= =?iso-8859-1?Q?BLWO5s29RRdEifpfMrbcuK+/3IiAH9ccBBE30dy/XGxSBGWL/E31rvCC44?= =?iso-8859-1?Q?AAp1ToVE2yt6tbvn8mcXOeY1NN15e1F6fZIDeiDvl01iGvMzMxQa+hiojb?= =?iso-8859-1?Q?kaua3/rMhNWbCqtFYHq82A7cmZgDaDmNEgYks1G8aZ3YiaySMrjZbIOmz4?= =?iso-8859-1?Q?aKgjqHj3aMI5kSELAjXkF69ohRjrNXHZC5dUrQflVEbZXnUA/PxYg8oh12?= =?iso-8859-1?Q?Eam5NKlG8NCwjOc9HfAzqDrlbk8s0vqbvkHAp8OOPYdibV1kGNF/SFuCuv?= =?iso-8859-1?Q?JH4YinHub4Zars5sgWAJ4yJ4alvAVts7BHWmqDRfkO5o66SudAW7OfnSzF?= =?iso-8859-1?Q?zBnVKFrVy09ZQE/VAcJHJV/BWzRdivZh0ocTVkuCvNTep+A452ow8SWuHx?= =?iso-8859-1?Q?waPQAnjMlimXwmbr0Qs07f0bpm4csKpEPIiwZKXl7QMSlkrv1J5+8d0JZZ?= =?iso-8859-1?Q?n5jV01NM0k9xH0TFehD6cXXk2aSmA0rsaYtPDzgRN+N4as31uQHcqSeNcJ?= =?iso-8859-1?Q?S8+YPs/i6bxGifOPl3j5Y08UKnQ/n4r7ObOCrBe+GxWYufpt5mmY0sYoAS?= =?iso-8859-1?Q?c9b3dCRsn6G+fT/69BLNfeNy+gJIfGCFKnYfL484+jSIJJOoPUz6kk+sky?= =?iso-8859-1?Q?ikuSVYkNBHYKi2wa6FxYxIOIX3hvlCCCld8xWKj7TxchZVfNV9O3heAIW0?= =?iso-8859-1?Q?BGt8GQEgtsgJkLPqJ1Xlln94rjEfVpyRLoofokyT70/Q2TQf6rxExV6tbN?= =?iso-8859-1?Q?D2H6HCZ9mIUBsZ7moNCCp4XCgzxHOcsXNJe2s+X/d/fI/sUSa7Y4TGqGri?= =?iso-8859-1?Q?qn6EugsYKn2VIP504Q00PPcxS+RXAHcCNbBCAsm41QdPK2XIjxwhRR89fJ?= =?iso-8859-1?Q?tfxm0BQe4shgDUkKqD3pFNL2+a06b4JD5lCa3bP92pK0D0a5ttCpAFwVvL?= =?iso-8859-1?Q?mVGk92x7ZhRt7bn+kGjzmPp1oCWLrwmvSZvO5JOmtcv1Vfce3T1Fylcosz?= =?iso-8859-1?Q?z6SagyD99CSU75zernIyJyg7EE7KLTZ1BJsDVN3ktjxowGRzsSli5XS8ku?= =?iso-8859-1?Q?S5mnUBJW/VKYjkEZpWYT6++WER9hy/86ljglg3yGp1NfqIVcOF+aOrdORP?= =?iso-8859-1?Q?HJfutUyeZwLkWwrXIEyjqZDXmvGflUQ6nEMDyY6qstpoSwT+HJs4J7YyZP?= =?iso-8859-1?Q?PCJmJOFa4e2w2GLd7D23ODGCMRM/tRw1ISqnpfANHbqu+2YUvdPj7jnYTH?= =?iso-8859-1?Q?o079i+r3a1OK5DpFsRO7v1X94J1YDCp0IZ+hNd4e/iCknaT53r6re8gu9e?= =?iso-8859-1?Q?GQ4TA5rOxaEQlSSUJaSFp5eC/qeOoYLFzOEz2piFXuT1+l5pKilkp67Kiv?= =?iso-8859-1?Q?/8mFnzjTwOcqksfuDCREVyvGILtXesyyGHb1lvYs9XlojOTXSfoJAD6iDI?= =?iso-8859-1?Q?ceT947hMgEk3x1T/KPUDH4230TOy+4mKUh0IMPeK2SglbKUVhxnyIKapR2?= =?iso-8859-1?Q?J9Bkw8PzREx30M5Pu5XN2w3RRhjjqF4OFt?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c2b8220-f6d0-4e8f-dc07-08da762d86fd X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2022 15:25:13.6423 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0T1tW+r0Da3MiLdGzzt1k1Y7obctpY2EpLdegR6NrPGpM4FGzcAbGHCUN6niPTDd X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR10MB5448 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com X-Gm-Message-State: 1HXtGDphfrs6IgTsGoG8iDsox1787277AA= Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1659629493; bh=np6wdBHsSBeOMkvSbfbYCiuI2ZABiW5NTMDtzWeNT+c=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=bmfo+hSIeSMMZutcTxN7eLS5hDdSRK+kSV0Ium8Pl2nNDsxlJyDwuv9nPO/GfiNBngZ 69QOYtJCFPlHHWKp4K53o4QLvptSP5NTHjqvJMP9QQvUmpxIS40FHdQr4rlVDt2PTsn7l 6LeWo240w+BqNPg2Mw5CJ2hJdKHuL56lvng= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1659629496009100015 Content-Type: text/plain; charset="utf-8" Host Interface details are discribed by the SMBIOS Type 42 table. The table is published by the RedfishHostInterfaceDxe driver. That driver supports PCI-E and USB host interface types. The table is consumed by the RedfishGetHostInterfaceProtocolData function in the RedfishDiscoverDxe driver. That function only supports PCI-E interface. --- RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c b/R= edfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c index d79750b..a3b977f 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c @@ -65,10 +65,15 @@ RedfishGetHostInterfaceProtocolData ( RecordTmp =3D (UINT8 *)Record + Offset; // - // Check Device Type, only PCI/PCIe Network Interface v2 is suppor= ted now. + // Check Device Type, PCI/PCIe and USB Network Interface v2 is sup= ported. // - if (*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_= V2) { - ASSERT (SpecificDataLen =3D=3D sizeof (PCI_OR_PCIE_INTERFACE_DEV= ICE_DESCRIPTOR_V2) + 1); + if ((*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE= _V2) || (*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2)) { + if (*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCI= E_V2){ + ASSERT (SpecificDataLen =3D=3D sizeof (PCI_OR_PCIE_INTERFACE= _DEVICE_DESCRIPTOR_V2) + 1); + } + if (*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2){ + ASSERT (SpecificDataLen > sizeof (REDFISH_HOST_INTERFACE_DEV= ICE_TYPE_USB_V2) + 1); + } *DeviceDescriptor =3D (REDFISH_INTERFACE_DATA *)RecordTmp; Offset =3D Offset + SpecificDataLen; RecordTmp =3D (UINT8 *)Record + Offset; -- 2.6.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92121): https://edk2.groups.io/g/devel/message/92121 Mute This Topic: https://groups.io/mt/92816627/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-