From nobody Mon Apr 29 05:48:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+79816+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79816+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1629940884; cv=none; d=zohomail.com; s=zohoarc; b=lpu8mnTieqYpz4MsKEozTEMWOF4CbDK9nz++kruhzWrqWPQjahF8VhXsw0dElOFlKuev83sqnHD0PUEHZfSxtHMK0xo3kAFei4OCtjVETq62RV1q8dYfk1o6Z9KRxkmeL0QE3SGxEMN5vf3pLgt6pH9dTXdOUCIAurg8ao8ui4s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629940884; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Nxk5YoHkOH2Guybm9e/WX/kwumadblmPU2XWtkxJjjE=; b=DG8bopiObGonX9j4DJdm1Qdvz33FjxhGeHm8cRN+sgKI4J41ZguL2cZ2EzAhjW7hJQx26rvL3rJEqGp9D53jjHJd8Uv4jMyHfEQd2H9qxHWJEjfzDKK2uTTqwgTJtPV0gj6QFlXmEEgWCDCO77euUW1BFWUHl4dDydc7zHMR4O8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79816+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1629940884770779.5478044907537; Wed, 25 Aug 2021 18:21:24 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ECRmYY1788612xr0jqtFZqRr; Wed, 25 Aug 2021 18:21:24 -0700 X-Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mx.groups.io with SMTP id smtpd.web10.24752.1629940882400848476 for ; Wed, 25 Aug 2021 18:21:24 -0700 X-Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Gw4mF1zFlz19Vcj for ; Thu, 26 Aug 2021 09:20:45 +0800 (CST) X-Received: from dggpemm000003.china.huawei.com (7.185.36.128) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 26 Aug 2021 09:21:08 +0800 X-Received: from HGH1000039998.huawei.com (10.184.68.188) by dggpemm000003.china.huawei.com (7.185.36.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 26 Aug 2021 09:21:08 +0800 From: "wenyi,xie via groups.io" To: , , , , CC: , Subject: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead code block Date: Thu, 26 Aug 2021 09:16:03 +0800 Message-ID: <1629940563-82195-2-git-send-email-xiewenyi2@huawei.com> In-Reply-To: <1629940563-82195-1-git-send-email-xiewenyi2@huawei.com> References: <1629940563-82195-1-git-send-email-xiewenyi2@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.184.68.188] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm000003.china.huawei.com (7.185.36.128) X-CFilter-Loop: Reflected Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,xiewenyi2@huawei.com X-Gm-Message-State: xxQWLgPJlZcP9tBxWDbbenjex1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1629940884; bh=JLBg1/UbUYwZ/iPrEct43bfPQAT+kMpxt2yEUWilFTs=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=OLnpFp1faDLky8ng3QNNPUTHKx4uiBTyMSPx+t9ChPUyZkHeaUBut3Sj+UVW6YmPFws p00LuEk2MV0Sav03U5Sr5qAO30ch4CgvQzXQVv3p0K3htI580aOJ6S3YhBXWnJ3kCrShp eFYSUe/icrcBbd4UxDm0W3hNKaAOc5ELMPA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1629940885116100003 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As the if statement outside has confirmed that BlockData->Name =3D=3D NULL, so the if statement inside is always false. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie Reviewed-by: Dandan Bi --- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c b/MdeMod= ulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c index d492b769d51c..17a914208c6d 100644 --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c @@ -2871,9 +2871,6 @@ ParseIfrData ( // if ((BlockData->Name =3D=3D NULL) && ((BlockData->Offset + BlockDa= ta->Width) > VarStorageData->Size)) { Status =3D EFI_INVALID_PARAMETER; - if (BlockData->Name !=3D NULL) { - FreePool (BlockData->Name); - } FreePool (BlockData); goto Done; } --=20 2.20.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79816): https://edk2.groups.io/g/devel/message/79816 Mute This Topic: https://groups.io/mt/85151741/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-