From nobody Sat May 4 06:25:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+78348+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+78348+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1627545018; cv=none; d=zohomail.com; s=zohoarc; b=k7xnw3BCHYTNgWLFci5uuu57NEcznneVC9rYgXBnSpctlG96rq6hcpHZO7CnFmc24c9xS2GmfgyUoxXI1Tt4zq9eLSdYvyyG63U0OxMmGLe/eCxLT5jBgojdrSEko4v2PQ3rnqGePvOw1d++D5dAFY7KO4YSkDnrnc0efVZjo9o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627545018; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=kSaG6TViyqA6s3yGxF/13ukWCEzD59Ok7aiWMp+rgDM=; b=isrOME2G7hyD3fos7kocQuKORf8qGJjRdobk27sEs6VkGfkU3dscfJVMseeTFoNCD8VoR26QO3WS7AbzzeH7pJx+B3jPCtURyD+U8kwqicHKQ1wGNkzYvXk7E9jzraAGGPEYRCCZ5PwfFhDDmNrC6LBk6W8T6Falxb7ImyLtQvU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+78348+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1627545018001954.3656194089818; Thu, 29 Jul 2021 00:50:18 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id XrV9YY1788612xRfDZCEbLLL; Thu, 29 Jul 2021 00:50:17 -0700 X-Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mx.groups.io with SMTP id smtpd.web09.6587.1627545015816035413 for ; Thu, 29 Jul 2021 00:50:16 -0700 X-Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Gb2bd3v4Fz1CPCK; Thu, 29 Jul 2021 15:44:13 +0800 (CST) X-Received: from dggpemm000003.china.huawei.com (7.185.36.128) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 29 Jul 2021 15:50:10 +0800 X-Received: from HGH1000039998.huawei.com (10.184.68.188) by dggpemm000003.china.huawei.com (7.185.36.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 29 Jul 2021 15:50:09 +0800 From: "wenyi,xie via groups.io" To: , , CC: , , Jiewen Yao , Laszlo Ersek Subject: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/FvReportPei: remove redundant sizeof Date: Thu, 29 Jul 2021 15:45:28 +0800 Message-ID: <1627544728-82453-2-git-send-email-xiewenyi2@huawei.com> In-Reply-To: <1627544728-82453-1-git-send-email-xiewenyi2@huawei.com> References: <1627544728-82453-1-git-send-email-xiewenyi2@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.184.68.188] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm000003.china.huawei.com (7.185.36.128) X-CFilter-Loop: Reflected Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,xiewenyi2@huawei.com X-Gm-Message-State: cVKI5YjdlEC9GWO7If9koQhGx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1627545017; bh=3Twp66WT6+kZyvBvzHiE1cylSXO81y4oCyDOtI/+7mA=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=vvceZpu15XOEgxeg2v91zQUR4Xr4aSQKq8rjHfsj3j9mC1Z4WgvcGfuDiqmja4yohpB /cuWeia9K9iYXQJZcd3CRzG/u3t/maZUL5faFtVse0ufxYnVjfxXODc0F6x1Q6raZbg4h bjLc+xNCk9q+MRrycJalnGT/In4TYWRbao4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1627545019475100003 Content-Type: text/plain; charset="utf-8" REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3333 In function InstallPreHashFvPpi, when calculating the size of struct HASH_INFO=EF=BC=8Csizeof is used twice. This bug does not lead to buffer overflow, "sizeof (HASH_INFO)" is 4, whereas "sizeof (sizeof (HASH_INFO))" is 4 or 8. Cc: Jiewen Yao Cc: Jian J Wang Cc: Laszlo Ersek Signed-off-by: Wenyi Xie Reviewed-by: Laszlo Ersek Reviewed-by: Hao A Wu Reviewed-by: Jiewen Yao --- SecurityPkg/FvReportPei/FvReportPei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/FvReportPei/FvReportPei.c b/SecurityPkg/FvReportPe= i/FvReportPei.c index d709760ea3ce..e82413e090c0 100644 --- a/SecurityPkg/FvReportPei/FvReportPei.c +++ b/SecurityPkg/FvReportPei/FvReportPei.c @@ -67,7 +67,7 @@ InstallPreHashFvPpi ( HASH_INFO *HashInfo; =20 PpiSize =3D sizeof (EDKII_PEI_FIRMWARE_VOLUME_INFO_PREHASHED_FV_PPI) - + sizeof (sizeof (HASH_INFO)) + + sizeof (HASH_INFO) + HashSize; =20 PreHashedFvPpi =3D AllocatePool (PpiSize); --=20 2.20.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78348): https://edk2.groups.io/g/devel/message/78348 Mute This Topic: https://groups.io/mt/84523794/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-