From nobody Sun May 19 11:31:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75239+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75239+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1621322453; cv=none; d=zohomail.com; s=zohoarc; b=XOISxmyj1ODGwhWgXekFq7JxdUn5YWcjRPHIlSLjF9hIr3V7PzrO39DwEVFQsYVMvut2gloMBWXKtig9QhdzLsi7pVt6Tg4e4Vg+lrb1RgdJwq11jq9QIrNUX2zLTXqT6ITPNnGRKwDs6LdPlBA8477y3BaI3WoVZXIi3hPVRzQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621322453; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=7MMY8A98PWdwUkMLFJ9xwXMOvlKsSzYLYFC5IoHLc5k=; b=Kwgvl3mDW2njpSvdmtN8vjbGn2sbOxkBxNSlIEJZd/fMTzAWEhFhp7xRTPRQwSQ+fUhQzUDnQJDk2xmx5GqYJ5KhpH9LFScP+77U2gMX9eOeD69Ok8SogadBW9lSnaDAVB8aJ4nDErIr/FIWumimcTBjvbmN+fncNFVkJ66beDk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75239+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1621322453117671.7165639282639; Tue, 18 May 2021 00:20:53 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id qm7mYY1788612xcm2Wetzo0K; Tue, 18 May 2021 00:20:52 -0700 X-Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mx.groups.io with SMTP id smtpd.web09.5244.1621322446961723883 for ; Tue, 18 May 2021 00:20:47 -0700 X-Received: from dggems701-chm.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FknQY6Kdqz16QKr for ; Tue, 18 May 2021 15:17:57 +0800 (CST) X-Received: from dggpemm000003.china.huawei.com (7.185.36.128) by dggems701-chm.china.huawei.com (10.3.19.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 18 May 2021 15:20:42 +0800 X-Received: from HGH1000039998.huawei.com (10.184.68.188) by dggpemm000003.china.huawei.com (7.185.36.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 18 May 2021 15:20:42 +0800 From: "wenyi,xie via groups.io" To: , , , , CC: , Subject: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe: remove dead code Date: Tue, 18 May 2021 15:16:59 +0800 Message-ID: <1621322219-109579-2-git-send-email-xiewenyi2@huawei.com> In-Reply-To: <1621322219-109579-1-git-send-email-xiewenyi2@huawei.com> References: <1621322219-109579-1-git-send-email-xiewenyi2@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.184.68.188] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm000003.china.huawei.com (7.185.36.128) X-CFilter-Loop: Reflected Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,xiewenyi2@huawei.com X-Gm-Message-State: YG8NzRaSkVWYR4XnUCzDo5Dcx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1621322452; bh=pdB7E7YjmmOrAkfxZ3qCFeXUk5/6xSo0GW4oU964ZnE=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=iQorGsP6ls8mDS/6nv5exT21kSrdDq7Qw+vWxOvdtPpxs8RQrCytNh/UcOrVaFOQxtM nzZnwNuwuk8epwa28Z9KnYhrW9wjp2RBrnCumgHMabSjEHsKDUfdE+gkBocfv9A57WCdw lursUROK+0Ikx5hgTZS3FO9+E67uniC25+I= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Outer condition is 'BlockData->Name=3D=3DNULL' and inner condition is 'BlockData->Name!=3DNULL', Opposite 'if' condition leads to a dead code block. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie Reviewed-by: Dandan Bi Reviewed-by: Liming Gao --- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c b/MdeMod= ulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c index d492b769d51c..17a914208c6d 100644 --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c @@ -2871,9 +2871,6 @@ ParseIfrData ( // if ((BlockData->Name =3D=3D NULL) && ((BlockData->Offset + BlockDa= ta->Width) > VarStorageData->Size)) { Status =3D EFI_INVALID_PARAMETER; - if (BlockData->Name !=3D NULL) { - FreePool (BlockData->Name); - } FreePool (BlockData); goto Done; } --=20 2.20.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75239): https://edk2.groups.io/g/devel/message/75239 Mute This Topic: https://groups.io/mt/82906641/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-