From nobody Thu May 16 20:03:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+74074+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+74074+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1618364841; cv=none; d=zohomail.com; s=zohoarc; b=RfLl7q4fFHHEjh52inYYyBTFwhZLMMjuNXqDaMZkF//3tZ5rl48m9tTzpFmCo04dFFpX5K8pWaZVpvaXLSPJVZ4Dyr/u+LCSbx49Ox8YkOJtCqzXJBb3h9/ezNFrJIlAS1/Nw3PspzkJ8FCvZM/5ONSMG4LxTM5Ij7VH+eGRrFs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618364841; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=S8/ZdwCHS8/IZsoMNiLh0EDTPlqJpjGi8YEDHUB8of0=; b=l4xVcNxSAFAD2mapGE5AfFDxC/W3Vs+4qG3AVfcGtRLcs4uek6kG9jYKz+bfv4KQOp0SnuniuY7Jy62k9xSHt7I80WvyGbyOFfsjeCBMMegBZIhu728t16lEdPDWGr/sNjSaEFmCw1x6BwZoXm9iBb+Jsb6PqPK6xxyCuswuSnQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+74074+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1618364841046161.77269597425004; Tue, 13 Apr 2021 18:47:21 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ByfJYY1788612xuGxTQzkXtT; Tue, 13 Apr 2021 18:47:20 -0700 X-Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mx.groups.io with SMTP id smtpd.web12.7105.1618364839557979401 for ; Tue, 13 Apr 2021 18:47:20 -0700 X-Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FKlf46Rvrz18JHx; Wed, 14 Apr 2021 09:45:00 +0800 (CST) X-Received: from HGH1000039998.huawei.com (10.184.68.188) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.498.0; Wed, 14 Apr 2021 09:47:10 +0800 From: "wenyi,xie via groups.io" To: , , , CC: , Subject: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/FvReportPei: remove redundant sizeof Date: Wed, 14 Apr 2021 09:43:50 +0800 Message-ID: <1618364630-26124-2-git-send-email-xiewenyi2@huawei.com> In-Reply-To: <1618364630-26124-1-git-send-email-xiewenyi2@huawei.com> References: <1618364630-26124-1-git-send-email-xiewenyi2@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.184.68.188] X-CFilter-Loop: Reflected Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,xiewenyi2@huawei.com X-Gm-Message-State: l72hyjFk5ZTTH4A2wWlFum0ox1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1618364840; bh=IeZzQIpXP3S+uN29GM1epiVowi9kEPFKKbNyod4QvRw=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=Z5WrO/TjkwpcLHEeHlDW/22XWl6ESRLPB4MgWqqWX6aX5ex6OfNdXmzaAr5LWeZFqeW 4tqtn8UP67DPqd8BCd03Q3PMsip+cQXhMpT5aTRfcm6cDE4VPLw2/7aeje+fzBfNutDff 9w1gw3PrJyZDX78Ij8NAilPkwoRtkuT8tZU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3333 In function InstallPreHashFvPpi, when calculating the size of struct HASH_INFO=EF=BC=8Csizeof is used twice. This bug does not lead to buffer overflow, "sizeof (HASH_INFO)" is 4, whereas "sizeof (sizeof (HASH_INFO))" is 4 or 8. Cc: Jiewen Yao Cc: Jian J Wang Cc: Laszlo Ersek Signed-off-by: Wenyi Xie Reviewed-by: Laszlo Ersek Acked-by: Jiewen Yao Reviewed-by: Jian J Wang --- SecurityPkg/FvReportPei/FvReportPei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/FvReportPei/FvReportPei.c b/SecurityPkg/FvReportPe= i/FvReportPei.c index d709760ea3ce..e82413e090c0 100644 --- a/SecurityPkg/FvReportPei/FvReportPei.c +++ b/SecurityPkg/FvReportPei/FvReportPei.c @@ -67,7 +67,7 @@ InstallPreHashFvPpi ( HASH_INFO *HashInfo; =20 PpiSize =3D sizeof (EDKII_PEI_FIRMWARE_VOLUME_INFO_PREHASHED_FV_PPI) - + sizeof (sizeof (HASH_INFO)) + + sizeof (HASH_INFO) + HashSize; =20 PreHashedFvPpi =3D AllocatePool (PpiSize); --=20 2.20.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74074): https://edk2.groups.io/g/devel/message/74074 Mute This Topic: https://groups.io/mt/82081793/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-