From nobody Mon Feb 9 03:52:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68845+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68845+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1608014735; cv=none; d=zohomail.com; s=zohoarc; b=VNKeGS7QUlh6EYiWka9stOyPc9lz81DLrQwV1PB08u2fsOyQ1dxyT7Lk53bQbDFMSfuSIK9s/fPNXQ2DgBB8AxQz8aQebaOBL9BoetHCHnqpQ6O+0vQtxVPZ7G4BaKNcnJ1c80nr8GfFUh/dGMwQoXxxjW7aZgowwN07fc2fsxs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608014735; h=Content-Type:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=3BFOhnpo1OlomcMNin/gXAEmr97WhkO7qN1h0tgLp/Q=; b=ThOYijp+MCHx+SlykKZ+aJXG6z+sim6UlDaJuxilv9Q1qvnIKX8tAU+Z8baX82dTV/O9uME8CagwLdQDrSPXZXQKnAWo19Wu6q68E4pBYdvZXAeHeCupijbvAt+15b5Ux3x5G6nVfEMqLQo8iJItz2fnI9Rg1/W7fj1oQHdWiME= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68845+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608014735059376.02916513899766; Mon, 14 Dec 2020 22:45:35 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 9ZdaYY1788612xkHbCoqx5FL; Mon, 14 Dec 2020 22:45:34 -0800 X-Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mx.groups.io with SMTP id smtpd.web11.7505.1608014728323775031 for ; Mon, 14 Dec 2020 22:45:29 -0800 X-Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4Cw7zX0zTqzhsyq; Tue, 15 Dec 2020 14:44:56 +0800 (CST) X-Received: from HGH1000039998.huawei.com (10.184.68.188) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Tue, 15 Dec 2020 14:45:14 +0800 From: "wenyi,xie via groups.io" To: , , , CC: , Subject: [edk2-devel] [PATCH EDK2 v2 1/1] BaseTools/EfiRom: remove redundant checking of argc Date: Tue, 15 Dec 2020 14:43:30 +0800 Message-ID: <1608014610-110183-2-git-send-email-xiewenyi2@huawei.com> In-Reply-To: <1608014610-110183-1-git-send-email-xiewenyi2@huawei.com> References: <1608014610-110183-1-git-send-email-xiewenyi2@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.184.68.188] X-CFilter-Loop: Reflected Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,xiewenyi2@huawei.com X-Gm-Message-State: a4uAS2oDXtofXLJsezsGnp8cx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608014734; bh=A3g2+TPMq1feATD1TAfUtgdPZIEL8RkAqnC5flnmRPo=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=kpSjcGQpszfmRaIff9Vge9ubYNNMPWkMUr3Uviw1tBDk5dngG5QrAUgLzp4HpsOowR5 +Nt1Vn5a7/IkoBrzdBcQqe0bt7qTYq474/48pxZg60T0SEcNdbcvenKXKKixe/XfUv2Mh iwz7T54UgeOjwQHfot9mihAAam7Fts/PZDk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As the condition of while statement is argc > 0, so argc < 1 will always be false, it's redundant. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Wenyi Xie Reviewed-by: Bob Feng --- BaseTools/Source/C/EfiRom/EfiRom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/C/EfiRom/EfiRom.c b/BaseTools/Source/C/EfiRom= /EfiRom.c index a7e2839b0a84..2506f559d574 100644 --- a/BaseTools/Source/C/EfiRom/EfiRom.c +++ b/BaseTools/Source/C/EfiRom/EfiRom.c @@ -1014,7 +1014,7 @@ Returns: // Device IDs specified with -i // Make sure there's at least one more parameter // - if (Argc < 1) { + if (Argc =3D=3D 1) { Error (NULL, 0, 2000, "Invalid parameter", "Missing Device Id wi= th %s option!", OptionName); ReturnStatus =3D 1; goto Done; --=20 2.20.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68845): https://edk2.groups.io/g/devel/message/68845 Mute This Topic: https://groups.io/mt/78971355/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-