From nobody Sat Feb 7 06:55:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68843+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68843+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1608013966; cv=none; d=zohomail.com; s=zohoarc; b=NOG1+BtGdR/5VASXtPhfNI7NqWhl59R/qpAoJJwib4AwDYocgE3QiZ4ODp0nUq2YYdKkpTCu/e/25riUzeMikHJp1VUCa1tkTfHLC74Vf5+cdJeGq2P08XmHDFAFSoCp2ltiSR778wH3Jidt1/hUvjR7JMBeZoL8esMvpqx7K48= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608013966; h=Content-Type:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=wZ3wAL1fMYDG6D+Yn9FeDoipdxUd8cXC5SXrg0Pvw0I=; b=cotqvIkKbKQiGofPHY2TWrHO9YiiAb3u539uqjg2W/fNK+wNHPGNz53JZKozekV7Lxecqb5lFzP+73QSQZ7B6lkE8ui+UQ8zV5mqlnu+58WLZjpK7txJvZZJQAYp7dmGaA95JORGeJEomudxDYCFMXghu+nwD2771fcdH7d3I9k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68843+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608013966871722.7174217187812; Mon, 14 Dec 2020 22:32:46 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id qGlHYY1788612xDS3Y77696q; Mon, 14 Dec 2020 22:32:46 -0800 X-Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mx.groups.io with SMTP id smtpd.web08.7423.1608013964023829121 for ; Mon, 14 Dec 2020 22:32:44 -0800 X-Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Cw7hV10grzkr4P; Tue, 15 Dec 2020 14:31:54 +0800 (CST) X-Received: from HGH1000039998.huawei.com (10.184.68.188) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.498.0; Tue, 15 Dec 2020 14:32:31 +0800 From: "wenyi,xie via groups.io" To: , , , CC: , Subject: [edk2-devel] [PATCH EDK2 v2 1/1] BaseTools/GenFfs: Optimazing else if statement Date: Tue, 15 Dec 2020 14:30:46 +0800 Message-ID: <1608013846-109318-2-git-send-email-xiewenyi2@huawei.com> In-Reply-To: <1608013846-109318-1-git-send-email-xiewenyi2@huawei.com> References: <1608013846-109318-1-git-send-email-xiewenyi2@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.184.68.188] X-CFilter-Loop: Reflected Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,xiewenyi2@huawei.com X-Gm-Message-State: 2wbs2WTXcujEZrwwVtDLB8Hzx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608013966; bh=eQsbgJfrH62LN83z3K2QeWN2mp8y1A7HjhriDP92yjc=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=bmlTGAMgm0LcHDjHPbgTfSTvLwx02lYaUSSMVw8V0TeVCV0m7RFBzLaIS7UJbD6Bcht DYx4rhWxpdKT0/YDFgmfDuaHJbLsQOb3yjtwid/KkfacknruUYbzi7yxriTVCcQFHuE1K Z6zRtqy7S4AYZnJyduPK8oaLQ5LcUxXd5PI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When Alignment < 0x400 is false, the expression of Alignment >=3D 0x400 is always true. So extract the expression from the else if statement. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Wenyi Xie Reviewed-by: Bob Feng --- BaseTools/Source/C/GenFfs/GenFfs.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/BaseTools/Source/C/GenFfs/GenFfs.c b/BaseTools/Source/C/GenFfs= /GenFfs.c index fcb911f4fc34..949025c33325 100644 --- a/BaseTools/Source/C/GenFfs/GenFfs.c +++ b/BaseTools/Source/C/GenFfs/GenFfs.c @@ -821,12 +821,11 @@ Returns: if (Alignment < 0x400){ sprintf (AlignmentBuffer, "%d", Alignment); } - else if (Alignment >=3D 0x400) { - if (Alignment >=3D 0x100000) { - sprintf (AlignmentBuffer, "%dM", Alignment/0x100000); - } else { - sprintf (AlignmentBuffer, "%dK", Alignment/0x400); - } + else if (Alignment >=3D 0x100000) { + sprintf (AlignmentBuffer, "%dM", Alignment/0x100000); + } + else { + sprintf (AlignmentBuffer, "%dK", Alignment/0x400); } Status =3D StringtoAlignment (AlignmentBuffer, &(InputFileAlign[= InputFileNum])); } --=20 2.20.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68843): https://edk2.groups.io/g/devel/message/68843 Mute This Topic: https://groups.io/mt/78971296/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-