From nobody Sun Feb 8 23:58:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68756+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68756+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1607915612; cv=none; d=zohomail.com; s=zohoarc; b=fnyShVjuW/WuABu8qyfM+nplWAWCNqWdWi+FF7xsUylY7Jn1AYPa1TJK0on7r+no5e2x944kKlrIFGLkIhDzuEeQIwviSsniQHP8y4TdrVnlP6k+MZ/eE9OQgoz9CqnFXYb+Up4oVO8gFV1tX7H3zv0XinOBTORLjlm7lx/DPF8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607915612; h=Content-Type:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=hGb2L1WT09LnTLAuLqLSebJQkew3xPee6SqiRJcDCHg=; b=MTzOT/7FQQvP2d57mr5nIqz49HaGHfF5vPS1FlcoF0F2tfK/OsusuI5LUiW8qKxOKcvLlrY6nr0z+vrfTpLbumlBb0oofJfoEQ/jtwj1Myfz0vp7/X6lG1Z/vvA5Nb3T1ZrBi/azBscKUCpB1hmThyghHIuTad+DnnemABtA1Jk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68756+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607915612048828.17012643408; Sun, 13 Dec 2020 19:13:32 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id VFPAYY1788612x1oAzrt56ko; Sun, 13 Dec 2020 19:13:31 -0800 X-Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mx.groups.io with SMTP id smtpd.web08.29243.1607915605269553867 for ; Sun, 13 Dec 2020 19:13:25 -0800 X-Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CvRK036KHzM4Xw; Mon, 14 Dec 2020 11:12:36 +0800 (CST) X-Received: from HGH1000039998.huawei.com (10.184.68.188) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.498.0; Mon, 14 Dec 2020 11:13:13 +0800 From: "wenyi,xie via groups.io" To: , , , CC: , Subject: [edk2-devel] [PATCH EDK2 v1 1/1] BaseTools/GenFfs: Optimazing else if statement Date: Mon, 14 Dec 2020 11:11:29 +0800 Message-ID: <1607915489-70490-2-git-send-email-xiewenyi2@huawei.com> In-Reply-To: <1607915489-70490-1-git-send-email-xiewenyi2@huawei.com> References: <1607915489-70490-1-git-send-email-xiewenyi2@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.184.68.188] X-CFilter-Loop: Reflected Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,xiewenyi2@huawei.com X-Gm-Message-State: UOKiEMRxXQkH6kTKkpWYYo6nx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607915611; bh=+vGZJwUxv1yBZyj7JQM9a7nBFEqZ/ujPqdb5eJiLi9c=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=V+2qy12Ax/pNUcZbPic2LRCDe2o9WcbHnEM7a5sAHRmZsFa/vmCgc7Zh3OPRG+22Tm/ +L8YN1k0pZ+6qK7r/YYmUapAkNOU6UWQ6038X3H9It0y2CNsp7bbguNC4T0mR41l8R+K2 8YZu958VbQcsT4racAvJiQkZpBZusx6eod8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When Alignment < 0x400 is false, the expression of Alignment >=3D 0x400 is always true. So extract the expression from the else if statement. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Wenyi Xie --- BaseTools/Source/C/GenFfs/GenFfs.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/BaseTools/Source/C/GenFfs/GenFfs.c b/BaseTools/Source/C/GenFfs= /GenFfs.c index fcb911f4fc34..70538b138f33 100644 --- a/BaseTools/Source/C/GenFfs/GenFfs.c +++ b/BaseTools/Source/C/GenFfs/GenFfs.c @@ -821,12 +821,11 @@ Returns: if (Alignment < 0x400){ sprintf (AlignmentBuffer, "%d", Alignment); } - else if (Alignment >=3D 0x400) { - if (Alignment >=3D 0x100000) { + else if (Alignment >=3D 0x100000) { sprintf (AlignmentBuffer, "%dM", Alignment/0x100000); - } else { + } + else { sprintf (AlignmentBuffer, "%dK", Alignment/0x400); - } } Status =3D StringtoAlignment (AlignmentBuffer, &(InputFileAlign[= InputFileNum])); } --=20 2.20.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68756): https://edk2.groups.io/g/devel/message/68756 Mute This Topic: https://groups.io/mt/78943291/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-