From nobody Sat May 18 07:09:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68683+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68683+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1607654027; cv=none; d=zohomail.com; s=zohoarc; b=CnUB22H5wf+KdUWQmQWLWF310AvsjJoZhJsg2WCikQZUzsAD2CN2xhvfKC7ss9Hv/n21rjEXhUCX3CIpX5PpIGz3A3ehe7OP6xOy3FMIHjXFTt4l4njNEvSpN6IKi9hsd/QhCsc4o4oBsjqWWwifRShoODM1Rpks4YjMxXoN0zQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607654027; h=Content-Type:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=5DgVIdTpZnHoRVX8dsBcdVz/R1VDAL2H5nmQdoClQf8=; b=V/timODJ33/HCpxvKLlhp36QDVYIPN9C9yZFFd2qBElK6zjnWa3gHFu3oLoG6914gsrg0pQe7TkAVzkylFHxJ96GC/o5IbBi6tX+sGGAdwGSNpCFbqNbLJxyU+eIE2NrzpSgUPIe0LqELpGkjtYs3OPoZUoAP/r/wbpHulEzVP4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68683+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607654027871668.5301648578387; Thu, 10 Dec 2020 18:33:47 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id eZIsYY1788612x8karoQjLcz; Thu, 10 Dec 2020 18:33:47 -0800 X-Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mx.groups.io with SMTP id smtpd.web11.1126.1607654018469637684 for ; Thu, 10 Dec 2020 18:33:42 -0800 X-Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CsZZj30hYzhXfC; Fri, 11 Dec 2020 10:33:01 +0800 (CST) X-Received: from HGH1000039998.huawei.com (10.184.68.188) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.487.0; Fri, 11 Dec 2020 10:33:25 +0800 From: "wenyi,xie via groups.io" To: , , , CC: , Subject: [edk2-devel] [PATCH EDK2 v1 1/1] BaseTools/EfiRom: remove redundant checking of argc Date: Fri, 11 Dec 2020 10:31:43 +0800 Message-ID: <1607653903-125927-2-git-send-email-xiewenyi2@huawei.com> In-Reply-To: <1607653903-125927-1-git-send-email-xiewenyi2@huawei.com> References: <1607653903-125927-1-git-send-email-xiewenyi2@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.184.68.188] X-CFilter-Loop: Reflected Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,xiewenyi2@huawei.com X-Gm-Message-State: D3Pid3m6K3yWJuaWTyUpyroxx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607654027; bh=36Em0LEvcReVUSLtfhQ0CYzhs8l8iSXYU8jwN5sKjD4=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=WjBW0sMXUz9MBWIovr/zSqKkmIYggux7gI1pE7RNpr9eal51SG2YUb08xYc4zcWPt64 gbn65f5U/arlYoNNFLpSDjt/z1eUce7Monj4h/8Akz6FMngBYdRlIvdNu2hXuI1PRlAyW /ps24uc9sL32t9OGEx4ZPrBht8Xhj+hwC3Y= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As the condition of while statement is argc > 0, so argc < 1 will always be false, it's redundant. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Wenyi Xie --- BaseTools/Source/C/EfiRom/EfiRom.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/BaseTools/Source/C/EfiRom/EfiRom.c b/BaseTools/Source/C/EfiRom= /EfiRom.c index a7e2839b0a84..147eb464b01e 100644 --- a/BaseTools/Source/C/EfiRom/EfiRom.c +++ b/BaseTools/Source/C/EfiRom/EfiRom.c @@ -1010,16 +1010,6 @@ Returns: =20 OptionName =3D Argv[0]; =20 - // - // Device IDs specified with -i - // Make sure there's at least one more parameter - // - if (Argc < 1) { - Error (NULL, 0, 2000, "Invalid parameter", "Missing Device Id wi= th %s option!", OptionName); - ReturnStatus =3D 1; - goto Done; - } - // // Process until another dash-argument parameter or the end of the= list // --=20 2.20.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68683): https://edk2.groups.io/g/devel/message/68683 Mute This Topic: https://groups.io/mt/78871121/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-