From nobody Mon Apr 29 17:09:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67697+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67697+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1605778138; cv=none; d=zohomail.com; s=zohoarc; b=WHugsmtGA+BCHo+aIEg2CyosYmuwVFlc0c1oEc8+7m+HaWKfCC0iMvmzg9mjxpIOhnMQH5+6T7O//1fLYID5j0OZzrJkpdj3/m3SrQrQy79ElWZF8mUrfFrhyVbYjM0r6iTfOm2iNa+FYrRbkfbpLjsWLE3UGQvkkcmuiQZX194= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605778138; h=Content-Type:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=fhN6ZY6BVZVLAAgVj+sC3FXnqZxkxPHhUuc63lYpG08=; b=kp8IMUH+D05BaE1Vk+t8njhEfvQEeajb8HOCMULuCe01Gp2XdhtjIl1J1KLfb5wS/fz7TmQzPvaASDzHA8r3IDXZjMPNlatMfir8BLwzEbZPC5qveFreXw7v5ZPBXZ/Qd93/oTwaoP1qT10AhQvs5jLdgi+8KnmttPx4vyndBis= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67697+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1605778138119401.3925076076796; Thu, 19 Nov 2020 01:28:58 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 7Uc0YY1788612xZrvsBewwSh; Thu, 19 Nov 2020 01:28:56 -0800 X-Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mx.groups.io with SMTP id smtpd.web09.6823.1605778135201762711 for ; Thu, 19 Nov 2020 01:28:55 -0800 X-Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CcDrP1Vwsz15KVX; Thu, 19 Nov 2020 17:28:37 +0800 (CST) X-Received: from HGH1000039998.huawei.com (10.184.68.188) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Thu, 19 Nov 2020 17:28:44 +0800 From: "wenyi,xie via groups.io" To: , , , CC: , Subject: [edk2-devel] [PATCH EDK2 v1 1/1] MdePkg/DxeHstiLib: avoid Hsti offset overflow Date: Thu, 19 Nov 2020 17:27:18 +0800 Message-ID: <1605778038-46210-2-git-send-email-xiewenyi2@huawei.com> In-Reply-To: <1605778038-46210-1-git-send-email-xiewenyi2@huawei.com> References: <1605778038-46210-1-git-send-email-xiewenyi2@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.184.68.188] X-CFilter-Loop: Reflected Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,xiewenyi2@huawei.com X-Gm-Message-State: RI3nfhMfYjjfdHjnS8EPaRkMx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1605778136; bh=jE57eUt7tAWDAqRx5ZV1+NQ12lw/IExr9hM21/3YZwE=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=FoaFcN2suwDDjjWWJaRqzhY1EpSn4zWSLd8FqGslRuCSLx8D7M1pvl3XJe5ScLsd/R5 2g9/6YJHHsWx7IOM6t6SLLDyKK7x6P6EVyTvRTSCL/scFNPV/aBklRq+fxkxlgQk2SZsu wmSWhN8nrBZsvYWVfmmx8N2bbDWNVsiMqGw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" add conditional operator to check whether the HstiSize is larger than sizeof(CHAR16). If not, setting offset to 0 to avoid overflow. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Wenyi Xie --- MdePkg/Library/DxeHstiLib/HstiDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Library/DxeHstiLib/HstiDxe.c b/MdePkg/Library/DxeHstiLi= b/HstiDxe.c index 4e1c67616b01..f04e6f13b7e5 100644 --- a/MdePkg/Library/DxeHstiLib/HstiDxe.c +++ b/MdePkg/Library/DxeHstiLib/HstiDxe.c @@ -519,7 +519,7 @@ InternalHstiRecordErrorString ( } =20 if (Append) { - Offset =3D HstiSize - sizeof(CHAR16); + Offset =3D (HstiSize >=3D sizeof(CHAR16)) ? (HstiSize - sizeof(CHAR16)= ) : 0; } else { Offset =3D sizeof(ADAPTER_INFO_PLATFORM_SECURITY) + Hsti->SecurityFeat= uresSize * 3; } --=20 2.20.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67697): https://edk2.groups.io/g/devel/message/67697 Mute This Topic: https://groups.io/mt/78361269/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-