From nobody Tue Feb 10 01:30:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+60262+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+60262+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=oss.nxp.com Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 159048666015358.504935125886846; Tue, 26 May 2020 02:51:00 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id p1JpYY1788612xmSKyZoSu3l; Tue, 26 May 2020 02:50:59 -0700 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.54]) by mx.groups.io with SMTP id smtpd.web11.46894.1590482313553485380 for ; Tue, 26 May 2020 01:38:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XSzSeDiw74MnnyrHWEa5BzT8LbpYd7Rs/2tVdjpNM/IBzLlll5b060EMKSiCQEzMt9qNxrMOWu96pQYjbIZ+PIbtdxl3QxfC67hPFjRuDme0MDlIfqg2sv6uRu8FFEsgaBDaELc7H05hQAr9wxoSzWKmVNiq0OijRvz/OATq8Ffe+wdFTt/Y5YNmcggispRQxU1xaTRdABqOY8rN6I89AZdBWYUtn/ckvyPY+t81XIgJAHt0FVyTyUS3SgksSCCFAm653dSz+SoYUfNiLJW1sLMqk1PDlYF9uBW6mw73s88e0feZWvGUaWvVcf3xlZkd+G3RsdbkSu2tS+aBPTF2Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JHiwgXp4azoWXt+uABXuXBFNEbQC30+GsSDiD5vrRTQ=; b=aea9FgQThWZ6WRy7a1MJ6mcYc6z8Gq7qRzTY91SsAPelSgL+lQoyz6qU0O0nlF5kxNDgzqigndKzRpzYh1ft/5aZQiCO8C3WnHAQHAdJzq9SP7sZq8T/13wPFelirq7/StQNXYPGKlAM+QLvTW0GlJwXZPjZctZAxKEUh64eEOcAYany2/XPhGT4Ssyh7oeulTmBGkW0N1BMs7+8z3QigYoJRCHXARwpm0udQlsIJjYJDRHIjIrJy/5+mDSTU88MxMhxei2BrByJaKMtU+MV4fixH2VfQhY3W2BuhToHMryhhnWbJ3hxS8kjkA2a22MsvieNm+XFTLnVo0Sd2tNZMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none X-Received: from VE1PR04MB6702.eurprd04.prod.outlook.com (2603:10a6:803:123::13) by VE1PR04MB6671.eurprd04.prod.outlook.com (2603:10a6:803:11f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.24; Tue, 26 May 2020 08:38:30 +0000 X-Received: from VE1PR04MB6702.eurprd04.prod.outlook.com ([fe80::81c4:97a6:7592:f225]) by VE1PR04MB6702.eurprd04.prod.outlook.com ([fe80::81c4:97a6:7592:f225%7]) with mapi id 15.20.3021.029; Tue, 26 May 2020 08:38:30 +0000 From: Wasim Khan To: devel@edk2.groups.io, meenakshi.aggarwal@nxp.com, vabhav.sharma@nxp.com, V.Sethi@nxp.com, ard.biesheuvel@arm.com, leif@nuviainc.com, jon@solid-run.com CC: Wasim Khan Subject: [edk2-devel] [PATCH edk2-platforms v2 06/16] Silicon/NXP: PciHostBridgeLib: add Workaround for A-011451 Date: Tue, 26 May 2020 14:07:11 +0530 Message-ID: <1590482241-13132-7-git-send-email-wasim.khan@oss.nxp.com> In-Reply-To: <1590482241-13132-1-git-send-email-wasim.khan@oss.nxp.com> References: <1590482241-13132-1-git-send-email-wasim.khan@oss.nxp.com> X-ClientProxiedBy: BM1PR0101CA0015.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::25) To VE1PR04MB6702.eurprd04.prod.outlook.com (2603:10a6:803:123::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from wasimk-VirtualBox.nxp.com (171.79.147.152) by BM1PR0101CA0015.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3021.23 via Frontend Transport; Tue, 26 May 2020 08:38:26 +0000 X-Originating-IP: [171.79.147.152] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2058436d-5a0d-4a82-7119-08d801502abd X-MS-TrafficTypeDiagnostic: VE1PR04MB6671: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: FG9wBTYaKvbK6JH6YO5Q8dhQtYiisIF+XwgmP0tNNhm4YxbCq8FIlbx2x4ePajVxuL8tnfok2IPu6cZjk0tPB8VtqqoAMm3Ha54fKgLAY1wKF6ktl03hg+H+3tPx/ENL6bySqv6gOO6zADaYQAeazeDYVCy+0XryXGgbrMq1T/Pzm6tGxTyBuLRHEShy9M/wPotW41gc0iB+XI4LGsHwNsQUhGgaT0XqpyE3957Ad0/HDUcXa8ZNwpAlXQcTuzIfzVzjsbL0SJCNpoymDR+dnjhMLB5CD1ptEpXbM7xCA0FWVTtpO5q9FkjYaa+KeB2Dw3cp0xXmcmq18xXcO6JTzg== X-MS-Exchange-AntiSpam-MessageData: OZEbO5vn4lC94MuG0v85gpM/wgu3Pu+CZf+4hWX8tts4kDzC3zXW1JlNN941U68ai/a4ZBNgrek2TlmbidBVfxnuoRhSpsx3ivsq/M3c6esIvt0cSkrYPtlEVotFzexaezOUPDxkr6J7mLQhyBLip/3cKCsYg/qnmWwpjXFbZ3MqI/Jhjl4nw0YMUagMC9X+8/nf0VWpqVuA0A160Haz5YwDGVr+LJbyh0FsPwiHjsH9iY3IiJvU+VwvjS3TOSc0ORHegPQ5C85l9kM+4KdHnkWxdDKrgEbCKh/8ojiWPksRNtwqT05LKqp5SFVEgYOKx6T5H09VogWL9iUMv/9tIAz70NX3mZ//pUef40LECvMca9mnjRYSE2d0IQa5X89gUg5vTAHT/BIqNTPb5ouEltvgfSmkflOB7mmUxgJZeyEbGfmo2+BJXffl+Awz6QiX4/svqGT73sa2myk80uRis+4DJ2O5iLCKdkPvOfZda1w= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2058436d-5a0d-4a82-7119-08d801502abd X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2020 08:38:30.3952 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zJbaDj0wiesPPR5wgT0jmgMnkh3V6GLoB0elbK1huzuMKz6VOeyz/nKDXAhBnkOBng31FifZ1sX8hMOmTw2ZXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6671 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,wasim.khan@oss.nxp.com X-Gm-Message-State: mxFkbcxf1E8MRukofncxoIHqx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1590486659; bh=PTDH9pxB48KA9o//0g3FuOPrk/gaVHHZ8cD0ntuK9UA=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=YVqLGqScsICxYv1nGLSu6KQUNMValgLDXFNqBX8gHK1TSKnPW3WaEqMQYDYTzEAjMj3 OQnUFWPIp56hrYGmkkXUZULZxMlkvA0pp4gGmsE5xCin0lJo9Dh/2wBQ11rGeHzDSC9Ep +VLZ0fX0pDyvUONcbi0d+K6k5Zk3z1zdQMI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Wasim Khan When PCIe Layerscape Gen4 controller is sending multiple split completions and ACK latency expires indicating that ACK should be send at priority. But because of large number of split completions and FC update DLLP,the controller does not give priority to ACK transmission. This results into ACK latency timer timeout error at the link partner and the pending TLPs are replayed by the link partner again. Workaround: Reduce the ACK latency timeout value. Co-authored-by: Vabhav Sharma Co-authored-by: Wasim Khan Signed-off-by: Wasim Khan --- Notes: V2: - Removed Signed-off and added Co-authored-by for co-author Silicon/NXP/Include/Pcie.h | 4 ++++ Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/Silicon/NXP/Include/Pcie.h b/Silicon/NXP/Include/Pcie.h index b7d46f3a3bd2..210e4c3cf5e7 100755 --- a/Silicon/NXP/Include/Pcie.h +++ b/Silicon/NXP/Include/Pcie.h @@ -202,4 +202,8 @@ STATIC inline VOID PciLsGen4Write32 ( MmioWrite32 (Dbi + OFFSET_TO_PAGE_ADDR (Offset), Value); } } + +#define GPEX_ACK_REPLAY_TO 0x438 +#define ACK_LAT_TO_VAL_SHIFT 0 +#define ACK_LAT_TO_VAL_MASK 0x1fff #endif diff --git a/Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c b/Sili= con/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c index 8e39fb25f83e..339a3d9bffa6 100644 --- a/Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c +++ b/Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c @@ -534,6 +534,12 @@ PcieSetupCntrl ( if (PCI_LS_GEN4_CTRL) { // PCIe LsGen4 Controller Setup =20 + // Workaround for A-011451 + Val =3D PciLsGen4Read32 ((UINTN)Pcie, GPEX_ACK_REPLAY_TO); + Val &=3D ~(ACK_LAT_TO_VAL_MASK << ACK_LAT_TO_VAL_SHIFT); + Val |=3D (4 << ACK_LAT_TO_VAL_SHIFT); + PciLsGen4Write32 ((UINTN)Pcie, GPEX_ACK_REPLAY_TO, Val); + //Fix Class Code Val =3D PciLsGen4Read32 ((UINTN)Pcie, GPEX_CLASSCODE); Val &=3D ~(GPEX_CLASSCODE_MASK << GPEX_CLASSCODE_SHIFT); --=20 2.7.4 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60262): https://edk2.groups.io/g/devel/message/60262 Mute This Topic: https://groups.io/mt/74474419/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-