.../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h | 2 ++ 1 file changed, 2 insertions(+)
ACPI memory mapped configuration space access (MCFG) table requires
defination of EFI_ACPI_DESCRIPTION_HEADER.
Signed-off-by: Wasim Khan <wasim.khan@nxp.com>
---
Changes in v2: Corrected typo in subject
.../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h
index 3356ec9..8a4933d 100644
--- a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h
+++ b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h
@@ -10,6 +10,8 @@
#ifndef _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
#define _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
+#include <IndustryStandard/Acpi.h>
+
//
// Ensure proper structure formats
//
--
2.7.4
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#57601): https://edk2.groups.io/g/devel/message/57601
Mute This Topic: https://groups.io/mt/73144786/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wasim > Khan > Sent: Monday, April 20, 2020 3:48 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming > <liming.gao@intel.com>; v.sethi@nxp.com; Wasim Khan > <wasim.khan@nxp.com> > Subject: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file > > ACPI memory mapped configuration space access (MCFG) table requires > defination of EFI_ACPI_DESCRIPTION_HEADER. > > Signed-off-by: Wasim Khan <wasim.khan@nxp.com> > --- > Changes in v2: Corrected typo in subject > > .../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h > | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git > a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceA > ccessTable.h > b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceA > ccessTable.h > index 3356ec9..8a4933d 100644 > --- > a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceA > ccessTable.h > +++ > b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceA > ccessTable.h > @@ -10,6 +10,8 @@ > #ifndef _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_ > #define _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_ > > +#include <IndustryStandard/Acpi.h> > + > // > // Ensure proper structure formats > // > -- > 2.7.4 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60476): https://edk2.groups.io/g/devel/message/60476 Mute This Topic: https://groups.io/mt/73144786/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 4/20/20 9:48 AM, Wasim Khan wrote: > ACPI memory mapped configuration space access (MCFG) table requires > defination of EFI_ACPI_DESCRIPTION_HEADER. What about: - DynamicTablesPkg/Include/Library/TableHelperLib.h - DynamicTablesPkg/Include/StandardNameSpaceObjects.h - EmbeddedPkg/Include/Library/AcpiLib.h > > Signed-off-by: Wasim Khan <wasim.khan@nxp.com> > --- > Changes in v2: Corrected typo in subject > > .../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h > index 3356ec9..8a4933d 100644 > --- a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h > +++ b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h > @@ -10,6 +10,8 @@ > #ifndef _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_ > #define _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_ > > +#include <IndustryStandard/Acpi.h> > + > // > // Ensure proper structure formats > // > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60489): https://edk2.groups.io/g/devel/message/60489 Mute This Topic: https://groups.io/mt/73144786/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
> -----Original Message----- > From: Philippe Mathieu-Daudé <philmd@redhat.com> > Sent: Monday, June 1, 2020 2:17 PM > To: devel@edk2.groups.io; Wasim Khan <wasim.khan@nxp.com> > Cc: michael.d.kinney@intel.com; liming.gao@intel.com; Varun Sethi > <V.Sethi@nxp.com> > Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file > > On 4/20/20 9:48 AM, Wasim Khan wrote: > > ACPI memory mapped configuration space access (MCFG) table requires > > defination of EFI_ACPI_DESCRIPTION_HEADER. > > What about: > > - DynamicTablesPkg/Include/Library/TableHelperLib.h > - DynamicTablesPkg/Include/StandardNameSpaceObjects.h > - EmbeddedPkg/Include/Library/AcpiLib.h EmbeddedPkg/Include/Library/AcpiLib.h => Acpi10.h is included in this file. For other two, Acpi.h /Acpi10.h has been included in the files where above header file are used. > > > > > Signed-off-by: Wasim Khan <wasim.khan@nxp.com> > > --- > > Changes in v2: Corrected typo in subject > > > > .../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h | > 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git > > > a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess > > Table.h > > > b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess > > Table.h > > index 3356ec9..8a4933d 100644 > > --- > > > a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess > > Table.h > > +++ > b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAc > > +++ cessTable.h > > @@ -10,6 +10,8 @@ > > #ifndef _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_ > > #define _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_ > > > > +#include <IndustryStandard/Acpi.h> > > + > > // > > // Ensure proper structure formats > > // > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60502): https://edk2.groups.io/g/devel/message/60502 Mute This Topic: https://groups.io/mt/73144786/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 6/1/20 1:16 PM, Wasim Khan wrote: > > >> -----Original Message----- >> From: Philippe Mathieu-Daudé <philmd@redhat.com> >> Sent: Monday, June 1, 2020 2:17 PM >> To: devel@edk2.groups.io; Wasim Khan <wasim.khan@nxp.com> >> Cc: michael.d.kinney@intel.com; liming.gao@intel.com; Varun Sethi >> <V.Sethi@nxp.com> >> Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file >> >> On 4/20/20 9:48 AM, Wasim Khan wrote: >>> ACPI memory mapped configuration space access (MCFG) table requires >>> defination of EFI_ACPI_DESCRIPTION_HEADER. >> >> What about: >> >> - DynamicTablesPkg/Include/Library/TableHelperLib.h >> - DynamicTablesPkg/Include/StandardNameSpaceObjects.h >> - EmbeddedPkg/Include/Library/AcpiLib.h > > EmbeddedPkg/Include/Library/AcpiLib.h => Acpi10.h is included in this file. > For other two, Acpi.h /Acpi10.h has been included in the files where above header file are used. OK, thanks Wasim. Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com> > >> >>> >>> Signed-off-by: Wasim Khan <wasim.khan@nxp.com> >>> --- >>> Changes in v2: Corrected typo in subject >>> >>> .../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h | >> 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git >>> >> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess >>> Table.h >>> >> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess >>> Table.h >>> index 3356ec9..8a4933d 100644 >>> --- >>> >> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess >>> Table.h >>> +++ >> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAc >>> +++ cessTable.h >>> @@ -10,6 +10,8 @@ >>> #ifndef _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_ >>> #define _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_ >>> >>> +#include <IndustryStandard/Acpi.h> >>> + >>> // >>> // Ensure proper structure formats >>> // >>> > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60503): https://edk2.groups.io/g/devel/message/60503 Mute This Topic: https://groups.io/mt/73144786/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Liming Gao <liming.gao@intel.com> -----Original Message----- From: Philippe Mathieu-Daudé <philmd@redhat.com> Sent: 2020年6月1日 19:18 To: Wasim Khan <wasim.khan@nxp.com>; devel@edk2.groups.io Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Varun Sethi <V.Sethi@nxp.com> Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file On 6/1/20 1:16 PM, Wasim Khan wrote: > > >> -----Original Message----- >> From: Philippe Mathieu-Daudé <philmd@redhat.com> >> Sent: Monday, June 1, 2020 2:17 PM >> To: devel@edk2.groups.io; Wasim Khan <wasim.khan@nxp.com> >> Cc: michael.d.kinney@intel.com; liming.gao@intel.com; Varun Sethi >> <V.Sethi@nxp.com> >> Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file >> >> On 4/20/20 9:48 AM, Wasim Khan wrote: >>> ACPI memory mapped configuration space access (MCFG) table requires >>> defination of EFI_ACPI_DESCRIPTION_HEADER. >> >> What about: >> >> - DynamicTablesPkg/Include/Library/TableHelperLib.h >> - DynamicTablesPkg/Include/StandardNameSpaceObjects.h >> - EmbeddedPkg/Include/Library/AcpiLib.h > > EmbeddedPkg/Include/Library/AcpiLib.h => Acpi10.h is included in this file. > For other two, Acpi.h /Acpi10.h has been included in the files where above header file are used. OK, thanks Wasim. Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com> > >> >>> >>> Signed-off-by: Wasim Khan <wasim.khan@nxp.com> >>> --- >>> Changes in v2: Corrected typo in subject >>> >>> .../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h | >> 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git >>> >> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAcces >> s >>> Table.h >>> >> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAcces >> s >>> Table.h >>> index 3356ec9..8a4933d 100644 >>> --- >>> >> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAcces >> s >>> Table.h >>> +++ >> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAc >>> +++ cessTable.h >>> @@ -10,6 +10,8 @@ >>> #ifndef _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_ >>> #define _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_ >>> >>> +#include <IndustryStandard/Acpi.h> >>> + >>> // >>> // Ensure proper structure formats >>> // >>> > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61514): https://edk2.groups.io/g/devel/message/61514 Mute This Topic: https://groups.io/mt/73144786/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.