[edk2-devel] [edk2-platforms: PATCH] Marvell/Drivers: XenonDxe: Explicitly disable HS400

Marcin Wojtas posted 1 patch 4 years, 9 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h         | 1 +
Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c | 5 +++--
2 files changed, 4 insertions(+), 2 deletions(-)
[edk2-devel] [edk2-platforms: PATCH] Marvell/Drivers: XenonDxe: Explicitly disable HS400
Posted by Marcin Wojtas 4 years, 9 months ago
Ensure that in case of SlowMode or 3.3V operation,
also the HS400 capability will be disabled in the
SdMmc driver.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
 Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h         | 1 +
 Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h
index 8bf1835..2d7c7f0 100644
--- a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h
+++ b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h
@@ -82,6 +82,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #define SDHC_CAP_SDR50                BIT32
 #define SDHC_CAP_SDR104               BIT33
 #define SDHC_CAP_DDR50                BIT34
+#define SDHC_CAP_HS400                BIT63
 #define SDHC_MAX_CURRENT_CAP          0x0048
 #define SDHC_FORCE_EVT_AUTO_CMD       0x0050
 #define SDHC_FORCE_EVT_ERR_INT        0x0052
diff --git a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c
index 7a9266e..55ebcf8 100644
--- a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c
+++ b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c
@@ -357,7 +357,8 @@ XenonSdMmcCapability (
     Capability &= ~(UINT64)(SDHC_CAP_VOLTAGE_33 | SDHC_CAP_VOLTAGE_30);
   } else {
     Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50 |
-                            SDHC_CAP_SDR50 | SDHC_CAP_VOLTAGE_18);
+                            SDHC_CAP_SDR50 | SDHC_CAP_HS400 |
+                            SDHC_CAP_VOLTAGE_18);
   }
 
   if (!SdMmcDesc.Xenon8BitBusEnabled) {
@@ -365,7 +366,7 @@ XenonSdMmcCapability (
   }
 
   if (SdMmcDesc.XenonSlowModeEnabled) {
-    Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50);
+    Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50 | SDHC_CAP_HS400);
   }
 
   Capability &= ~(UINT64)(SDHC_CAP_SLOT_TYPE_MASK);
-- 
2.7.4


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42871): https://edk2.groups.io/g/devel/message/42871
Mute This Topic: https://groups.io/mt/32212561/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH] Marvell/Drivers: XenonDxe: Explicitly disable HS400
Posted by Leif Lindholm 4 years, 9 months ago
On Wed, Jun 26, 2019 at 09:04:14AM +0200, Marcin Wojtas wrote:
> Ensure that in case of SlowMode or 3.3V operation,
> also the HS400 capability will be disabled in the
> SdMmc driver.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1

Well done on keeping this tag. But I'm thinking we need to do that
relicensing sooner rather than later, and drop the tag.

However, can you clarify what problem this solves?

/
    Leif

> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
>  Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h         | 1 +
>  Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c | 5 +++--
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h
> index 8bf1835..2d7c7f0 100644
> --- a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h
> +++ b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h
> @@ -82,6 +82,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>  #define SDHC_CAP_SDR50                BIT32
>  #define SDHC_CAP_SDR104               BIT33
>  #define SDHC_CAP_DDR50                BIT34
> +#define SDHC_CAP_HS400                BIT63
>  #define SDHC_MAX_CURRENT_CAP          0x0048
>  #define SDHC_FORCE_EVT_AUTO_CMD       0x0050
>  #define SDHC_FORCE_EVT_ERR_INT        0x0052
> diff --git a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c
> index 7a9266e..55ebcf8 100644
> --- a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c
> +++ b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c
> @@ -357,7 +357,8 @@ XenonSdMmcCapability (
>      Capability &= ~(UINT64)(SDHC_CAP_VOLTAGE_33 | SDHC_CAP_VOLTAGE_30);
>    } else {
>      Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50 |
> -                            SDHC_CAP_SDR50 | SDHC_CAP_VOLTAGE_18);
> +                            SDHC_CAP_SDR50 | SDHC_CAP_HS400 |
> +                            SDHC_CAP_VOLTAGE_18);
>    }
>  
>    if (!SdMmcDesc.Xenon8BitBusEnabled) {
> @@ -365,7 +366,7 @@ XenonSdMmcCapability (
>    }
>  
>    if (SdMmcDesc.XenonSlowModeEnabled) {
> -    Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50);
> +    Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50 | SDHC_CAP_HS400);
>    }
>  
>    Capability &= ~(UINT64)(SDHC_CAP_SLOT_TYPE_MASK);
> -- 
> 2.7.4
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42880): https://edk2.groups.io/g/devel/message/42880
Mute This Topic: https://groups.io/mt/32212561/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH] Marvell/Drivers: XenonDxe: Explicitly disable HS400
Posted by Marcin Wojtas 4 years, 9 months ago
Hi Leif,

śr., 26 cze 2019 o 11:31 Leif Lindholm <leif.lindholm@linaro.org> napisał(a):
>
> On Wed, Jun 26, 2019 at 09:04:14AM +0200, Marcin Wojtas wrote:
> > Ensure that in case of SlowMode or 3.3V operation,
> > also the HS400 capability will be disabled in the
> > SdMmc driver.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
>
> Well done on keeping this tag. But I'm thinking we need to do that
> relicensing sooner rather than later, and drop the tag.

I left it, as this file is still not 2-clause SPDX tagged.

>
>
> However, can you clarify what problem this solves?
>

On another SoC revision, the capability register marks HS400 support
as enabled. However the interface itself is powered with 3.3V and it
turned out that my flags in SdMmcOverride driver did not cover this
case, which resulted in an unsuccessful EmmcSwitchToHS400 () execution
- it shouldn't be done at all.

Best regards,
Marcin

> /
>     Leif
>
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > ---
> >  Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h         | 1 +
> >  Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c | 5 +++--
> >  2 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h
> > index 8bf1835..2d7c7f0 100644
> > --- a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h
> > +++ b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h
> > @@ -82,6 +82,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> >  #define SDHC_CAP_SDR50                BIT32
> >  #define SDHC_CAP_SDR104               BIT33
> >  #define SDHC_CAP_DDR50                BIT34
> > +#define SDHC_CAP_HS400                BIT63
> >  #define SDHC_MAX_CURRENT_CAP          0x0048
> >  #define SDHC_FORCE_EVT_AUTO_CMD       0x0050
> >  #define SDHC_FORCE_EVT_ERR_INT        0x0052
> > diff --git a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c
> > index 7a9266e..55ebcf8 100644
> > --- a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c
> > +++ b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c
> > @@ -357,7 +357,8 @@ XenonSdMmcCapability (
> >      Capability &= ~(UINT64)(SDHC_CAP_VOLTAGE_33 | SDHC_CAP_VOLTAGE_30);
> >    } else {
> >      Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50 |
> > -                            SDHC_CAP_SDR50 | SDHC_CAP_VOLTAGE_18);
> > +                            SDHC_CAP_SDR50 | SDHC_CAP_HS400 |
> > +                            SDHC_CAP_VOLTAGE_18);
> >    }
> >
> >    if (!SdMmcDesc.Xenon8BitBusEnabled) {
> > @@ -365,7 +366,7 @@ XenonSdMmcCapability (
> >    }
> >
> >    if (SdMmcDesc.XenonSlowModeEnabled) {
> > -    Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50);
> > +    Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50 | SDHC_CAP_HS400);
> >    }
> >
> >    Capability &= ~(UINT64)(SDHC_CAP_SLOT_TYPE_MASK);
> > --
> > 2.7.4
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42883): https://edk2.groups.io/g/devel/message/42883
Mute This Topic: https://groups.io/mt/32212561/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH] Marvell/Drivers: XenonDxe: Explicitly disable HS400
Posted by Marcin Wojtas 4 years, 8 months ago
Hi Leif,

śr., 26 cze 2019 o 11:58 Marcin Wojtas <mw@semihalf.com> napisał(a):
>
> Hi Leif,
>
> śr., 26 cze 2019 o 11:31 Leif Lindholm <leif.lindholm@linaro.org> napisał(a):
> >
> > On Wed, Jun 26, 2019 at 09:04:14AM +0200, Marcin Wojtas wrote:
> > > Ensure that in case of SlowMode or 3.3V operation,
> > > also the HS400 capability will be disabled in the
> > > SdMmc driver.
> > >
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> >
> > Well done on keeping this tag. But I'm thinking we need to do that
> > relicensing sooner rather than later, and drop the tag.
>
> I left it, as this file is still not 2-clause SPDX tagged.
>
> >
> >
> > However, can you clarify what problem this solves?
> >
>
> On another SoC revision, the capability register marks HS400 support
> as enabled. However the interface itself is powered with 3.3V and it
> turned out that my flags in SdMmcOverride driver did not cover this
> case, which resulted in an unsuccessful EmmcSwitchToHS400 () execution
> - it shouldn't be done at all.
>

Did you have a chance to see my explanation? Should I repost?

Best regards,
Marcin

> > /
> >     Leif
> >
> > > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > > ---
> > >  Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h         | 1 +
> > >  Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c | 5 +++--
> > >  2 files changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h
> > > index 8bf1835..2d7c7f0 100644
> > > --- a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h
> > > +++ b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h
> > > @@ -82,6 +82,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> > >  #define SDHC_CAP_SDR50                BIT32
> > >  #define SDHC_CAP_SDR104               BIT33
> > >  #define SDHC_CAP_DDR50                BIT34
> > > +#define SDHC_CAP_HS400                BIT63
> > >  #define SDHC_MAX_CURRENT_CAP          0x0048
> > >  #define SDHC_FORCE_EVT_AUTO_CMD       0x0050
> > >  #define SDHC_FORCE_EVT_ERR_INT        0x0052
> > > diff --git a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c
> > > index 7a9266e..55ebcf8 100644
> > > --- a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c
> > > +++ b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c
> > > @@ -357,7 +357,8 @@ XenonSdMmcCapability (
> > >      Capability &= ~(UINT64)(SDHC_CAP_VOLTAGE_33 | SDHC_CAP_VOLTAGE_30);
> > >    } else {
> > >      Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50 |
> > > -                            SDHC_CAP_SDR50 | SDHC_CAP_VOLTAGE_18);
> > > +                            SDHC_CAP_SDR50 | SDHC_CAP_HS400 |
> > > +                            SDHC_CAP_VOLTAGE_18);
> > >    }
> > >
> > >    if (!SdMmcDesc.Xenon8BitBusEnabled) {
> > > @@ -365,7 +366,7 @@ XenonSdMmcCapability (
> > >    }
> > >
> > >    if (SdMmcDesc.XenonSlowModeEnabled) {
> > > -    Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50);
> > > +    Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50 | SDHC_CAP_HS400);
> > >    }
> > >
> > >    Capability &= ~(UINT64)(SDHC_CAP_SLOT_TYPE_MASK);
> > > --
> > > 2.7.4
> > >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43584): https://edk2.groups.io/g/devel/message/43584
Mute This Topic: https://groups.io/mt/32212561/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH] Marvell/Drivers: XenonDxe: Explicitly disable HS400
Posted by Leif Lindholm 4 years, 8 months ago

On Thu, Jul 11, 2019 at 10:07:27AM +0200, Marcin Wojtas wrote:
> Hi Leif,
> 
> śr., 26 cze 2019 o 11:58 Marcin Wojtas <mw@semihalf.com> napisał(a):
> >
> > Hi Leif,
> >
> > śr., 26 cze 2019 o 11:31 Leif Lindholm <leif.lindholm@linaro.org> napisał(a):
> > >
> > > On Wed, Jun 26, 2019 at 09:04:14AM +0200, Marcin Wojtas wrote:
> > > > Ensure that in case of SlowMode or 3.3V operation,
> > > > also the HS400 capability will be disabled in the
> > > > SdMmc driver.
> > > >
> > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > >
> > > Well done on keeping this tag. But I'm thinking we need to do that
> > > relicensing sooner rather than later, and drop the tag.
> >
> > I left it, as this file is still not 2-clause SPDX tagged.
> >
> > >
> > >
> > > However, can you clarify what problem this solves?
> > >
> >
> > On another SoC revision, the capability register marks HS400 support
> > as enabled. However the interface itself is powered with 3.3V and it
> > turned out that my flags in SdMmcOverride driver did not cover this
> > case, which resulted in an unsuccessful EmmcSwitchToHS400 () execution
> > - it shouldn't be done at all.
> >
> 
> Did you have a chance to see my explanation? Should I repost?

Sorry, yes. Explanation is fine. If you can update the commit message
and drop the Contributed-under, I will push this once we get the
licenses updated.

Best Regards,

Leif

> Best regards,
> Marcin
> 
> > > /
> > >     Leif
> > >
> > > > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > > > ---
> > > >  Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h         | 1 +
> > > >  Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c | 5 +++--
> > > >  2 files changed, 4 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h
> > > > index 8bf1835..2d7c7f0 100644
> > > > --- a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h
> > > > +++ b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h
> > > > @@ -82,6 +82,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> > > >  #define SDHC_CAP_SDR50                BIT32
> > > >  #define SDHC_CAP_SDR104               BIT33
> > > >  #define SDHC_CAP_DDR50                BIT34
> > > > +#define SDHC_CAP_HS400                BIT63
> > > >  #define SDHC_MAX_CURRENT_CAP          0x0048
> > > >  #define SDHC_FORCE_EVT_AUTO_CMD       0x0050
> > > >  #define SDHC_FORCE_EVT_ERR_INT        0x0052
> > > > diff --git a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c
> > > > index 7a9266e..55ebcf8 100644
> > > > --- a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c
> > > > +++ b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c
> > > > @@ -357,7 +357,8 @@ XenonSdMmcCapability (
> > > >      Capability &= ~(UINT64)(SDHC_CAP_VOLTAGE_33 | SDHC_CAP_VOLTAGE_30);
> > > >    } else {
> > > >      Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50 |
> > > > -                            SDHC_CAP_SDR50 | SDHC_CAP_VOLTAGE_18);
> > > > +                            SDHC_CAP_SDR50 | SDHC_CAP_HS400 |
> > > > +                            SDHC_CAP_VOLTAGE_18);
> > > >    }
> > > >
> > > >    if (!SdMmcDesc.Xenon8BitBusEnabled) {
> > > > @@ -365,7 +366,7 @@ XenonSdMmcCapability (
> > > >    }
> > > >
> > > >    if (SdMmcDesc.XenonSlowModeEnabled) {
> > > > -    Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50);
> > > > +    Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50 | SDHC_CAP_HS400);
> > > >    }
> > > >
> > > >    Capability &= ~(UINT64)(SDHC_CAP_SLOT_TYPE_MASK);
> > > > --
> > > > 2.7.4
> > > >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43586): https://edk2.groups.io/g/devel/message/43586
Mute This Topic: https://groups.io/mt/32212561/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH] Marvell/Drivers: XenonDxe: Explicitly disable HS400
Posted by Leif Lindholm 4 years, 7 months ago
Hi Marcin,

On Thu, Jul 11, 2019 at 09:45:00AM +0100, Leif Lindholm wrote:
> > > > On Wed, Jun 26, 2019 at 09:04:14AM +0200, Marcin Wojtas wrote:
> > > > > Ensure that in case of SlowMode or 3.3V operation,
> > > > > also the HS400 capability will be disabled in the
> > > > > SdMmc driver.
> > > > >
> > > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > >
> > > > Well done on keeping this tag. But I'm thinking we need to do that
> > > > relicensing sooner rather than later, and drop the tag.
> > >
> > > I left it, as this file is still not 2-clause SPDX tagged.
> > >
> > > >
> > > >
> > > > However, can you clarify what problem this solves?
> > > >
> > >
> > > On another SoC revision, the capability register marks HS400 support
> > > as enabled. However the interface itself is powered with 3.3V and it
> > > turned out that my flags in SdMmcOverride driver did not cover this
> > > case, which resulted in an unsuccessful EmmcSwitchToHS400 () execution
> > > - it shouldn't be done at all.
> > >
> > 
> > Did you have a chance to see my explanation? Should I repost?
> 
> Sorry, yes. Explanation is fine. If you can update the commit message
> and drop the Contributed-under, I will push this once we get the
> licenses updated.

Licenses have now been updated.
Can you please resubmit with the updated commit message and dropped
Contributed-under?

Best Regards,

Leif

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44912): https://edk2.groups.io/g/devel/message/44912
Mute This Topic: https://groups.io/mt/32212561/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-