From nobody Sat Feb 7 06:55:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+41412+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41412+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1558949515; cv=none; d=zoho.com; s=zohoarc; b=bjWDRFOM3D41tN6KIgsIZxV8V/c/h9m8TSLtIPkE8ERXot9qbE6TO4BIneMLYY0YPdQHj3+GjXiONp30wUtbnp/UKreT+LFxXtNF0vvthzIUNA/ApO+gafG0CmhSu5kzCLY1HQdzRNonv1mJnkGFLQAPt6C62B8FNtC9fvCcfFo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558949515; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=FOP/cP6ffTiBrf9HCbbQkkxYt/n0AYnv6fZcXJI1xkA=; b=K6ev1PLJTAvbo6vc8lDbKWuDpmj0kDiwXJ3ZuDBsu2064ktfmRw2SLSlhI73xCVKJH/RyR+i5kDQjKna9eS5/GFkTIlmNeyINFxcbLBfoeonN/KbkHuZWS/ZZd78ww894ADF+mKKG45/KeyKt1jwkclbObu4xKEocH7RmtEg+WM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41412+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1558949515691517.9881736796433; Mon, 27 May 2019 02:31:55 -0700 (PDT) Return-Path: X-Received: from mga02.intel.com (mga02.intel.com []) by groups.io with SMTP; Mon, 27 May 2019 02:31:55 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 May 2019 02:31:54 -0700 X-ExtLoop1: 1 X-Received: from pg-nx11.altera.com ([10.104.4.26]) by orsmga008.jf.intel.com with ESMTP; 27 May 2019 02:31:53 -0700 From: "Loh, Tien Hock" To: devel@edk2.groups.io, thloh85@gmail.com Cc: "Tien Hock, Loh" , Leif Lindholm , Ard Biesheuvel Subject: [edk2-devel] [PATCH v2 4/7] EmbeddedPkg: Fix response check flag Date: Mon, 27 May 2019 17:30:25 +0800 Message-Id: <1558949428-190715-5-git-send-email-tien.hock.loh@intel.com> In-Reply-To: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> References: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tien.hock.loh@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1558949515; bh=eubPh4s+KQiOf/xmgmABIhBjxpxqKv7voGMHOxF84IE=; h=Cc:Date:From:Reply-To:Subject:To; b=e2n4uTKLaSUmtaUOIuk76WWF3FTYSlx+LXMkUSmuxSB9/Rum2fBkgUJjuvcrrlDQ/3E jvXPgAr1qRzOqymD0JW0UsoMn6f89vdqH61YVsg9u9/MrFLPvFsIxEyWqnImLaVs9Ux1p 1g2HYeoi8NFpvj/myqjNqHPrS2k5NZHcWJQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Tien Hock, Loh" Do not send CRC response check if the MMC command does not support CRC response Signed-off-by: Tien Hock, Loh Cc: Leif Lindholm Cc: Ard Biesheuvel Reviewed-by: Leif Lindholm --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Driver= s/DwEmmcDxe/DwEmmcDxe.c index c44e310c04..e0068655ca 100644 --- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c +++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c @@ -385,7 +385,7 @@ DwEmmcSendCommand ( BIT_CMD_READ | BIT_CMD_WAIT_PRVDATA_COMPLETE; break; default: - Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC; + Cmd =3D BIT_CMD_RESPONSE_EXPECT; break; } =20 @@ -396,6 +396,10 @@ DwEmmcSendCommand ( else IsACmd =3D FALSE; =20 + if (!(MmcCmd & MMC_CMD_NO_CRC_RESPONSE)) { + Cmd |=3D BIT_CMD_CHECK_RESPONSE_CRC; + } + if (IsPendingReadCommand (Cmd) || IsPendingWriteCommand (Cmd)) { mDwEmmcCommand =3D Cmd; mDwEmmcArgument =3D Argument; --=20 2.19.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41412): https://edk2.groups.io/g/devel/message/41412 Mute This Topic: https://groups.io/mt/31807963/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-