From nobody Sat Feb 7 06:55:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+41410+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41410+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1558949511; cv=none; d=zoho.com; s=zohoarc; b=ctfeEUWvPB2rThjEQBvdyfhgY5qvNqipdZxQQQvu/O8K+u5iyXkBlc98S6dbschaB+kZnn8WVaJ2Tn9SHCARIiRHx08lA0SewYCPw2H2GwZ32bQiheSxbbjC9KiUD2DD+xJr8097YqzwRfmGvUOqImzvYDYtkwNBd0hcb21eLZM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558949511; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=tT4FqtTdChoh0por5pwjos/8Y6VaN3ooG056MwmQrqI=; b=PxD1t2oPjr16T4/vCwl/CxJPhb8u+P+L6uX7aARTO2I+GZt9q502kTq6DEVzPCineG+p6dBi7Oa4nhEFMFyT9/GorWZtUVSDpaPlwEy0WalEh+SIo2ggWexa//tZg0PJkMl2dsCExSmS2mwUmTOSdqkMZeUZ9f33Gc5wgdXKZi8= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41410+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1558949511949316.31067646895406; Mon, 27 May 2019 02:31:51 -0700 (PDT) Return-Path: X-Received: from mga02.intel.com (mga02.intel.com []) by groups.io with SMTP; Mon, 27 May 2019 02:31:51 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 May 2019 02:31:50 -0700 X-ExtLoop1: 1 X-Received: from pg-nx11.altera.com ([10.104.4.26]) by orsmga008.jf.intel.com with ESMTP; 27 May 2019 02:31:49 -0700 From: "Loh, Tien Hock" To: devel@edk2.groups.io, thloh85@gmail.com Cc: "Tien Hock, Loh" , Leif Lindholm , Ard Biesheuvel Subject: [edk2-devel] [PATCH v2 2/7] EmbeddedPkg: Fix DwEmmc CMD8 support for SD Date: Mon, 27 May 2019 17:30:23 +0800 Message-Id: <1558949428-190715-3-git-send-email-tien.hock.loh@intel.com> In-Reply-To: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> References: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tien.hock.loh@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1558949511; bh=C4nGZqcgapsIkZqcKibHRu95NwqjqFexTzpI++r6z4E=; h=Cc:Date:From:Reply-To:Subject:To; b=aCYRqnqyiPFUHr6kTJ1hEKfYyNQJ40WeKRNE4a4xtMU+Zs6q8KCRCieBVNy3Cu6cZ9V 1wghPn3ZUk/ds1pHAgUNtpvT97W6XBm2EXLt6xCuW0tQCRik7VKK4dw/JTPaBii9Hqmkd 2Q29DecAsccptVI4+8QynQxDCxNH6bzH07M= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Tien Hock, Loh" On CMD8, for SD, the controller should not expect data as this is a SEND_IF_COND command to verify SD operating condition, and does not have data. Signed-off-by: Tien Hock, Loh Cc: Leif Lindholm Cc: Ard Biesheuvel -- v2 - Change IsEmmc to EFI_MMC_HOST_CARD_TYPE --- EmbeddedPkg/Include/Protocol/MmcHost.h | 6 ++++++ EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 9 ++++++--- EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 2 ++ 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/EmbeddedPkg/Include/Protocol/MmcHost.h b/EmbeddedPkg/Include/P= rotocol/MmcHost.h index 9e07082680..7807744721 100644 --- a/EmbeddedPkg/Include/Protocol/MmcHost.h +++ b/EmbeddedPkg/Include/Protocol/MmcHost.h @@ -151,6 +151,11 @@ typedef BOOLEAN (EFIAPI *MMC_ISMULTIBLOCK) ( IN EFI_MMC_HOST_PROTOCOL *This ); =20 +typedef enum { + EMMC, + SD +} EFI_MMC_HOST_CARD_TYPE; + struct _EFI_MMC_HOST_PROTOCOL { =20 UINT32 Revision; @@ -169,6 +174,7 @@ struct _EFI_MMC_HOST_PROTOCOL { MMC_SETIOS SetIos; MMC_ISMULTIBLOCK IsMultiBlock; =20 + EFI_MMC_HOST_CARD_TYPE HostCardType; }; =20 #define MMC_HOST_PROTOCOL_REVISION 0x00010002 // 1.2 diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Driver= s/DwEmmcDxe/DwEmmcDxe.c index 420487757d..fd3a5bf685 100644 --- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c +++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c @@ -340,9 +340,12 @@ DwEmmcSendCommand ( Cmd =3D 0; break; case MMC_INDX(8): - Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC | - BIT_CMD_DATA_EXPECTED | BIT_CMD_READ | - BIT_CMD_WAIT_PRVDATA_COMPLETE; + if (This->HostCardType =3D=3D SD) + Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC | + BIT_CMD_WAIT_PRVDATA_COMPLETE; + else + Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC | + BIT_CMD_WAIT_PRVDATA_COMPLETE | BIT_CMD_READ | BIT_CMD_DATA_E= XPECTED; break; case MMC_INDX(9): Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC | diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c b/EmbeddedPkg= /Universal/MmcDxe/MmcIdentification.c index 4dc0be125c..c816ae09ee 100755 --- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c +++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c @@ -770,8 +770,10 @@ InitializeMmcDevice ( } =20 if (MmcHostInstance->CardInfo.CardType !=3D EMMC_CARD) { + MmcHostInstance->MmcHost->HostCardType =3D SD; Status =3D InitializeSdMmcDevice (MmcHostInstance); } else { + MmcHostInstance->MmcHost->HostCardType =3D EMMC; Status =3D InitializeEmmcDevice (MmcHostInstance); } if (EFI_ERROR (Status)) { --=20 2.19.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41410): https://edk2.groups.io/g/devel/message/41410 Mute This Topic: https://groups.io/mt/31807961/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-