From nobody Sat Feb 7 03:01:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+41409+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41409+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1558949510; cv=none; d=zoho.com; s=zohoarc; b=gIIPEwFDEMiZbMa3Dx+NWInxs72sIYJFI98ks6D9GqbNAtvJyoEdxO7JE5vDTPPRHScaw8+z1I/l9ffgUH4st1vSun9KmGeaQ9qoCuYt+2f250Epq+nne5vJQV5teWjFBaf7AO2SgyvV4/13twyY5AHsDI3VG0raOCu/aJRMs6w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558949510; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=Vj7Jo2Q9DsfYKWVRydxw2QvKwdenkgliVjoI3YgwV58=; b=LfAO25xzN5kLkUFHeHkVoqzPHf7PFVDAOTJFCYDNkR7jUR75F1x8AiPCRw2tD5cdEA2rboSaqJ31VHzhm6WrfgK/lW2ChkDmCP+g5Hf7MMYbTuaI5hjVFaHAX0yDBN6OFuaNWQV6tKq/T7A6Geg9+j2zU+iYyB3Dt+XDomIac3Y= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41409+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1558949509959515.1593123345917; Mon, 27 May 2019 02:31:49 -0700 (PDT) Return-Path: X-Received: from mga02.intel.com (mga02.intel.com []) by groups.io with SMTP; Mon, 27 May 2019 02:31:49 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 May 2019 02:31:49 -0700 X-ExtLoop1: 1 X-Received: from pg-nx11.altera.com ([10.104.4.26]) by orsmga008.jf.intel.com with ESMTP; 27 May 2019 02:31:47 -0700 From: "Loh, Tien Hock" To: devel@edk2.groups.io, thloh85@gmail.com Cc: "TIen Hock, Loh" , Leif Lindholm , Ard Biesheuvel Subject: [edk2-devel] [PATCH v2 1/7] EmbeddedPkg: Add SD command support for DwEmmc Date: Mon, 27 May 2019 17:30:22 +0800 Message-Id: <1558949428-190715-2-git-send-email-tien.hock.loh@intel.com> In-Reply-To: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> References: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tien.hock.loh@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1558949509; bh=q+EeZ09IFBqlmQxhekn5mwz6HPdOqv6S0I4sfE1sLa4=; h=Cc:Date:From:Reply-To:Subject:To; b=XL5eUqmFtutg7QELvDH02K8Kh4mweaL14hNXwf9YLzO0ZpjYfNIfn5ZcdA9QLD2bubM YfjP04DdBKSdpLAcvB1dRgQ6jS8V8AGJZX3pDRegviUXAQvNsa3O5B9gVwv06hYXxGw3m x/i3DQ4ohJNk3Bushxq/USrkPY5Qd33P9Fc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "TIen Hock, Loh" Added ACMD6 for SD support. For SD, after CMD55 is sent, the next command should be an application command, which should not expect data Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel -- v2: - Move IsACmd as a local static variable in function - Fix some coding standard issue with spacing --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Driver= s/DwEmmcDxe/DwEmmcDxe.c index 68c523a99f..420487757d 100644 --- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c +++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c @@ -307,6 +307,7 @@ DwEmmcSendCommand ( { UINT32 Cmd =3D 0; EFI_STATUS Status =3D EFI_SUCCESS; + STATIC BOOLEAN IsACmd =3D FALSE; =20 switch (MMC_GET_INDX(MmcCmd)) { case MMC_INDX(0): @@ -323,6 +324,15 @@ DwEmmcSendCommand ( Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC | BIT_CMD_SEND_INIT; break; + case MMC_INDX (6): + if(IsACmd) { + Cmd =3D BIT_CMD_RESPONSE_EXPECT; + } + else { + Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_DATA_EXPECTED | + BIT_CMD_READ; + } + break; case MMC_INDX(7): if (Argument) Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC; @@ -367,12 +377,22 @@ DwEmmcSendCommand ( Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC | BIT_CMD_DATA_EXPECTED; break; + case MMC_INDX (51): + Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_DATA_EXPECTED | + BIT_CMD_READ | BIT_CMD_WAIT_PRVDATA_COMPLETE; + break; default: Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC; break; } =20 Cmd |=3D MMC_GET_INDX(MmcCmd) | BIT_CMD_USE_HOLD_REG | BIT_CMD_START; + + if(MMC_INDX (55) =3D=3D MMC_GET_INDX (MmcCmd)) + IsACmd =3D TRUE; + else + IsACmd =3D FALSE; + if (IsPendingReadCommand (Cmd) || IsPendingWriteCommand (Cmd)) { mDwEmmcCommand =3D Cmd; mDwEmmcArgument =3D Argument; --=20 2.19.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41409): https://edk2.groups.io/g/devel/message/41409 Mute This Topic: https://groups.io/mt/31807960/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat Feb 7 03:01:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+41410+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41410+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1558949511; cv=none; d=zoho.com; s=zohoarc; b=ctfeEUWvPB2rThjEQBvdyfhgY5qvNqipdZxQQQvu/O8K+u5iyXkBlc98S6dbschaB+kZnn8WVaJ2Tn9SHCARIiRHx08lA0SewYCPw2H2GwZ32bQiheSxbbjC9KiUD2DD+xJr8097YqzwRfmGvUOqImzvYDYtkwNBd0hcb21eLZM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558949511; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=tT4FqtTdChoh0por5pwjos/8Y6VaN3ooG056MwmQrqI=; b=PxD1t2oPjr16T4/vCwl/CxJPhb8u+P+L6uX7aARTO2I+GZt9q502kTq6DEVzPCineG+p6dBi7Oa4nhEFMFyT9/GorWZtUVSDpaPlwEy0WalEh+SIo2ggWexa//tZg0PJkMl2dsCExSmS2mwUmTOSdqkMZeUZ9f33Gc5wgdXKZi8= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41410+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1558949511949316.31067646895406; Mon, 27 May 2019 02:31:51 -0700 (PDT) Return-Path: X-Received: from mga02.intel.com (mga02.intel.com []) by groups.io with SMTP; Mon, 27 May 2019 02:31:51 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 May 2019 02:31:50 -0700 X-ExtLoop1: 1 X-Received: from pg-nx11.altera.com ([10.104.4.26]) by orsmga008.jf.intel.com with ESMTP; 27 May 2019 02:31:49 -0700 From: "Loh, Tien Hock" To: devel@edk2.groups.io, thloh85@gmail.com Cc: "Tien Hock, Loh" , Leif Lindholm , Ard Biesheuvel Subject: [edk2-devel] [PATCH v2 2/7] EmbeddedPkg: Fix DwEmmc CMD8 support for SD Date: Mon, 27 May 2019 17:30:23 +0800 Message-Id: <1558949428-190715-3-git-send-email-tien.hock.loh@intel.com> In-Reply-To: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> References: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tien.hock.loh@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1558949511; bh=C4nGZqcgapsIkZqcKibHRu95NwqjqFexTzpI++r6z4E=; h=Cc:Date:From:Reply-To:Subject:To; b=aCYRqnqyiPFUHr6kTJ1hEKfYyNQJ40WeKRNE4a4xtMU+Zs6q8KCRCieBVNy3Cu6cZ9V 1wghPn3ZUk/ds1pHAgUNtpvT97W6XBm2EXLt6xCuW0tQCRik7VKK4dw/JTPaBii9Hqmkd 2Q29DecAsccptVI4+8QynQxDCxNH6bzH07M= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Tien Hock, Loh" On CMD8, for SD, the controller should not expect data as this is a SEND_IF_COND command to verify SD operating condition, and does not have data. Signed-off-by: Tien Hock, Loh Cc: Leif Lindholm Cc: Ard Biesheuvel -- v2 - Change IsEmmc to EFI_MMC_HOST_CARD_TYPE --- EmbeddedPkg/Include/Protocol/MmcHost.h | 6 ++++++ EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 9 ++++++--- EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 2 ++ 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/EmbeddedPkg/Include/Protocol/MmcHost.h b/EmbeddedPkg/Include/P= rotocol/MmcHost.h index 9e07082680..7807744721 100644 --- a/EmbeddedPkg/Include/Protocol/MmcHost.h +++ b/EmbeddedPkg/Include/Protocol/MmcHost.h @@ -151,6 +151,11 @@ typedef BOOLEAN (EFIAPI *MMC_ISMULTIBLOCK) ( IN EFI_MMC_HOST_PROTOCOL *This ); =20 +typedef enum { + EMMC, + SD +} EFI_MMC_HOST_CARD_TYPE; + struct _EFI_MMC_HOST_PROTOCOL { =20 UINT32 Revision; @@ -169,6 +174,7 @@ struct _EFI_MMC_HOST_PROTOCOL { MMC_SETIOS SetIos; MMC_ISMULTIBLOCK IsMultiBlock; =20 + EFI_MMC_HOST_CARD_TYPE HostCardType; }; =20 #define MMC_HOST_PROTOCOL_REVISION 0x00010002 // 1.2 diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Driver= s/DwEmmcDxe/DwEmmcDxe.c index 420487757d..fd3a5bf685 100644 --- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c +++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c @@ -340,9 +340,12 @@ DwEmmcSendCommand ( Cmd =3D 0; break; case MMC_INDX(8): - Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC | - BIT_CMD_DATA_EXPECTED | BIT_CMD_READ | - BIT_CMD_WAIT_PRVDATA_COMPLETE; + if (This->HostCardType =3D=3D SD) + Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC | + BIT_CMD_WAIT_PRVDATA_COMPLETE; + else + Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC | + BIT_CMD_WAIT_PRVDATA_COMPLETE | BIT_CMD_READ | BIT_CMD_DATA_E= XPECTED; break; case MMC_INDX(9): Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC | diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c b/EmbeddedPkg= /Universal/MmcDxe/MmcIdentification.c index 4dc0be125c..c816ae09ee 100755 --- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c +++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c @@ -770,8 +770,10 @@ InitializeMmcDevice ( } =20 if (MmcHostInstance->CardInfo.CardType !=3D EMMC_CARD) { + MmcHostInstance->MmcHost->HostCardType =3D SD; Status =3D InitializeSdMmcDevice (MmcHostInstance); } else { + MmcHostInstance->MmcHost->HostCardType =3D EMMC; Status =3D InitializeEmmcDevice (MmcHostInstance); } if (EFI_ERROR (Status)) { --=20 2.19.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41410): https://edk2.groups.io/g/devel/message/41410 Mute This Topic: https://groups.io/mt/31807961/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat Feb 7 03:01:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+41411+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41411+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1558949513; cv=none; d=zoho.com; s=zohoarc; b=RdCYb8mT3QOBkWrFDXucEnGnb/P0Os2RoOs20pTrbCK3EzhxbpLJndT3P0B8jJ4m3qFraL2A3oPUor4Asl7AJ8bUmFimzdRo3jrgrwhYwR4uIOhyb2y324XtDzSd5ugb8cd1DWocLcwao5HkNAtO/ptHfVxj26LB6VW28F/uz8A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558949513; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=6UTjZUFfcHwGqIgEmEPVRnBN0c+agzol9jirmLB/E4s=; b=A3AqUzRQY8Oz3DiPVg7e6hfTkMMaIM94rYXa0ULGp7VHy7IqtjULJUUY33+h8thM1dGFer7t7WY/NOwbgYBUAPluJHkii3SL9FIF8z7AzuNX8VemNqxRDLt/YMTRwPPnpFnZPR2BXB3U8jSuTC89U69gdKSfzVKAj2D5t5Oaq+M= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41411+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1558949513902653.9194379368513; Mon, 27 May 2019 02:31:53 -0700 (PDT) Return-Path: X-Received: from mga02.intel.com (mga02.intel.com []) by groups.io with SMTP; Mon, 27 May 2019 02:31:53 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 May 2019 02:31:52 -0700 X-ExtLoop1: 1 X-Received: from pg-nx11.altera.com ([10.104.4.26]) by orsmga008.jf.intel.com with ESMTP; 27 May 2019 02:31:51 -0700 From: "Loh, Tien Hock" To: devel@edk2.groups.io, thloh85@gmail.com Cc: "Tien Hock, Loh" , Leif Lindholm , Ard Biesheuvel Subject: [edk2-devel] [PATCH v2 3/7] EmbeddedPkg: Send command when MMC ask for response Date: Mon, 27 May 2019 17:30:24 +0800 Message-Id: <1558949428-190715-4-git-send-email-tien.hock.loh@intel.com> In-Reply-To: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> References: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tien.hock.loh@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1558949513; bh=NujkDDoPQhCo0FXyxt/ZQOVLSkzYvOnbbwuAW//mmuE=; h=Cc:Date:From:Reply-To:Subject:To; b=gaiN5CAouiHdfkPSCtNPyGW85L6gT2QeIHgtqxQrHOZuGvHGmoqhRhWcI/7KFZbpKvw uK8f1zKFavyRBMieG5y+5XON2k/jzJJqAXZVoj75BCPRdm4cElQw9/hIvI9ZG/jHskjoh LzdFFL2fb8MI0teouegTmCcm8ECUT9XhBXs= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Tien Hock, Loh" Send command when MMC ask for response in DwEmmcReceiveResponse, and command is a pending command (eg. DMA needs to be set up first) Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Driver= s/DwEmmcDxe/DwEmmcDxe.c index fd3a5bf685..c44e310c04 100644 --- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c +++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c @@ -400,6 +400,8 @@ DwEmmcSendCommand ( mDwEmmcCommand =3D Cmd; mDwEmmcArgument =3D Argument; } else { + mDwEmmcCommand =3D Cmd; + mDwEmmcArgument =3D Argument; Status =3D SendCommand (Cmd, Argument); } return Status; @@ -412,10 +414,15 @@ DwEmmcReceiveResponse ( IN UINT32* Buffer ) { + EFI_STATUS Status =3D EFI_SUCCESS; + if (Buffer =3D=3D NULL) { return EFI_INVALID_PARAMETER; } =20 + if(IsPendingReadCommand (mDwEmmcCommand) || IsPendingWriteCommand(mDwEmm= cCommand)) + Status =3D SendCommand (mDwEmmcCommand, mDwEmmcArgument); + if ( (Type =3D=3D MMC_RESPONSE_TYPE_R1) || (Type =3D=3D MMC_RESPONSE_TYPE_R1b) || (Type =3D=3D MMC_RESPONSE_TYPE_R3) @@ -429,7 +436,7 @@ DwEmmcReceiveResponse ( Buffer[2] =3D MmioRead32 (DWEMMC_RESP2); Buffer[3] =3D MmioRead32 (DWEMMC_RESP3); } - return EFI_SUCCESS; + return Status; } =20 VOID --=20 2.19.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41411): https://edk2.groups.io/g/devel/message/41411 Mute This Topic: https://groups.io/mt/31807962/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat Feb 7 03:01:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+41412+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41412+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1558949515; cv=none; d=zoho.com; s=zohoarc; b=bjWDRFOM3D41tN6KIgsIZxV8V/c/h9m8TSLtIPkE8ERXot9qbE6TO4BIneMLYY0YPdQHj3+GjXiONp30wUtbnp/UKreT+LFxXtNF0vvthzIUNA/ApO+gafG0CmhSu5kzCLY1HQdzRNonv1mJnkGFLQAPt6C62B8FNtC9fvCcfFo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558949515; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=FOP/cP6ffTiBrf9HCbbQkkxYt/n0AYnv6fZcXJI1xkA=; b=K6ev1PLJTAvbo6vc8lDbKWuDpmj0kDiwXJ3ZuDBsu2064ktfmRw2SLSlhI73xCVKJH/RyR+i5kDQjKna9eS5/GFkTIlmNeyINFxcbLBfoeonN/KbkHuZWS/ZZd78ww894ADF+mKKG45/KeyKt1jwkclbObu4xKEocH7RmtEg+WM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41412+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1558949515691517.9881736796433; Mon, 27 May 2019 02:31:55 -0700 (PDT) Return-Path: X-Received: from mga02.intel.com (mga02.intel.com []) by groups.io with SMTP; Mon, 27 May 2019 02:31:55 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 May 2019 02:31:54 -0700 X-ExtLoop1: 1 X-Received: from pg-nx11.altera.com ([10.104.4.26]) by orsmga008.jf.intel.com with ESMTP; 27 May 2019 02:31:53 -0700 From: "Loh, Tien Hock" To: devel@edk2.groups.io, thloh85@gmail.com Cc: "Tien Hock, Loh" , Leif Lindholm , Ard Biesheuvel Subject: [edk2-devel] [PATCH v2 4/7] EmbeddedPkg: Fix response check flag Date: Mon, 27 May 2019 17:30:25 +0800 Message-Id: <1558949428-190715-5-git-send-email-tien.hock.loh@intel.com> In-Reply-To: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> References: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tien.hock.loh@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1558949515; bh=eubPh4s+KQiOf/xmgmABIhBjxpxqKv7voGMHOxF84IE=; h=Cc:Date:From:Reply-To:Subject:To; b=e2n4uTKLaSUmtaUOIuk76WWF3FTYSlx+LXMkUSmuxSB9/Rum2fBkgUJjuvcrrlDQ/3E jvXPgAr1qRzOqymD0JW0UsoMn6f89vdqH61YVsg9u9/MrFLPvFsIxEyWqnImLaVs9Ux1p 1g2HYeoi8NFpvj/myqjNqHPrS2k5NZHcWJQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Tien Hock, Loh" Do not send CRC response check if the MMC command does not support CRC response Signed-off-by: Tien Hock, Loh Cc: Leif Lindholm Cc: Ard Biesheuvel Reviewed-by: Leif Lindholm --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Driver= s/DwEmmcDxe/DwEmmcDxe.c index c44e310c04..e0068655ca 100644 --- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c +++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c @@ -385,7 +385,7 @@ DwEmmcSendCommand ( BIT_CMD_READ | BIT_CMD_WAIT_PRVDATA_COMPLETE; break; default: - Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC; + Cmd =3D BIT_CMD_RESPONSE_EXPECT; break; } =20 @@ -396,6 +396,10 @@ DwEmmcSendCommand ( else IsACmd =3D FALSE; =20 + if (!(MmcCmd & MMC_CMD_NO_CRC_RESPONSE)) { + Cmd |=3D BIT_CMD_CHECK_RESPONSE_CRC; + } + if (IsPendingReadCommand (Cmd) || IsPendingWriteCommand (Cmd)) { mDwEmmcCommand =3D Cmd; mDwEmmcArgument =3D Argument; --=20 2.19.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41412): https://edk2.groups.io/g/devel/message/41412 Mute This Topic: https://groups.io/mt/31807963/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat Feb 7 03:01:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+41413+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41413+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1558949517; cv=none; d=zoho.com; s=zohoarc; b=k++1m94DCLC13gS2cNNAWq8MToK1CV4wCCbzYLAM/mhL2SRtsomIi6nswvuaQ/X6MxrNo3ejCRPeccgMxWb3jh1stxLEwYROAhvUGI6K+/Pf7AM8nzntm8/VvpCqkbYa7DDuhzOkq9zJ0XAtEtS49fREaH/EhnJ0PtTr1mvaoCk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558949517; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=6QOcGODQqh3XcUB3GBKZhaJkhiGGg4bVD4VojUCQN6A=; b=MD4YOhTODobz5taZFXea8RZmZfbo88Ot4g4efSzb3UR2W/hdJX8lBrH+qS3Y/8IUSt7vMmZNxZjL1O+CC3CLI6eI953SsrdxkvfJv1K1MI5EomxRRjfDHTsK7rapcERZ3f9cWYUbb6NbuBW2MmhJJsCStrY8ldAYKW2l4GdKCFA= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41413+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1558949517804704.0862359562942; Mon, 27 May 2019 02:31:57 -0700 (PDT) Return-Path: X-Received: from mga02.intel.com (mga02.intel.com []) by groups.io with SMTP; Mon, 27 May 2019 02:31:57 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 May 2019 02:31:56 -0700 X-ExtLoop1: 1 X-Received: from pg-nx11.altera.com ([10.104.4.26]) by orsmga008.jf.intel.com with ESMTP; 27 May 2019 02:31:55 -0700 From: "Loh, Tien Hock" To: devel@edk2.groups.io, thloh85@gmail.com Cc: "Tien Hock, Loh" , Leif Lindholm , Ard Biesheuvel Subject: [edk2-devel] [PATCH v2 5/7] EmbeddedPkg: Clear CTYPE on initialization Date: Mon, 27 May 2019 17:30:26 +0800 Message-Id: <1558949428-190715-6-git-send-email-tien.hock.loh@intel.com> In-Reply-To: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> References: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tien.hock.loh@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1558949517; bh=1F6PK8o8DoJyK8RwP9C3eBgaYGCgxtk2nKGevIkjiZE=; h=Cc:Date:From:Reply-To:Subject:To; b=w+fbYsDuh6ZyG7VsIc9OA7zDFHCL2yfhSbGcRELNZBroxfdb50CaoWuHc9zNGgyuZBT X/f0qNqetdH82KTesTKxbQTVWw+KbOqANDmquk5oYB0W5ZoQxtZA2jHSjgaqrLYZsC9UO /AjrgCplLehsVNv2Kz7FN9+Lpn2braKkfsQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Tien Hock, Loh" Clear CTYPE on initialization. This is important if previous bootloader changes the CTYPE can cause the controller to not initialize correctly if CTYPE is not reset to 0 Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel Reviewed-by: Leif Lindholm --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Driver= s/DwEmmcDxe/DwEmmcDxe.c index e0068655ca..c6c8e04917 100644 --- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c +++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c @@ -205,6 +205,7 @@ DwEmmcNotifyState ( MmioWrite32 (DWEMMC_TMOUT, ~0); MmioWrite32 (DWEMMC_IDINTEN, 0); MmioWrite32 (DWEMMC_BMOD, DWEMMC_IDMAC_SWRESET); + MmioWrite32 (DWEMMC_CTYPE, 0); =20 MmioWrite32 (DWEMMC_BLKSIZ, DWEMMC_BLOCK_SIZE); do { --=20 2.19.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41413): https://edk2.groups.io/g/devel/message/41413 Mute This Topic: https://groups.io/mt/31807964/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat Feb 7 03:01:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+41414+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41414+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1558949519; cv=none; d=zoho.com; s=zohoarc; b=KQJVLfPgtXLnuvZ9PGYkTzRsGvXdTx1zBPZ93Esz/ov1DDecfUt7yx4tC4WXrrlsDoxLuPByMEoy6Vh1cpUmj2nhYjncG41fttBwyZQfK5FWHLLmhWusxuudkfjU3+6mpWPo04TYX0sBJb1q3NGhg288lZi0dCSDLKPCNnZ612c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558949519; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=do53iHMeD0J9ibeSm+N5uso0e9ku/t2BMc9B7tEtOiY=; b=f93jEUnjpGvRWw+QfnWG9ksP2rDezZERIIvo3NTT3dXNp4SV8r97hza19plFRSpNAhCW28w4qdaWROx/1k5jEYjMJgHBPR1x62oPWY+B+0/Nk+TtyrR2HfyeldID7E+KxvWtYU7PpTlSCAiFWvVQMuxYYEg2EI5+32I3e1oTb2w= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41414+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1558949519842839.5347304011545; Mon, 27 May 2019 02:31:59 -0700 (PDT) Return-Path: X-Received: from mga02.intel.com (mga02.intel.com []) by groups.io with SMTP; Mon, 27 May 2019 02:31:59 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 May 2019 02:31:58 -0700 X-ExtLoop1: 1 X-Received: from pg-nx11.altera.com ([10.104.4.26]) by orsmga008.jf.intel.com with ESMTP; 27 May 2019 02:31:57 -0700 From: "Loh, Tien Hock" To: devel@edk2.groups.io, thloh85@gmail.com Cc: "Tien Hock, Loh" , Leif Lindholm , Ard Biesheuvel Subject: [edk2-devel] [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand polling Date: Mon, 27 May 2019 17:30:27 +0800 Message-Id: <1558949428-190715-7-git-send-email-tien.hock.loh@intel.com> In-Reply-To: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> References: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tien.hock.loh@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1558949519; bh=MsLmil7qFePJnGydeDFc7QNeqCfkwZH+lfc0gTt1wjU=; h=Cc:Date:From:Reply-To:Subject:To; b=wAuYMiXfDJA9p963xThh2XtrIZp+DxahcNEWIgcAm3ytzUmxstkqRVXu/cvxvDEklaz d7vYAs9sz8/3z+kJAHGvogWIikn5znbSfgM3xnk++IhhxnZVgJqAqs0tQq6t1mOK0cIYw DaNF2DIVUTg5tgO88+vPgCvSaI03ujAms3U= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Tien Hock, Loh" Change SendCommand polling mode to remove unnecessary delay, and check for transfer done only when block data is to be read/write. This would also increase performance slightly. Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 43 +++++++++++++++----- 1 file changed, 33 insertions(+), 10 deletions(-) diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Driver= s/DwEmmcDxe/DwEmmcDxe.c index c6c8e04917..b57833458f 100644 --- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c +++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c @@ -286,16 +286,13 @@ SendCommand ( DWEMMC_INT_RCRC | DWEMMC_INT_RE; ErrMask |=3D DWEMMC_INT_DCRC | DWEMMC_INT_DRT | DWEMMC_INT_SBE; do { - MicroSecondDelay(500); Data =3D MmioRead32 (DWEMMC_RINTSTS); - - if (Data & ErrMask) { - return EFI_DEVICE_ERROR; - } - if (Data & DWEMMC_INT_DTO) { // Transfer Done - break; - } } while (!(Data & DWEMMC_INT_CMD_DONE)); + + if (Data & ErrMask) { + return EFI_DEVICE_ERROR; + } + return EFI_SUCCESS; } =20 @@ -550,8 +547,9 @@ DwEmmcReadBlockData ( ) { EFI_STATUS Status; - UINT32 DescPages, CountPerPage, Count; + UINT32 DescPages, CountPerPage, Count, ErrMask; EFI_TPL Tpl; + UINTN Rintsts =3D 0; =20 Tpl =3D gBS->RaiseTPL (TPL_NOTIFY); =20 @@ -574,6 +572,18 @@ DwEmmcReadBlockData ( DEBUG ((DEBUG_ERROR, "Failed to read data, mDwEmmcCommand:%x, mDwEmmcA= rgument:%x, Status:%r\n", mDwEmmcCommand, mDwEmmcArgument, Status)); goto out; } + + while(!((MmioRead32(DWEMMC_RINTSTS) & (DWEMMC_INT_DTO)))) { + Rintsts =3D MmioRead32 (DWEMMC_RINTSTS); + } + ErrMask =3D DWEMMC_INT_EBE | DWEMMC_INT_HLE | DWEMMC_INT_RTO | + DWEMMC_INT_RCRC | DWEMMC_INT_RE | DWEMMC_INT_DCRC | + DWEMMC_INT_DRT | DWEMMC_INT_SBE; + + if (Rintsts & ErrMask) { + Status =3D EFI_DEVICE_ERROR; + goto out; + } out: // Restore Tpl gBS->RestoreTPL (Tpl); @@ -589,8 +599,9 @@ DwEmmcWriteBlockData ( ) { EFI_STATUS Status; - UINT32 DescPages, CountPerPage, Count; + UINT32 DescPages, CountPerPage, Count, ErrMask; EFI_TPL Tpl; + UINTN Rintsts =3D 0; =20 Tpl =3D gBS->RaiseTPL (TPL_NOTIFY); =20 @@ -613,6 +624,18 @@ DwEmmcWriteBlockData ( DEBUG ((DEBUG_ERROR, "Failed to write data, mDwEmmcCommand:%x, mDwEmmc= Argument:%x, Status:%r\n", mDwEmmcCommand, mDwEmmcArgument, Status)); goto out; } + + while(!((MmioRead32(DWEMMC_RINTSTS) & (DWEMMC_INT_DTO)))) { + Rintsts =3D MmioRead32 (DWEMMC_RINTSTS); + } + ErrMask =3D DWEMMC_INT_EBE | DWEMMC_INT_HLE | DWEMMC_INT_RTO | + DWEMMC_INT_RCRC | DWEMMC_INT_RE | DWEMMC_INT_DCRC | + DWEMMC_INT_DRT | DWEMMC_INT_SBE; + + if (Rintsts & ErrMask) { + Status =3D EFI_DEVICE_ERROR; + goto out; + } out: // Restore Tpl gBS->RestoreTPL (Tpl); --=20 2.19.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41414): https://edk2.groups.io/g/devel/message/41414 Mute This Topic: https://groups.io/mt/31807965/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat Feb 7 03:01:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+41415+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41415+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1558949521; cv=none; d=zoho.com; s=zohoarc; b=jy34Dto3OcF0dn8PKKeeQj4T8pTSVEvT+yOw8J2UirmnFafSYP44uQDLKRi7ElRTIlw4rSEnPe3u/hft8DMN8duc+hCKDr/+em6bNE2Ih8tfNZ3Wpxk0Y8Tp875PA1RGgHmEiPlYYEWES0r/0LNI11WK3Kb4ZQ2/ldPcAf7uuxA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558949521; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=RnAPDG/dDllqL8/UPpozbU73sX3njpaueST+teeLwNI=; b=MOMZmLzkXiZjtPtQYhOpnUqB03w7pQ2f4Db9txZYdK971v+F5issWU2iaBqgnmKBMEQo0mk/qnA8dI+oIjw1FbYwdHU82/BPEHNbnhO6luh6iGvpf9s4m1U+vEartZ1SoClX8ChP8d5014LMPMj3LNbHPMUlvTxeR4OpJLew7yU= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41415+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1558949521681534.4078074014162; Mon, 27 May 2019 02:32:01 -0700 (PDT) Return-Path: X-Received: from mga02.intel.com (mga02.intel.com []) by groups.io with SMTP; Mon, 27 May 2019 02:32:01 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 May 2019 02:32:00 -0700 X-ExtLoop1: 1 X-Received: from pg-nx11.altera.com ([10.104.4.26]) by orsmga008.jf.intel.com with ESMTP; 27 May 2019 02:31:59 -0700 From: "Loh, Tien Hock" To: devel@edk2.groups.io, thloh85@gmail.com Cc: "Tien Hock, Loh" , Leif Lindholm , Ard Biesheuvel Subject: [edk2-devel] [PATCH v2 7/7] EmbeddedPkg: Fix DwEmmc read/write size in preparing DMA size Date: Mon, 27 May 2019 17:30:28 +0800 Message-Id: <1558949428-190715-8-git-send-email-tien.hock.loh@intel.com> In-Reply-To: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> References: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tien.hock.loh@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1558949521; bh=9M3KDKoAW9414lOYDi1jasR9/K8gGYValwKghA9NYGo=; h=Cc:Date:From:Reply-To:Subject:To; b=Z+KVhaOY9+wpgOPaqJse4RqQbJVpYtkPvzIkjhqtzV7vlgtXwHmDkpx3VFezUpVSiQS RZp8ufQSYcdurEOO+EBJLXZ676vbUQU8EA4jOZekGGk7mwWPXqMH70h6Lt62Pu8fR+69Q 5A2BNIUQ0HjU7NBI8P4uu/uAfu0zEs/k/yY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Tien Hock, Loh" Add support for reading data that is less than DWEMMC_BLOCK_SIZE, otherwise it would read bigger data than requested and cause errors Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel -- v2: - Fix white space issue --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Driver= s/DwEmmcDxe/DwEmmcDxe.c index b57833458f..ec2fa7923b 100644 --- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c +++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c @@ -493,7 +493,10 @@ PrepareDmaData ( =20 Cnt =3D (Length + DWEMMC_DMA_BUF_SIZE - 1) / DWEMMC_DMA_BUF_SIZE; Blks =3D (Length + DWEMMC_BLOCK_SIZE - 1) / DWEMMC_BLOCK_SIZE; - Length =3D DWEMMC_BLOCK_SIZE * Blks; + + if(Length >=3D DWEMMC_BLOCK_SIZE) { + Length =3D DWEMMC_BLOCK_SIZE * Blks; + } =20 for (Idx =3D 0; Idx < Cnt; Idx++) { (IdmacDesc + Idx)->Des0 =3D DWEMMC_IDMAC_DES0_OWN | DWEMMC_IDMAC_DES0_= CH | @@ -534,8 +537,14 @@ StartDma ( Data |=3D DWEMMC_IDMAC_ENABLE | DWEMMC_IDMAC_FB; MmioWrite32 (DWEMMC_BMOD, Data); =20 - MmioWrite32 (DWEMMC_BLKSIZ, DWEMMC_BLOCK_SIZE); - MmioWrite32 (DWEMMC_BYTCNT, Length); + if(Length < DWEMMC_BLOCK_SIZE) { + MmioWrite32 (DWEMMC_BLKSIZ, Length); + MmioWrite32 (DWEMMC_BYTCNT, Length); + } + else { + MmioWrite32 (DWEMMC_BLKSIZ, DWEMMC_BLOCK_SIZE); + MmioWrite32 (DWEMMC_BYTCNT, Length); + } } =20 EFI_STATUS --=20 2.19.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41415): https://edk2.groups.io/g/devel/message/41415 Mute This Topic: https://groups.io/mt/31807966/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-