From nobody Mon May 6 20:57:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+39940+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39940+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1556854098; cv=none; d=zoho.com; s=zohoarc; b=eDA8w8crxtdbPQs93IJ8NJN4ksRLmj/8FvhWHwcSCH/hvX26QbpKMuG9yiTLHZNW+poGxHlhqgQm5jLDcAeISAvkzY9gME+X1KtBqs9V1f+yga84i8cntQYXA0GWgUVIR7q53/JISnahskaXAVJ6c7LqXRcuv7/3CfeL9V8scsg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556854098; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=/DleFagCg7SwDGyKaK8NASJMAyu7VmMwwNo63aK4zDw=; b=I1fQVpR/dGTPOM6aZrg5BxkEzQEpp0eN9tng8SoP0Yp0PyJqnc6b0hlz7WTAmHx+Vct3EH6IajzJhwRdStop0auX9wvstly21LpNU+tuAoW5hPlD4gqmHhsDbx3UzRdqjg6C0g/5uJBg8771K0fj2/HljtGRmPaB7gEgtPUlQSg= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39940+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1556854098340413.3566675246891; Thu, 2 May 2019 20:28:18 -0700 (PDT) Return-Path: X-Received: from mga14.intel.com (mga14.intel.com []) by groups.io with SMTP; Thu, 02 May 2019 20:28:17 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 20:28:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,424,1549958400"; d="scan'208";a="167124901" X-Received: from pg-iccf0195.altera.com ([10.104.4.90]) by fmsmga002.fm.intel.com with ESMTP; 02 May 2019 20:28:15 -0700 From: "Loh, Tien Hock" To: devel@edk2.groups.io, thloh85@gmail.com Cc: "Tien Hock, Loh" , Leif Lindholm , Ard Biesheuvel Subject: [edk2-devel] [[PATCH v2] 6/7] EmbeddedPkg: Fix DwEmmc driver bugs Date: Fri, 3 May 2019 11:27:02 +0800 Message-Id: <1556854023-5486-7-git-send-email-tien.hock.loh@intel.com> In-Reply-To: <1556854023-5486-1-git-send-email-tien.hock.loh@intel.com> References: <1556854023-5486-1-git-send-email-tien.hock.loh@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tien.hock.loh@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1556854097; bh=/g02dHvO2IJxHlE63kipkgE+fxRZzaYIrYvZ5rL1930=; h=Cc:Date:From:Reply-To:Subject:To; b=JGrFsAOu40Q6K5m/KSGMz2HMkaXGkcvf3VX5NEkkGytzhl+oipNuUEHVr7GsDtoIM8C IYlnZI3r5DinD/lRBCx1Zd3kJx/2GpzBqmauE7u6whFVmamjgt1gM5kqd6mYGVA0Zy1G2 zFd8+YtcfPX+/kYzJOuwdh+X/HnEkXapcwo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Tien Hock, Loh" Do not send CRC response check if the MMC command does not support CRC response Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Driver= s/DwEmmcDxe/DwEmmcDxe.c index a69d9ab..c38b5a4 100644 --- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c +++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c @@ -384,7 +384,7 @@ DwEmmcSendCommand ( BIT_CMD_READ | BIT_CMD_WAIT_PRVDATA_COMPLETE; break; default: - Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC; + Cmd =3D BIT_CMD_RESPONSE_EXPECT; break; } =20 @@ -394,6 +394,11 @@ DwEmmcSendCommand ( mIsACmd =3D TRUE; else mIsACmd =3D FALSE; + + if (!(MmcCmd & MMC_CMD_NO_CRC_RESPONSE)) { + Cmd |=3D BIT_CMD_CHECK_RESPONSE_CRC; + } + if (IsPendingReadCommand (Cmd) || IsPendingWriteCommand (Cmd)) { mDwEmmcCommand =3D Cmd; mDwEmmcArgument =3D Argument; --=20 2.2.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39940): https://edk2.groups.io/g/devel/message/39940 Mute This Topic: https://groups.io/mt/31480082/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-