From nobody Sat Apr 27 10:02:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+39937+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39937+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1556854093; cv=none; d=zoho.com; s=zohoarc; b=I6qowoXBDs1EHI9U9yGGMKE0FxdngrL3RXVJdJYUdVh6znTdhH8T+tmjfCyYCLZbkMGF/XfjEFhIL4WxaKdSLA7MqV4yTxvfIgUkS4TzLJs8UNGT0rW2PO53ixvbJeXv3e//G/kRG7AaPfkV8maZ//y2myXnCmU/QOhp+24Eq3k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556854093; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=tyKfX/QCSb90JU9CHiiGRGSGv8Ry5PBGSsUQ08hl7xY=; b=gg8bSI4W4GqU/7lBiGK8qJABj5u45mQx0KAE3VEkPcTn0ckETjo9rlIE5BdsC6rytSplDn9KXcVejStBBi2ERBz03s6WGzJuXO+PgQb8MRhJtpwknxVhVnwX111amfns6cFQvoehFrlpFKPkduOZjOe+CsB4r6KafaoNRNDttCc= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39937+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1556854093514434.4706185222684; Thu, 2 May 2019 20:28:13 -0700 (PDT) Return-Path: X-Received: from mga14.intel.com (mga14.intel.com []) by groups.io with SMTP; Thu, 02 May 2019 20:28:12 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 20:28:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,424,1549958400"; d="scan'208";a="167124858" X-Received: from pg-iccf0195.altera.com ([10.104.4.90]) by fmsmga002.fm.intel.com with ESMTP; 02 May 2019 20:28:11 -0700 From: "Loh, Tien Hock" To: devel@edk2.groups.io, thloh85@gmail.com Cc: "Tien Hock, Loh" , Leif Lindholm , Ard Biesheuvel Subject: [edk2-devel] [[PATCH v2] 3/7] EmbeddedPkg: Fix DwEmmc driver bugs Date: Fri, 3 May 2019 11:26:59 +0800 Message-Id: <1556854023-5486-4-git-send-email-tien.hock.loh@intel.com> In-Reply-To: <1556854023-5486-1-git-send-email-tien.hock.loh@intel.com> References: <1556854023-5486-1-git-send-email-tien.hock.loh@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tien.hock.loh@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1556854093; bh=OCgdwh/6qcinvRb7Az4PRzX9frIoDlIoftOqh4aZGQ0=; h=Cc:Date:From:Reply-To:Subject:To; b=M8hw2KeDABrniPKqLI/KqJhxGonapOZPYVLKmNR8lQ17idsurWGXjd1ErPilzEmqGZ1 ylJuZiRNCjGVwsj9haK8UrwKMRtScWvxvFHOWmSWrZIIBMS+J2aYJWeTnzxBfJyU6+way K/8qKB+PDeOAsfWrhskT7ZN9FuBeNJj8+hk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Tien Hock, Loh" On CMD8, for SD, the controller should not expect data as this is a SEND_IF_COND command to verify SD operating condition, and does not have data Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 9 ++++++--- EmbeddedPkg/Include/Protocol/MmcHost.h | 1 + EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 2 ++ 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Driver= s/DwEmmcDxe/DwEmmcDxe.c index 058665b..04fdcbf 100644 --- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c +++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c @@ -339,9 +339,12 @@ DwEmmcSendCommand ( Cmd =3D 0; break; case MMC_INDX(8): - Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC | - BIT_CMD_DATA_EXPECTED | BIT_CMD_READ | - BIT_CMD_WAIT_PRVDATA_COMPLETE; + if (!This->IsEmmc) + Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC | + BIT_CMD_WAIT_PRVDATA_COMPLETE ; + else + Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC | + BIT_CMD_WAIT_PRVDATA_COMPLETE | BIT_CMD_READ | BIT_CMD_DATA_E= XPECTED; break; case MMC_INDX(9): Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC | diff --git a/EmbeddedPkg/Include/Protocol/MmcHost.h b/EmbeddedPkg/Include/P= rotocol/MmcHost.h index 9e07082..ae8ea5d 100644 --- a/EmbeddedPkg/Include/Protocol/MmcHost.h +++ b/EmbeddedPkg/Include/Protocol/MmcHost.h @@ -169,6 +169,7 @@ struct _EFI_MMC_HOST_PROTOCOL { MMC_SETIOS SetIos; MMC_ISMULTIBLOCK IsMultiBlock; =20 + BOOLEAN IsEmmc; }; =20 #define MMC_HOST_PROTOCOL_REVISION 0x00010002 // 1.2 diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c b/EmbeddedPkg= /Universal/MmcDxe/MmcIdentification.c index 4dc0be1..fa1eda2 100755 --- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c +++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c @@ -770,8 +770,10 @@ InitializeMmcDevice ( } =20 if (MmcHostInstance->CardInfo.CardType !=3D EMMC_CARD) { + MmcHostInstance->MmcHost->IsEmmc =3D FALSE; Status =3D InitializeSdMmcDevice (MmcHostInstance); } else { + MmcHostInstance->MmcHost->IsEmmc =3D TRUE; Status =3D InitializeEmmcDevice (MmcHostInstance); } if (EFI_ERROR (Status)) { --=20 2.2.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39937): https://edk2.groups.io/g/devel/message/39937 Mute This Topic: https://groups.io/mt/31480079/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-