From nobody Wed May 1 17:18:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+39935+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39935+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1556854085; cv=none; d=zoho.com; s=zohoarc; b=RKJdlCE3DiH7ZO7SlwVm8Oe0NZldEDgraC8W6nII3gAa+eFvl8511NBW+wumoJkti+ZBfoM4Uj86OIhVkNyxZZ7X4PSx4NNYA9vVkJE9mhX5MzUCAjWTxB11+fzRWduayNupQsjPo/Qzb8bB9qQre1iEmZppR2LGEOddW6gStls= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556854085; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=8dP1oAtEPKjBiGLlBN6LJEm0hLpSotLmJ7R90J4y7Js=; b=K7B0dmt1YnAV1FsYf/DN3Di6bUNvwku2Ln+nch0nkSNNmgrB7G4GyX2nBbshfJnwkz1DhpHwOVVh7sEI5g2Vd+PF6YNO9ZPYJXp8HyIZuRtNWD68bUf/rVtS7Is0OoYFCzTEMOKqSrqsrUchpeo7lt4Cr9+FwF3f7TWwmQ1qOkQ= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39935+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1556854085056524.8247116879387; Thu, 2 May 2019 20:28:05 -0700 (PDT) Return-Path: X-Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Thu, 02 May 2019 20:28:04 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 20:28:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,424,1549958400"; d="scan'208";a="167124840" X-Received: from pg-iccf0195.altera.com ([10.104.4.90]) by fmsmga002.fm.intel.com with ESMTP; 02 May 2019 20:28:01 -0700 From: "Loh, Tien Hock" To: devel@edk2.groups.io, thloh85@gmail.com Cc: "Tien Hock, Loh" , Leif Lindholm , Ard Biesheuvel Subject: [edk2-devel] [[PATCH v2] 1/7] EmbeddedPkg: Fix DwEmmc driver bugs Date: Fri, 3 May 2019 11:26:57 +0800 Message-Id: <1556854023-5486-2-git-send-email-tien.hock.loh@intel.com> In-Reply-To: <1556854023-5486-1-git-send-email-tien.hock.loh@intel.com> References: <1556854023-5486-1-git-send-email-tien.hock.loh@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tien.hock.loh@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1556854084; bh=xL8KT+KHSYANzP6rg1jlm3vgasX/b3RjhU+T4SmWmt8=; h=Cc:Date:From:Reply-To:Subject:To; b=F1bac9qNxydIBADrIhtO8JkZ6PMeofrIlSsD2qqq3/M/Y3huAZiUWJT+d1eyi1pJl6x sBVZvu/A/KKOvsYUkwCnEzDuzB+tG+iUPepnMJCrBGJt4k6jqBMcaxWNZYkLWKVKoekJu p+Mty+l7yZ5oEIEMASz6W9bS/M3tHyP1VNk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Tien Hock, Loh" Added ACMD6 for SD support. For SD, after CMD55 is sent, the next command should be an application command, which should not expect data Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Driver= s/DwEmmcDxe/DwEmmcDxe.c index adc6b06..fa24802 100644 --- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c +++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c @@ -39,6 +39,7 @@ DWEMMC_IDMAC_DESCRIPTOR *gpIdmacDesc; EFI_GUID mDwEmmcDevicePathGuid =3D EFI_CALLER_ID_GUID; STATIC UINT32 mDwEmmcCommand; STATIC UINT32 mDwEmmcArgument; +STATIC BOOLEAN mIsACmd =3D FALSE; =20 EFI_STATUS DwEmmcReadBlockData ( @@ -321,6 +322,15 @@ DwEmmcSendCommand ( Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC | BIT_CMD_SEND_INIT; break; + case MMC_INDX(6): + if(mIsACmd) { + Cmd =3D BIT_CMD_RESPONSE_EXPECT ; + } + else { + Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_DATA_EXPECTED | + BIT_CMD_READ; + } + break; case MMC_INDX(7): if (Argument) Cmd =3D BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC; @@ -371,6 +381,11 @@ DwEmmcSendCommand ( } =20 Cmd |=3D MMC_GET_INDX(MmcCmd) | BIT_CMD_USE_HOLD_REG | BIT_CMD_START; + + if(MMC_INDX(55) =3D=3D MMC_GET_INDX(MmcCmd)) + mIsACmd =3D TRUE; + else + mIsACmd =3D FALSE; if (IsPendingReadCommand (Cmd) || IsPendingWriteCommand (Cmd)) { mDwEmmcCommand =3D Cmd; mDwEmmcArgument =3D Argument; --=20 2.2.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39935): https://edk2.groups.io/g/devel/message/39935 Mute This Topic: https://groups.io/mt/31480077/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-