From nobody Fri Nov 1 08:16:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1521020055695212.27027795713718; Wed, 14 Mar 2018 02:34:15 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 48660225892C4; Wed, 14 Mar 2018 02:27:47 -0700 (PDT) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 70C4D21E49037 for ; Wed, 14 Mar 2018 02:27:44 -0700 (PDT) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2018 02:34:07 -0700 Received: from shwdeopenpsi068.ccr.corp.intel.com ([10.239.158.46]) by orsmga007.jf.intel.com with ESMTP; 14 Mar 2018 02:34:06 -0700 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,469,1515484800"; d="scan'208";a="24534672" From: Star Zeng To: edk2-devel@lists.01.org Date: Wed, 14 Mar 2018 17:33:57 +0800 Message-Id: <1521020038-102684-6-git-send-email-star.zeng@intel.com> X-Mailer: git-send-email 2.7.0.windows.1 In-Reply-To: <1521020038-102684-1-git-send-email-star.zeng@intel.com> References: <1521020038-102684-1-git-send-email-star.zeng@intel.com> Subject: [edk2] [PATCH V2 5/6] SourceLevelDebugPkg DebugCommUsb3: Refine some formats/comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ruiyu Ni , Hao Wu , Star Zeng MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Refine some formats/comments and remove some unused prototypes. Cc: Ruiyu Ni Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- .../DebugCommunicationLibUsb3Common.c | 16 ++++---- .../DebugCommunicationLibUsb3Internal.h | 47 +++---------------= ---- 2 files changed, 13 insertions(+), 50 deletions(-) diff --git a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom= municationLibUsb3Common.c b/SourceLevelDebugPkg/Library/DebugCommunicationL= ibUsb3/DebugCommunicationLibUsb3Common.c index 3b0f81cf88fd..37f49ad822f5 100644 --- a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicat= ionLibUsb3Common.c +++ b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicat= ionLibUsb3Common.c @@ -85,15 +85,15 @@ XhcClearR32Bit( Write the data to the XHCI debug register. =20 @param Handle Debug port handle. - @param Offset The offset of the runtime register. + @param Offset The offset of the debug register. @param Data The data to write. =20 **/ VOID XhcWriteDebugReg ( IN USB3_DEBUG_PORT_HANDLE *Handle, - IN UINT32 Offset, - IN UINT32 Data + IN UINT32 Offset, + IN UINT32 Data ) { EFI_PHYSICAL_ADDRESS DebugCapabilityBase; @@ -116,7 +116,7 @@ XhcWriteDebugReg ( UINT32 XhcReadDebugReg ( IN USB3_DEBUG_PORT_HANDLE *Handle, - IN UINT32 Offset + IN UINT32 Offset ) { UINT32 Data; @@ -129,16 +129,16 @@ XhcReadDebugReg ( } =20 /** - Set one bit of the runtime register while keeping other bits. + Set one bit of the debug register while keeping other bits. =20 @param Handle Debug port handle. - @param Offset The offset of the runtime register. + @param Offset The offset of the debug register. @param Bit The bit mask of the register to set. =20 **/ VOID XhcSetDebugRegBit ( - IN USB3_DEBUG_PORT_HANDLE *Handle, + IN USB3_DEBUG_PORT_HANDLE *Handle, IN UINT32 Offset, IN UINT32 Bit ) @@ -216,7 +216,7 @@ UpdateXhcResource ( =20 @param Handle Debug port handle. =20 - @retval RETURN_UNSUPPORTED The usb host controller does not supported us= b debug port capability. + @retval RETURN_UNSUPPORTED The usb host controller does not support usb = debug port capability. @retval RETURN_SUCCESS Get bar and offset successfully. =20 **/ diff --git a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom= municationLibUsb3Internal.h b/SourceLevelDebugPkg/Library/DebugCommunicatio= nLibUsb3/DebugCommunicationLibUsb3Internal.h index 356485c5f697..9da49f964401 100644 --- a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicat= ionLibUsb3Internal.h +++ b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicat= ionLibUsb3Internal.h @@ -1,7 +1,7 @@ /** @file Debug Port Library implementation based on usb3 debug port. =20 - Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.
+ Copyright (c) 2014 - 2018, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BS= D License which accompanies this distribution. The full text of the license may b= e found at @@ -540,7 +540,7 @@ typedef struct _USB3_DEBUG_PORT_INSTANCE { UINT32 XhcReadDebugReg ( IN USB3_DEBUG_PORT_HANDLE *Handle, - IN UINT32 Offset + IN UINT32 Offset ); =20 /** @@ -554,8 +554,8 @@ XhcReadDebugReg ( VOID XhcSetDebugRegBit ( IN USB3_DEBUG_PORT_HANDLE *Handle, - IN UINT32 Offset, - IN UINT32 Bit + IN UINT32 Offset, + IN UINT32 Bit ); =20 /** @@ -574,43 +574,6 @@ XhcWriteDebugReg ( ); =20 /** - Discover the USB3 debug device. - =20 - @param Handle Debug port handle. - =20 - @retval RETURN_SUCCESS The serial device was initialized. - @retval RETURN_DEVICE_ERROR The serial device could not be initialized. - -**/ -RETURN_STATUS -DiscoverUsb3DebugPort( - USB3_DEBUG_PORT_HANDLE *Handle - ); - =20 -/** - Initialize the Serial Device hardware. - =20 - @param Handle Debug port handle. - - @retval RETURN_SUCCESS The serial device was initialized successfully. - @retval !RETURN_SUCCESS Error. - -**/ -RETURN_STATUS -InitializeUsb3DebugPort ( - USB3_DEBUG_PORT_HANDLE *Handle - ); - -/** - Return XHCI MMIO base address. - -**/ -EFI_PHYSICAL_ADDRESS -GetXhciBaseAddress ( - VOID - ); - -/** Verifies if the bit positions specified by a mask are set in a register. =20 @param[in, out] Register UNITN register @@ -728,4 +691,4 @@ XhcDataTransfer ( IN UINTN Timeout ); =20 -#endif //__SERIAL_PORT_LIB_USB__ +#endif //__USB3_DEBUG_PORT_LIB_INTERNAL__ --=20 2.7.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel