From nobody Mon Apr 29 18:48:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1515666016202191.0139645547605; Thu, 11 Jan 2018 02:20:16 -0800 (PST) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 5E6B42205B918; Thu, 11 Jan 2018 02:15:01 -0800 (PST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CE9DC2205B907 for ; Thu, 11 Jan 2018 02:14:59 -0800 (PST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2018 02:20:13 -0800 Received: from fanwang2-hp.ccr.corp.intel.com ([10.239.9.33]) by orsmga005.jf.intel.com with ESMTP; 11 Jan 2018 02:20:11 -0800 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=fan.wang@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,343,1511856000"; d="scan'208";a="192828324" From: Wang Fan To: edk2-devel@lists.01.org Date: Thu, 11 Jan 2018 18:20:06 +0800 Message-Id: <1515666006-5488-1-git-send-email-fan.wang@intel.com> X-Mailer: git-send-email 1.9.5.msysgit.1 Subject: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Add an independent timer for reconfig checking X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ye Ting , Fu Siyuan , Jiaxin Wu MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" * Since wireless network can switch at very short time, the time interval of reconfig event checking is too long for this case. To achieve better performance and scalability, separate this task from Ip4 tick timer. Cc: Jiaxin Wu Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wang Fan Reviewed-by: Fu Siyuan Reviewed-by: Jiaxin Wu --- MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Driver.c | 28 +++++++++++++- MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c | 47 +++++++++++++++----= ---- MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.h | 30 ++++++++++++--- 3 files changed, 83 insertions(+), 22 deletions(-) diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Driver.c b/MdeModuleP= kg/Universal/Network/Ip4Dxe/Ip4Driver.c index 49b7dc5..552c4e1 100644 --- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Driver.c +++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Driver.c @@ -1,9 +1,9 @@ /** @file The driver binding and service binding protocol for IP4 driver. =20 -Copyright (c) 2005 - 2017, Intel Corporation. All rights reserved.
+Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.
(C) Copyright 2015 Hewlett-Packard Development Company, L.P.
=20 This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD = License which accompanies this distribution. The full text of the license may be = found at @@ -251,10 +251,11 @@ Ip4CreateService ( IpSb->MnpConfigData.DisableBackgroundPolling =3D FALSE; =20 ZeroMem (&IpSb->SnpMode, sizeof (EFI_SIMPLE_NETWORK_MODE)); =20 IpSb->Timer =3D NULL; + IpSb->ReconfigCheckTimer =3D NULL; =20 IpSb->ReconfigEvent =3D NULL; =20 IpSb->Reconfig =3D FALSE; =20 @@ -283,10 +284,22 @@ Ip4CreateService ( if (EFI_ERROR (Status)) { goto ON_ERROR; } =20 Status =3D gBS->CreateEvent ( + EVT_NOTIFY_SIGNAL | EVT_TIMER, + TPL_CALLBACK, + Ip4TimerReconfigChecking, + IpSb, + &IpSb->ReconfigCheckTimer + ); + + if (EFI_ERROR (Status)) { + goto ON_ERROR; + } + + Status =3D gBS->CreateEvent ( EVT_NOTIFY_SIGNAL, TPL_NOTIFY, Ip4AutoReconfigCallBack, IpSb, &IpSb->ReconfigEvent @@ -408,10 +421,17 @@ Ip4CleanService ( gBS->CloseEvent (IpSb->Timer); =20 IpSb->Timer =3D NULL; } =20 + if (IpSb->ReconfigCheckTimer !=3D NULL) { + gBS->SetTimer (IpSb->ReconfigCheckTimer, TimerCancel, 0); + gBS->CloseEvent (IpSb->ReconfigCheckTimer); + + IpSb->ReconfigCheckTimer =3D NULL; + } + if (IpSb->DefaultInterface !=3D NULL) { Status =3D Ip4FreeInterface (IpSb->DefaultInterface, NULL); =20 if (EFI_ERROR (Status)) { return Status; @@ -628,10 +648,16 @@ Ip4DriverBindingStart ( =20 if (EFI_ERROR (Status)) { goto UNINSTALL_PROTOCOL; } =20 + Status =3D gBS->SetTimer (IpSb->ReconfigCheckTimer, TimerPeriodic, 500 *= TICKS_PER_MS); + + if (EFI_ERROR (Status)) { + goto UNINSTALL_PROTOCOL; + } + // // Initialize the IP4 ID // mIp4Id =3D (UINT16)NET_RANDOM (NetRandomInitSeed ()); =20 diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c b/MdeModulePkg= /Universal/Network/Ip4Dxe/Ip4Impl.c index ac48ad2..b5cd7b7 100644 --- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c +++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c @@ -1,8 +1,8 @@ /** @file =20 -Copyright (c) 2005 - 2017, Intel Corporation. All rights reserved.
+Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD = License which accompanies this distribution. The full text of the license may be = found at http://opensource.org/licenses/bsd-license.php =20 @@ -2247,22 +2247,14 @@ Ip4SentPacketTicking ( } =20 return EFI_SUCCESS; } =20 - /** - There are two steps for this the heart beat timer of IP4 service instanc= e.=20 - First, it times out all of its IP4 children's received-but-not-delivered=20 - and transmitted-but-not-recycle packets, and provides time input for its=20 - IGMP protocol. - Second, a dedicated timer is used to poll underlying media status. In ca= se=20 - of cable swap, a new round auto configuration will be initiated. The tim= er=20 - will signal the IP4 to run DHCP configuration again. IP4 driver will free - old IP address related resource, such as route table and Interface, then - initiate a DHCP process to acquire new IP, eventually create route table=20 - for new IP address. + This heart beat timer of IP4 service instance times out all of its IP4 c= hildren's=20 + received-but-not-delivered and transmitted-but-not-recycle packets, and = provides=20 + time input for its IGMP protocol. =20 @param[in] Event The IP4 service instance's heart beat= timer. @param[in] Context The IP4 service instance. =20 **/ @@ -2272,22 +2264,47 @@ Ip4TimerTicking ( IN EFI_EVENT Event, IN VOID *Context ) { IP4_SERVICE *IpSb; + + IpSb =3D (IP4_SERVICE *) Context; + NET_CHECK_SIGNATURE (IpSb, IP4_SERVICE_SIGNATURE); + =20 + Ip4PacketTimerTicking (IpSb); + Ip4IgmpTicking (IpSb); +} + +/** + This dedicated timer is used to poll underlying network media status. In= case=20 + of cable swap or wireless network switch, a new round auto configuration= will=20 + be initiated. The timer will signal the IP4 to run DHCP configuration ag= ain.=20 + IP4 driver will free old IP address related resource, such as route tabl= e and=20 + Interface, then initiate a DHCP process to acquire new IP, eventually cr= eate=20 + route table for new IP address. + + @param[in] Event The IP4 service instance's heart beat= timer. + @param[in] Context The IP4 service instance. + +**/ +VOID +EFIAPI +Ip4TimerReconfigChecking ( + IN EFI_EVENT Event, + IN VOID *Context + ) +{ + IP4_SERVICE *IpSb; BOOLEAN OldMediaPresent; EFI_STATUS Status; EFI_SIMPLE_NETWORK_MODE SnpModeData; =20 IpSb =3D (IP4_SERVICE *) Context; NET_CHECK_SIGNATURE (IpSb, IP4_SERVICE_SIGNATURE); =20 OldMediaPresent =3D IpSb->MediaPresent; =20 - Ip4PacketTimerTicking (IpSb); - Ip4IgmpTicking (IpSb); - // // Get fresh mode data from MNP, since underlying media status may chang= e.=20 // Here, it needs to mention that the MediaPresent can also be checked e= ven if=20 // EFI_NOT_STARTED returned while this MNP child driver instance isn't c= onfigured. // diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.h b/MdeModulePkg= /Universal/Network/Ip4Dxe/Ip4Impl.h index f6b4047..8bdc39a 100644 --- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.h +++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.h @@ -1,9 +1,9 @@ /** @file Ip4 internal functions and type defintions. =20 -Copyright (c) 2005 - 2017, Intel Corporation. All rights reserved.
+Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.
(C) Copyright 2015 Hewlett-Packard Development Company, L.P.
=20 This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD = License which accompanies this distribution. The full text of the license may be = found at @@ -204,11 +204,11 @@ struct _IP4_SERVICE { =20 EFI_MANAGED_NETWORK_CONFIG_DATA MnpConfigData; EFI_SIMPLE_NETWORK_MODE SnpMode; =20 EFI_EVENT Timer; - + EFI_EVENT ReconfigCheckTimer; EFI_EVENT ReconfigEvent; =20 BOOLEAN Reconfig; =20 // @@ -332,14 +332,13 @@ Ip4Groups ( IN BOOLEAN JoinFlag, IN EFI_IPv4_ADDRESS *GroupAddress OPTIONAL ); =20 /** - The heart beat timer of IP4 service instance. It times out - all of its IP4 children's received-but-not-delivered and - transmitted-but-not-recycle packets, and provides time input - for its IGMP protocol. + This heart beat timer of IP4 service instance times out all of its IP4 c= hildren's=20 + received-but-not-delivered and transmitted-but-not-recycle packets, and = provides=20 + time input for its IGMP protocol. =20 @param[in] Event The IP4 service instance's heart beat= timer. @param[in] Context The IP4 service instance. =20 **/ @@ -349,10 +348,29 @@ Ip4TimerTicking ( IN EFI_EVENT Event, IN VOID *Context ); =20 /** + This dedicated timer is used to poll underlying network media status. In= case=20 + of cable swap or wireless network switch, a new round auto configuration= will=20 + be initiated. The timer will signal the IP4 to run DHCP configuration ag= ain.=20 + IP4 driver will free old IP address related resource, such as route tabl= e and=20 + Interface, then initiate a DHCP process to acquire new IP, eventually cr= eate=20 + route table for new IP address. + + @param[in] Event The IP4 service instance's heart beat= timer. + @param[in] Context The IP4 service instance. + +**/ +VOID +EFIAPI +Ip4TimerReconfigChecking ( + IN EFI_EVENT Event, + IN VOID *Context + ); + +/** Decrease the life of the transmitted packets. If it is decreased to zero, cancel the packet. This function is called by Ip4PacketTimerTicking which time out both the received-but-not-delivered and transmitted-but-not-recycle packets. --=20 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel