From nobody Mon Apr 29 09:28:17 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1504227060164640.5033938347043; Thu, 31 Aug 2017 17:51:00 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id A221A21E49BD9; Thu, 31 Aug 2017 17:48:13 -0700 (PDT) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6492D20958BC2 for ; Thu, 31 Aug 2017 17:48:12 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP; 31 Aug 2017 17:50:56 -0700 Received: from jiaxinwu-mobl2.ccr.corp.intel.com ([10.239.196.85]) by fmsmga006.fm.intel.com with ESMTP; 31 Aug 2017 17:50:54 -0700 X-Original-To: edk2-devel@lists.01.org X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,456,1498546800"; d="scan'208";a="146925250" From: Jiaxin Wu To: edk2-devel@lists.01.org Date: Fri, 1 Sep 2017 08:50:52 +0800 Message-Id: <1504227052-64748-1-git-send-email-jiaxin.wu@intel.com> X-Mailer: git-send-email 1.9.5.msysgit.1 Subject: [edk2] [Patch] NetworkPkg/IScsiDxe: Fix the incorrect max length of IP_ADDRESS. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ye Ting , Fu Siyuan , Wu Jiaxin MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" When creating the ISCSI string OpCode for IP_ADDRESS, the max length should be IP(4)_STR_MAX_SIZE instead of IP(4)_MAX_SIZE. Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin Reviewed-by: Fu Siyuan --- NetworkPkg/IScsiDxe/IScsiMisc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMis= c.c index e20fe91..efd05cf 100644 --- a/NetworkPkg/IScsiDxe/IScsiMisc.c +++ b/NetworkPkg/IScsiDxe/IScsiMisc.c @@ -1007,11 +1007,11 @@ IScsiCreateKeywords ( StringToken, StringToken, 0, 0, IP4_MIN_SIZE, - IP4_MAX_SIZE, + IP4_STR_MAX_SIZE, NULL ); =20 // // Create iSCSIInitiatorNetmask Keyword. @@ -1033,11 +1033,11 @@ IScsiCreateKeywords ( StringToken, StringToken, 0, 0, IP4_MIN_SIZE, - IP4_MAX_SIZE, + IP4_STR_MAX_SIZE, NULL ); =20 // // Create iSCSIInitiatorGateway Keyword. @@ -1059,11 +1059,11 @@ IScsiCreateKeywords ( StringToken, StringToken, 0, 0, IP4_MIN_SIZE, - IP4_MAX_SIZE, + IP4_STR_MAX_SIZE, NULL ); =20 // // Create iSCSITargetInfoViaDHCP Keyword. @@ -1165,11 +1165,11 @@ IScsiCreateKeywords ( StringToken, StringToken, 0, 0, IP_MIN_SIZE, - IP_MAX_SIZE, + IP_STR_MAX_SIZE, NULL ); =20 // // Create iSCSILUN Keyword. --=20 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel