From nobody Fri Apr 26 14:37:24 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zoho.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1488269857084240.43743528095263; Tue, 28 Feb 2017 00:17:37 -0800 (PST) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id D8BAB81EE0; Tue, 28 Feb 2017 00:17:35 -0800 (PST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BDFBA81EA5 for ; Tue, 28 Feb 2017 00:17:34 -0800 (PST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 28 Feb 2017 00:17:34 -0800 Received: from shwdeopenpsi114.ccr.corp.intel.com ([10.239.157.135]) by orsmga003.jf.intel.com with ESMTP; 28 Feb 2017 00:17:33 -0800 X-Original-To: edk2-devel@lists.01.org X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,218,1484035200"; d="scan'208";a="938880550" From: Dandan Bi To: edk2-devel@lists.01.org Date: Tue, 28 Feb 2017 16:17:20 +0800 Message-Id: <1488269840-32256-1-git-send-email-dandan.bi@intel.com> X-Mailer: git-send-email 1.9.5.msysgit.1 Subject: [edk2] [patch] MdeModulePkg: Fix coding style issues X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiewen Yao MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" 1. Make function comments align with the function. 2. Change the FILE_GUID value in SmmSmiHandlerProfileLib.inf since it is duplicated with the FILE_GUID value in SmiHandlerProfileLibNull.inf 3. Add missing PCD PROMPT&HELP string to uni file. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: jiewen.yao@intel.com --- .../SmiHandlerProfileInfo/SmiHandlerProfileInfo.c | 2 +- .../SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf | 2 +- MdeModulePkg/MdeModulePkg.uni | 14 ++++++++++= ++++ 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfi= leInfo.c b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfile= Info.c index 00cab0c..84a1c8e 100644 --- a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c +++ b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c @@ -243,11 +243,11 @@ GetShortPdbFileName ( The following methods will be tried orderly: 1. Image PDB 2. FFS UI section 3. Image GUID =20 - @param[in] DriverInfo Pointer to memory profile driver info. + @param[in] ImageStruct Point to the image structure. =20 @return The resulting Ascii name string is stored in the mNameString glo= bal array. =20 **/ CHAR8 * diff --git a/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProf= ileLib.inf b/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProf= ileLib.inf index 0c1ad7e..ba0d65e 100644 --- a/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.= inf +++ b/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.= inf @@ -17,11 +17,11 @@ =20 [Defines] INF_VERSION =3D 0x00010005 BASE_NAME =3D SmmSmiHandlerProfileLib MODULE_UNI_FILE =3D SmmSmiHandlerProfileLib.uni - FILE_GUID =3D B43D1B52-6251-4E6F-82EC-A599A5EE94C1 + FILE_GUID =3D FC38CEAE-FB74-4049-A51C-68F0BA69DA7D MODULE_TYPE =3D DXE_SMM_DRIVER VERSION_STRING =3D 1.0 LIBRARY_CLASS =3D SmiHandlerProfileLib|DXE_SMM_DRIVER CONSTRUCTOR =3D SmmSmiHandlerProfileLibConstructor =20 diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni index 5436b60..ff0d697 100644 --- a/MdeModulePkg/MdeModulePkg.uni +++ b/MdeModulePkg/MdeModulePkg.uni @@ -1073,5 +1073,19 @@ =20 #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTestKeyUsed_PROMPT #languag= e en-US "If there is any test key used by the platform." =20 #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTestKeyUsed_HELP #language = en-US "This dynamic PCD holds the information if there is any test key used= by the platform." =20 +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSmiHandlerProfilePropertyMas= k_PROMPT #language en-US "SmiHandlerProfile Property." + +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSmiHandlerProfilePropertyMas= k_HELP #language en-US "The mask is used to control SmiHandlerProfile beha= vior.

\n" + = "BIT0 - Enable SmiHandlerProfile.
" + +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdImageProtectionPolicy_PROMPT= #language en-US "Set image protection policy." + +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdImageProtectionPolicy_HELP = #language en-US "Set image protection policy. The policy is bitwise.\n" + = "If a bit is set, the image will be protected by DxeCore if= it is aligned.\n" + = "The code section becomes read-only, and the data section b= ecomes non-executable.\n" + = "If a bit is clear, the image will not be protected.
\n" + = "BIT0 - Image from unknown device.
\n" + = "BIT1 - Image from firmware volume.
" + --=20 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel