From nobody Mon Feb 9 04:08:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+88121+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88121+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1648455024; cv=none; d=zohomail.com; s=zohoarc; b=QgiVhqm6xVEUozlmUZC5+lRx15PFf8fr6qlSAq5yiPflvq0Fdd/SRDCkZ3021+EBFdyUfBsKGu/zFO/5fdv23Uwb+U4Dk6bU/pBVsMjA4awEYePPAIWjqOEx1nPEGOo0Czq+lY8uxJAHIT1rJZunaFYUVkJ2gX11bhPQuMC+0kk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1648455024; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=dHjIcU8e4G+p3P0jGf+TpWdHragxj1u77pBUIbiBDQo=; b=i5rXW8OjXEorgr47v9vSceskQ619dm1BAgigscoBQ5EwzJ06Ugsdgu6+bXwQ8U4N1/yzeRIpstogCQdJWXwLCdm6axeIRvgTTlwQo0yGww4QzuA4P+p25B2c/tHe0Rk9/s8Oe4Zdmd5yAvyfTZQEGaFlwdKpyFSoYyys+FxDBMw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88121+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1648455024049140.64904943111515; Mon, 28 Mar 2022 01:10:24 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id PPMWYY1788612xgbeGguo8O2; Mon, 28 Mar 2022 01:10:23 -0700 X-Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.8487.1648455017030517745 for ; Mon, 28 Mar 2022 01:10:22 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10299"; a="257771244" X-IronPort-AV: E=Sophos;i="5.90,216,1643702400"; d="scan'208";a="257771244" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2022 01:10:22 -0700 X-IronPort-AV: E=Sophos;i="5.90,216,1643702400"; d="scan'208";a="563428230" X-Received: from mxu9-mobl1.ccr.corp.intel.com ([10.249.175.167]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2022 01:10:19 -0700 From: "Min Xu" To: devel@edk2.groups.io Cc: Min Xu , Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky , Gerd Hoffmann Subject: [edk2-devel] [PATCH V11 32/47] OvmfPkg/Sec: Declare local variable as volatile in SecCoreStartupWithStack Date: Mon, 28 Mar 2022 16:08:11 +0800 Message-Id: <1053f628e92d43f147b27fd637768ad894c9b935.1648454441.git.min.m.xu@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,min.m.xu@intel.com X-Gm-Message-State: uXehrPYeeLYXloS2FCwu60hZx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1648455023; bh=/HYxNnQskcwt6Wuq+T2C3hJpPzUrufUtw1O/gKxSwmY=; h=Cc:Date:From:Reply-To:Subject:To; b=e3FQTXf8iUn8hvMxtMpKUFY0RMY/LEq3WhoSwhyNc7xtgiG83fozINaw17U2xhu9gKS u4JbSeN7iBt1zvrKFu/JVLFfDYUbpoj9kY7keRx3FdikdWf1M1b0s43ri4yQ1/iwMMayZ d5eysWWgjcH2syRSROI25stDjagEsgEnAbQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1648455025936100011 Content-Type: text/plain; charset="utf-8" RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3429 Declare the local variables in SecCoreStartupWithStack that actually move the data elements as volatile to prevent the optimizer from replacing this function with the intrinsic memcpy(). Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann Signed-off-by: Min Xu --- OvmfPkg/Sec/SecMain.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/Sec/SecMain.c b/OvmfPkg/Sec/SecMain.c index 2c5561661ef3..02520e25ab9a 100644 --- a/OvmfPkg/Sec/SecMain.c +++ b/OvmfPkg/Sec/SecMain.c @@ -757,12 +757,17 @@ SecCoreStartupWithStack ( // IdtTableInStack.PeiService =3D NULL; for (Index =3D 0; Index < SEC_IDT_ENTRY_COUNT; Index++) { - UINT8 *Src; - UINT8 *Dst; - UINTN Byte; + // + // Declare the local variables that actually move the data elements as + // volatile to prevent the optimizer from replacing this function with + // the intrinsic memcpy() + // + CONST UINT8 *Src; + volatile UINT8 *Dst; + UINTN Byte; =20 - Src =3D (UINT8 *)&mIdtEntryTemplate; - Dst =3D (UINT8 *)&IdtTableInStack.IdtTable[Index]; + Src =3D (CONST UINT8 *)&mIdtEntryTemplate; + Dst =3D (volatile UINT8 *)&IdtTableInStack.IdtTable[Index]; for (Byte =3D 0; Byte < sizeof (mIdtEntryTemplate); Byte++) { Dst[Byte] =3D Src[Byte]; } --=20 2.29.2.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88121): https://edk2.groups.io/g/devel/message/88121 Mute This Topic: https://groups.io/mt/90080009/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-