From nobody Tue May 14 17:49:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+111231+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 170001837083566.08651165905451; Tue, 14 Nov 2023 19:19:30 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=idmTn0P0lhT5iDGcENr1RRNz7XM7VLZp0szujuV7wlU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1700018366; v=1; b=rAYYXTrlnmGY0wNMaSm7qja1P2uN9Y/rtrGV9XX6LCkWN+2YrGIaP19AJ0pqSQMdWJh8mhdR 5/qI+cqdWoPUSSY7b/jUVzFmeM5iqG7FHbZXn+OHRol3UJ+ve+9+jOHWF0CoQiszwjZhYxsvK4U uOFl/ttbExjVxe/4AYEi2dp8= X-Received: by 127.0.0.2 with SMTP id qmRTYY1788612xmENa4kC80w; Tue, 14 Nov 2023 19:19:26 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.65]) by mx.groups.io with SMTP id smtpd.web10.4911.1700018365055117893 for ; Tue, 14 Nov 2023 19:19:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c81XhhCaXk7HuvsXsqvQ93dMbWhFOE0mE2Wvnap4ZWY9IhYfpWuyvfo/rjXgClDeeZQ5jGqexxvmIWXFiJoE7aNbUjZ1R0Tg7iJ7Ofr2dyczsUeEEy23IraL+jlGk9UHclOgGpjN+MUcElQwmMHrAcw+9/4ekiTr1HzSt/uQKUctHBp4A19DDZou5FRnINoC/iOCUuM6iKu9g2CMH1MF8cQB3b2rsVOw7o4m2nVuv4fygv4G3H9mGsxSWQhas5MP0QzJOA6jUzva7va4ePDSu6Roslbk43MfaDSKpUzy4evHW0a9l7ShZ/YZgblJwGtDWAmCSitXDriyGuB9kUEHbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dHnytOexzcp7iMt6nUQ+R6G6PXZKASVeriJ6URSOdOM=; b=f0tULUsH9cLBF75FjITzlJN6TN20085ifaUnEWHf9aIPwoXBhvXP4E4AnldG1Ksk8tI4Uv/mUxfXh5J/n7lMprUs1ja0mlc76TROGWn6AGGz20/LbGKdFcWx5k8zY037zoyiGo6cI5Ju7T5NYQ9HySZexpS8NT3TZekGgT04uDFM9fAmgH0fti4U0Q3rcRZ8OchmUPXZtF72gcHc/wIln3kpTyqS+wD+ybNO/qiaQAaE9J+eIZg8txIR9y6mJSSKTJw7QkWqresf5KmKko1EFMUn61wXeZUzHQmRhAH0O5QUFI+LciHQiB8NnmwLOc22PuSzvxJOUUfv8nEQbZdY6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) X-Received: from CH2PR18CA0008.namprd18.prod.outlook.com (2603:10b6:610:4f::18) by MN2PR12MB4373.namprd12.prod.outlook.com (2603:10b6:208:261::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.18; Wed, 15 Nov 2023 03:19:22 +0000 X-Received: from DS2PEPF0000343C.namprd02.prod.outlook.com (2603:10b6:610:4f:cafe::a3) by CH2PR18CA0008.outlook.office365.com (2603:10b6:610:4f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.31 via Frontend Transport; Wed, 15 Nov 2023 03:19:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+111231+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.118.232) by DS2PEPF0000343C.mail.protection.outlook.com (10.167.18.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.20 via Frontend Transport; Wed, 15 Nov 2023 03:19:21 +0000 X-Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 14 Nov 2023 19:19:07 -0800 X-Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 14 Nov 2023 19:19:06 -0800 X-Received: from ashishsingha-lnx.nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.986.41 via Frontend Transport; Tue, 14 Nov 2023 19:19:06 -0800 From: "Ashish Singhal via groups.io" To: , , , , CC: Ashish Singhal Subject: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation Date: Tue, 14 Nov 2023 20:19:04 -0700 Message-ID: <0dfe6159ce24094f914dbe340a5656b95895b808.1700018266.git.ashishsingha@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF0000343C:EE_|MN2PR12MB4373:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c8c6425-5408-4a4e-afdb-08dbe589a965 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: yAtneWLg/BE+FJtzawbs72X2GMBRNXAN4nDmbLboXciqHRKeWEYKLxR/zdQnPHy/YiulJ+fxg3p4dl4YwdItrLqKfet3vOtuw0T1vsP59qtk/WBm5KqcFj75zB9uMM0MnHsolXirlI1HkIZ149xLXAH+1uCTnO/MMOoJa/oA7HSeYJYeot40dsFcHJfDRtp2XudyAAt5mKE7wOXvF//c2qNJeD6+2+e2NN0PP5fx8dUqr4cWARyxEfWtUUf06ZZFOPbREHdaUymDySD65a4qpO9HCc+qb+ewwUwqO4F1JJvuJv41BJlEWgLtzAYnPrR9WPYMGLIpCrOPq30SYd8297vnGhcD3S8CzmQGew33iR9lYKPV6gEknbBSqRlS3sRp1XZvuAtShab7DMkrIta18DfyHokSkC4GjnAW6Ds8umJrtC4J1rin8hwCBiSLuUEVsO2QzdfeRLuDE8GK2c6u3KfBRNuhtJza2RyEKShKQeYkxnkqAk9G2Z5EGJpk9/LISM8i46Y2T3ppF+FOZ0I5UIFsyXCO83jkigfHUo4Wd6/9tWdowXoCkJtHvHv2Yqwfmp9dr/ijh/cc9NS80B1N3DNrUXp88RGq7IkWfAxxaltXC636NlWJ026e95VyJrjomtaJ8HTzJrhO+uUpEiSgeDVvr8cD9utlUED5ss/sTDtMfcCOtJJiYuKErnP5Ez6uKrAl1Phi6ieqgIAJ/WZVXSfsS/iMgZMgS5r9fGrQzgNKWGqRQAxJ997oZyX3YO2i X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 03:19:21.6944 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c8c6425-5408-4a4e-afdb-08dbe589a965 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF0000343C.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4373 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ashishsingha@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8X4IQ8btISxmtYE7adaN6W0zx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1700018372473100001 Content-Type: text/plain; charset="utf-8" Just like CPU _UID, ETE UID also needs to be unique so use AcpiProcessorUid instead of CpuName Signed-off-by: Ashish Singhal Reviewed-by: Sami Mujawar --- .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/Ss= dtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTop= ologyLibArm/SsdtCpuTopologyGenerator.c index 8228c7845a..724f33c660 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTo= pologyGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTo= pologyGenerator.c @@ -359,6 +359,7 @@ CreateAmlCpcNode ( =20 @param [in] Generator The SSDT Cpu Topology generator. @param [in] ParentNode Parent node to attach the Cpu node to. + @param [in] GicCInfo CM_ARM_GICC_INFO object used to create the nod= e. @param [in] CpuName Value used to generate the node name. @param [out] EtNodePtr If not NULL, return the created Cpu node. =20 @@ -372,6 +373,7 @@ EFIAPI CreateAmlEtd ( IN ACPI_CPU_TOPOLOGY_GENERATOR *Generator, IN AML_NODE_HANDLE ParentNode, + IN CM_ARM_GICC_INFO *GicCInfo, IN UINT32 CpuName, OUT AML_OBJECT_NODE_HANDLE *EtNodePtr OPTIONAL ) @@ -397,7 +399,7 @@ CreateAmlEtd ( =20 Status =3D AmlCodeGenNameInteger ( "_UID", - CpuName, + GicCInfo->AcpiProcessorUid, EtNode, NULL ); @@ -474,6 +476,7 @@ CreateAmlEtNode ( Status =3D CreateAmlEtd ( Generator, Node, + GicCInfo, CpuName, NULL ); --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111231): https://edk2.groups.io/g/devel/message/111231 Mute This Topic: https://groups.io/mt/102598848/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-