From nobody Sat Feb 7 09:47:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93282+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93282+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1662485227; cv=none; d=zohomail.com; s=zohoarc; b=eVvwXW00tSegKxOFvcI+XPXg+7MH/lBa8RncRDI/n6VQrkBytLkkNn/uk3TJP0GIt9J3oPgx5blvSjyQnwPlYFELSUgGWDPjdFy7qCBXMJp5B6s/ForC8Go7vSyvJnHzvDr2IQJlgucTdYurUVuLjt7mxZG3PMDx14Z66ht2tVY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662485227; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=5mire2rXhN+2dGCGfn2kajM4TauXwu9AwDj5V8MttJA=; b=dpguFagkhgZNRp5QFtzWy2TTIVLfALOJiO7ejC1CLXwrygGlJZhleoJFsGO3ti2KFrzn1C8pR8DnlUEczo3eC+Y9Rp0FwqyFGP4yaQKef3bhEx0nCVwzdzKO+NFmzzoOb6trVSeR5z4y/xfR8KQ7B30s9QHKg7GfpruD+7TispM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93282+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662485227223374.7111014143919; Tue, 6 Sep 2022 10:27:07 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 9lVcYY1788612xFtbebZbyfH; Tue, 06 Sep 2022 10:27:06 -0700 X-Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) by mx.groups.io with SMTP id smtpd.web10.2136.1662485226003395857 for ; Tue, 06 Sep 2022 10:27:06 -0700 X-Received: by mail-qv1-f54.google.com with SMTP id l5so8805857qvs.13 for ; Tue, 06 Sep 2022 10:27:05 -0700 (PDT) X-Gm-Message-State: 6Vlm8HtqjJKCNNkzF19i52d5x1787277AA= X-Google-Smtp-Source: AA6agR7PfWCJVgdgD6tDuH7yaW1enInTQ+iytS2eeKk1pJdK9tqWwsRNzU47E5BWWttDxRtE6Iiimw== X-Received: by 2002:a0c:f307:0:b0:4aa:a431:c184 with SMTP id j7-20020a0cf307000000b004aaa431c184mr2508725qvl.76.1662485224901; Tue, 06 Sep 2022 10:27:04 -0700 (PDT) X-Received: from aturtleortwo-benjamindomain.. ([2607:f2c0:e98c:e:46bc:db07:bbf3:df6d]) by smtp.gmail.com with ESMTPSA id j2-20020a05620a410200b006b9ab3364ffsm12169038qko.11.2022.09.06.10.27.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 10:27:04 -0700 (PDT) From: "Benjamin Doron" To: devel@edk2.groups.io Cc: Sai Chaganty , Isaac Oram , Nate DeSimone , Ankit Sinha , Chasel Chiu , Liming Gao , Eric Dong Subject: [edk2-devel][edk2-platforms][PATCH v1 1/3] MinPlatformPkg,WhiskeylakeOpenBoardPkg/SecFspWrapperPlatformSecLib: First BoardInitLib Date: Tue, 6 Sep 2022 13:26:52 -0400 Message-Id: <0a6dd32438d554e03fa222a70593f7a99cfc19d1.1662484082.git.benjamin.doron00@gmail.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,benjamin.doron00@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662485226; bh=SNAZisVcLEg++T9BIMeniSKQO5lLx/Pfn7HHfLAIRXE=; h=Cc:Date:From:Reply-To:Subject:To; b=rRAHditFZWpKxyZEWLjVdZocJcaip6Se9YF0XYRPdeWlfaMknABifIhZIng13cFWjrn VwFFOwG0HjRhUL6Oa3lBmeBt0WQLKFBB0OCWMOZWdZ5IQc28alL2tGAzDv7uHp6QEOzjX XUW9wqWJEG4c62cXw9l9/Oyh1bwAyKj7hes= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662485227900100004 Content-Type: text/plain; charset="utf-8" SecBoardInitLib is called to enable serial port before SerialPortInitialize and DEBUG(). This is strongly assumed to be necessary for I2cHdmiDebugSerialPortLib in SEC phase, which presently initialises this way. No testing was performed before, it's assumed too risky unless the GPIO happens to have the desired default. Presently, DEBUG() works in SEC phase. Cc: Sai Chaganty Cc: Isaac Oram Cc: Nate DeSimone Cc: Ankit Sinha Cc: Chasel Chiu Cc: Liming Gao Cc: Eric Dong Signed-off-by: Benjamin Doron Reviewed-by: Nate DeSimone --- .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++-- .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapper= PlatformSecLib/PlatformInit.c b/Platform/Intel/MinPlatformPkg/FspWrapper/Li= brary/SecFspWrapperPlatformSecLib/PlatformInit.c index ef89e3f31018..d74b07bc062b 100644 --- a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfor= mSecLib/PlatformInit.c +++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfor= mSecLib/PlatformInit.c @@ -28,6 +28,12 @@ PlatformInit ( IN VOID *EndOfRange ) { + // + // Board/Silicon initialization + // Prepare controllers before enabling serial port + // + BoardAfterTempRamInit (); + // // Platform initialization // Enable Serial port here @@ -41,7 +47,5 @@ PlatformInit ( DEBUG ((DEBUG_INFO, "StartOfRange - 0x%x\n", StartOfRange)); DEBUG ((DEBUG_INFO, "EndOfRange - 0x%x\n", EndOfRange)); =20 - BoardAfterTempRamInit (); - TestPointTempMemoryFunction (StartOfRange, EndOfRange); } diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Lib= rary/SecFspWrapperPlatformSecLib/PlatformInit.c b/Platform/Intel/Whiskeylak= eOpenBoardPkg/UpXtreme/FspWrapper/Library/SecFspWrapperPlatformSecLib/Platf= ormInit.c index 486c8c72616e..53f95c29bde5 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/Se= cFspWrapperPlatformSecLib/PlatformInit.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/Se= cFspWrapperPlatformSecLib/PlatformInit.c @@ -28,6 +28,12 @@ PlatformInit ( IN VOID *EndOfRange ) { + // + // Board/Silicon initialization + // Prepare controllers before enabling serial port + // + BoardAfterTempRamInit (); + // // Platform initialization // Enable Serial port here @@ -41,7 +47,5 @@ PlatformInit ( DEBUG ((DEBUG_INFO, "StartOfRange - 0x%x\n", StartOfRange)); DEBUG ((DEBUG_INFO, "EndOfRange - 0x%x\n", EndOfRange)); =20 - BoardAfterTempRamInit (); - TestPointTempMemoryFunction (StartOfRange, EndOfRange); } --=20 2.37.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93282): https://edk2.groups.io/g/devel/message/93282 Mute This Topic: https://groups.io/mt/93506700/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-