From nobody Mon Feb 9 06:08:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+110300+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+110300+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1698652179; cv=none; d=zohomail.com; s=zohoarc; b=GWSnd+TWADUsu1Sn5Q5XZ3RIoj+qPifwhXwWI9hj3xov8/g5viUZNYRVj9jLxxvTcB5V4Jy6/XXaXXda1Dji8/0Ar9EUBDj/I9nyKIBGcHJqqS7Mc7OGEz9vnZ/fq83apt+XcF95+x5H//gBX4tMKlsnAVoX8f1rjv4YEocQQoI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1698652179; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=F8XecfxEdEYnlIwqQ/e2NZQxUdFSDgq2jlPX/lu2hZU=; b=LQXF/t9fgGs1XxXDwtD1f6fb0BAHzjPYRbUGEY+sDkaOSUPcpV6roS0yuze/ynVG+wUKnopALR4co8clMR7viB9ysrRjOyC3WPQlmQV+b005KFCV7XGR6VvGH7XdK6LFod7V+AO0IQW9zX3EXoBlP+kCCwLstJDEtPDzSKjluPU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+110300+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1698652179212834.02142682568; Mon, 30 Oct 2023 00:49:39 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=W2yRN1or4chXqO4tzivovtDWxveMy2e1sfvlx/xAe/A=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1698652178; v=1; b=DeAQB4Z1h8CR60UsuNiKJnhXgB0fbsmZrDFgvFwsACFNiuOVcei94iwxLhbyK3tFUZHaZG37 +G587FRLIsnOjofFhGfdRRFrVCA1FMwnH51U7gD1qFzRnxy/iVF+zUV7vTKrcHXkahWaHhsdNCG uJ1pR3APwhdZzlAUSMESGhFA= X-Received: by 127.0.0.2 with SMTP id TIS0YY1788612xfdDHHDokJh; Mon, 30 Oct 2023 00:49:38 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.143793.1698652164261209974 for ; Mon, 30 Oct 2023 00:49:38 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10878"; a="419138592" X-IronPort-AV: E=Sophos;i="6.03,263,1694761200"; d="scan'208";a="419138592" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2023 00:49:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10878"; a="736666797" X-IronPort-AV: E=Sophos;i="6.03,263,1694761200"; d="scan'208";a="736666797" X-Received: from shpfwdbuild003.ccr.corp.intel.com ([10.239.56.82]) by orsmga006.jf.intel.com with ESMTP; 30 Oct 2023 00:49:36 -0700 From: "Xu, Wei6" To: devel@edk2.groups.io Cc: Wei6 Xu , Laszlo Ersek , Ard Biesheuvel , Sami Mujawar , Ray Ni Subject: [edk2-devel] [PATCH v3 4/4] StandaloneMmPkg/Core: Fix the failure to find uncompressed inner FV Date: Mon, 30 Oct 2023 15:49:18 +0800 Message-Id: <0936c14a0495947f318724e50169b4161cae7c72.1698651605.git.wei6.xu@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,wei6.xu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: NbnuDANqoqhKt7mjQh4dca0Lx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1698652181188100007 Content-Type: text/plain; charset="utf-8" The MmCoreFfsFindMmDriver only checks for encapsulated compressed FVs. When an inner FV is uncompressed, StandaloneMmCore will miss the FV and all the MM drivers in the FV will not be dispatched. Add checks for uncompressed inner FV to fix this issue. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Ray Ni Signed-off-by: Wei6 Xu Reviewed-by: Laszlo Ersek --- StandaloneMmPkg/Core/FwVol.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/StandaloneMmPkg/Core/FwVol.c b/StandaloneMmPkg/Core/FwVol.c index fa335d62c252..783dbaf9b048 100644 --- a/StandaloneMmPkg/Core/FwVol.c +++ b/StandaloneMmPkg/Core/FwVol.c @@ -116,6 +116,25 @@ MmCoreFfsFindMmDriver ( break; } =20 + // + // Check uncompressed firmware volumes + // + Status =3D FfsFindSectionData ( + EFI_SECTION_FIRMWARE_VOLUME_IMAGE, + FileHeader, + &SectionData, + &SectionDataSize + ); + if (!EFI_ERROR (Status)) { + if (SectionDataSize > sizeof (EFI_FIRMWARE_VOLUME_HEADER)) { + InnerFvHeader =3D (EFI_FIRMWARE_VOLUME_HEADER *)SectionData; + MmCoreFfsFindMmDriver (InnerFvHeader, Depth + 1); + } + } + + // + // Check compressed firmware volumes + // Status =3D FfsFindSection ( EFI_SECTION_GUID_DEFINED, FileHeader, --=20 2.29.2.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110300): https://edk2.groups.io/g/devel/message/110300 Mute This Topic: https://groups.io/mt/102270549/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-