From nobody Fri May 3 18:31:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+54724+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+54724+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1582349121; cv=none; d=zohomail.com; s=zohoarc; b=EdZNGN+e+rD+/7fuL1Hud0hQgVM+mxRmFmFMf+FS/NfcQP+P4fq0KVebS9oZfwTA5P2gbG50ZAggtZNavAwPl09BmKXn/6iQlB93vBnpVJLFbRYfrTHQGMvQyHPpx6NDGx76uR5Bx/et58BBAiVjNzjgtzX/CHato+evX3HvYmw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582349121; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To; bh=k7hc116RFLygeGfLUz6js6AjkEE2joszJSPkH/qBb3c=; b=U8HlOH353BsfTF4VzOi0MfEhHw4EF9QSp9BZ5j+ouflRQRkwDRMwaBVMChNPEa4iPMV6pyF7jXWofaM195yerTXgzs8fdflVrLwm4weDdDOfpa432GSixFl8MQq9haSG9J99nj+tRcVoRc0XloAfqMauy1ZkIOhjHGBImUoajvQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+54724+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1582349121399703.375055243676; Fri, 21 Feb 2020 21:25:21 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id gVKxYY1788612x9wP4yFIKRX; Fri, 21 Feb 2020 21:25:20 -0800 X-Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by mx.groups.io with SMTP id smtpd.web12.3601.1582349120102869867 for ; Fri, 21 Feb 2020 21:25:20 -0800 X-Received: by mail-pl1-f196.google.com with SMTP id t14so1758882plr.8 for ; Fri, 21 Feb 2020 21:25:20 -0800 (PST) X-Gm-Message-State: rzmPepzvW3OJDNxWotbyPZafx1787277AA= X-Google-Smtp-Source: APXvYqyORD9BHhUGtifbGfryNvpD5tjBVBu+Ip1vrLTvH1UVQaW+fw2FD+BkalXZhmIQV3hdMqNouw== X-Received: by 2002:a17:90a:804a:: with SMTP id e10mr7312785pjw.41.1582349119184; Fri, 21 Feb 2020 21:25:19 -0800 (PST) X-Received: from localhost.localdomain ([223.104.146.86]) by smtp.gmail.com with ESMTPSA id 11sm4615581pfz.25.2020.02.21.21.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2020 21:25:18 -0800 (PST) From: "GuoMinJ" To: devel@edk2.groups.io Cc: GuoMinJ Subject: [edk2-devel] [PATCH] MdeModulePkg/SdDxe: Potential NULL pointer on Token Date: Sat, 22 Feb 2020 13:25:07 +0800 Message-Id: <04882a15a058465196f26220e820e99d90f98473.1582349099.git.newexplorerj@gmail.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,newexplorerj@gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1582349120; bh=QrwnJ/BRJTTugvpwkW+zjF8zPHzDgIE3itqjL2qH8cI=; h=Cc:Date:From:Reply-To:Subject:To; b=vj4Z2nyRIbEJFGHsy5+oRHVYiL8zZMfOFeCLoLXaE3+7aaYKjltk2oeyncUYMHZnMm2 lElDx50pMTPNAubK41IG5fPab2yXjmPUTqFMjGYkfFIesFAdmNSV/xtdPIzUeKd01pL5b 0hgDpS29S2gytr8hbi6Znn+8aDx9TzhLilw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2286 Token pointer may be NULL, it is should be check before use it. Signed-off-by: GuoMinJ --- MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c b/MdeModulePkg/Bus/Sd/Sd= Dxe/SdBlockIo.c index 9f42abe7e2..25ab5abb2d 100644 --- a/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c +++ b/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c @@ -1367,7 +1367,12 @@ SdEraseBlocks ( return Status; } =20 - DEBUG ((EFI_D_ERROR, "SdEraseBlocks(): Lba 0x%x BlkNo 0x%x Event %p with= %r\n", Lba, BlockNum, Token->Event, Status)); + DEBUG ((DEBUG_ERROR, "SdEraseBlocks(): Lba 0x%x BlkNo 0x%x with %r, ", L= ba, BlockNum, Status)); + if ((Token !=3D NULL) && (Token->Event !=3D NULL)) { + DEBUG ((DEBUG_ERROR, "Event pointer is %p\n", Token->Event)); + else { + DEBUG ((DEBUG_ERROR, "Event is meaningless\n")); + } =20 return Status; } --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54724): https://edk2.groups.io/g/devel/message/54724 Mute This Topic: https://groups.io/mt/71466355/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-