From nobody Tue May 7 02:16:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70657+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70657+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1611275266; cv=none; d=zohomail.com; s=zohoarc; b=ANcVupGgIh/CEvsr93gNHNRcD2Wm+fcqKJSUiq87/Kb4NGw0K+XaEcf9yoTfb7CG75mt0V36XzC0wye1vLoH9SEaxCGJp7HgZjt53peUH0tfMsx5tOaPKtw16s0ddhDR0y0/nrxQCrvNrjfXdkHW6ltP8WXwepPCMXk7fL6IJSM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611275266; h=Content-Type:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=35vQeOxt2/tbN/BdowjD5RQDUk6gb2Ki2LLEv6OMd0s=; b=LGKao1EP5jr/4+zvH4hkIx3i8g172dQlOIOm3nch9iNR0ebPxH5gVV3rpD72fJgdZ9bQcuGoblLRQe0xZuvvAymhyI/yhdKbEqsdjQ+oEkbQJoISWJuQi1Hx4CqEQEpwRQj1PtSuZrasNDLbHMRu2dpvow1SolcNmd/o97R5wu8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70657+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611275266297302.79932750522426; Thu, 21 Jan 2021 16:27:46 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id HTLIYY1788612x4fOFChEDfc; Thu, 21 Jan 2021 16:27:45 -0800 X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.2324.1611275262706371413 for ; Thu, 21 Jan 2021 16:27:44 -0800 X-Received: from DESKTOPS6D0PVI ([101.86.143.152]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 22 Jan 2021 08:27:32 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Bob Feng'" , "'Yuwei Chen'" References: <20210114223400.2596-1-kun.q@outlook.com>,<165A3A10BD6EE08F.30138@groups.io> ,<00c701d6ef97$22874980$6795dc80$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYzIDAxLzE4XSBCYXNlVG9vbHM6IEVjYy9leGNlcHRpb246IEFkZGVkIF9Nb2R1bGVFbnRyeVBvaW50IGludG8gZXhjZXB0aW9uIGxpc3Q=?= Date: Fri, 22 Jan 2021 08:27:25 +0800 Message-ID: <014901d6f055$61c69920$2553cb60$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQG2Xa4cDUUqX77fSiNZQxL+hYHiYAKPEjxPAYYoIlsCvqqVmgFUFcBgqjKvagA= Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn X-Gm-Message-State: DuQv8HPZWWhWjAmAcINwXPyzx1787277AA= Content-Type: multipart/alternative; boundary="----=_NextPart_000_014A_01D6F098.6FEB11A0" Content-Language: zh-cn DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611275265; bh=PNsheVyZLyScOvMAfTGKTPRBMyDZqFITMS/vC5ACTUo=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=dlTN2FmSmBnUDoi1Ip6LX+vjeBgdJH98jEyqkIWKTbUlKpIqeVIb9icURPJ7+tXhWZe K/AT35BOHJg4xi8YyUMJvDwOgCaHQ7FQTMef0xZAQGE9kUERETEyyy7mmZaRGxnj5lTwF BOldW6SfthREE+4wkVP38X064bd3eEy0B/I= X-ZohoMail-DKIM: pass (identity @groups.io) ------=_NextPart_000_014A_01D6F098.6FEB11A0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Got it. Reviewed-by: Liming Gao =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+70609+4905953+8761045@groups.io =E4=BB=A3=E8=A1=A8 Kun Qin =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B41=E6=9C=8821=E6=97=A5 9:= 54 =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.com.cn =E6=8A=84=E9=80=81: 'Bob Feng' ; 'Yuwei Chen' =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/except= ion: Added _ModuleEntryPoint into exception list =20 Hi Liming, =20 It trips on the coding style where =E2=80=9CFunction name does not follow t= he rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters=E2=80=9D. Please see detailed error= info here: https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=3D18722 &view=3Dlogs&j=3Ddc79cb3a-f339-5fc0-73b1-0ff8c522379e&t=3Db5b21d01-2921-57e= a-8401- 4c0ebee10613&l=3D69 =20 This patch ([PATCH v3 02/18] StandaloneMmPkg: StandaloneMmCoreEntryPoint: Extends support for X64 (groups.io) ) added a new instance for StandaloneMmCoreEntryPoint library and failed on ECC check 8006 due to the function name involved. =20 Regards, Kun =20 From: gaoliming =20 Sent: Wednesday, January 20, 2021 17:45 To: 'Kun Qin' ; devel@edk2.groups.io =20 Cc: 'Bob Feng' ; 'Yuwei Chen' =20 Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/e= xception: Added _ModuleEntryPoint into exception list =20 Qin: This change makes sense. Can you let me know which case trigs this ECC issue? Does your patch include such case? =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: Kun Qin >=20 =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B41=E6=9C=8821=E6=97=A5 9:= 37 =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =20 =E6=8A=84=E9=80=81: Bob Feng >; Liming Gao >; Yuwei Chen > =E4=B8=BB=E9=A2=98: RE: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/except= ion: Added _ModuleEntryPoint into exception list =20 Hi Bob/Liming/Yuwei, =20 Do you mind providing some feedback on this patch? This is to unblock the second patch (adding driver entry point instance for Standalone X64) of this patch series. Thanks in advance! =20 Regards, Kun =20 From: Kun Qin =20 Sent: Thursday, January 14, 2021 14:34 To: devel@edk2.groups.io =20 Cc: Bob Feng ; Liming Gao ; Yuwei Chen Subject: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list =20 Function '_ModuleEntryPoint' is a pre-defined interface for various EFI module types and should not be caught violating EFI coding style. This change added '_ModuleEntryPoint' into exception list to fix EFI coding style error 8006 during CI build. Cc: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > Signed-off-by: Kun Qin > Reviewed-by: Bob Feng > --- Notes: v3: - Newly added to fix CI build on changing '_ModuleEntryPoint' BaseTools/Source/Python/Ecc/exception.xml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BaseTools/Source/Python/Ecc/exception.xml b/BaseTools/Source/Python/Ecc/exception.xml index 8133904fbc7f..f2334aab8e52 100644 --- a/BaseTools/Source/Python/Ecc/exception.xml +++ b/BaseTools/Source/Python/Ecc/exception.xml @@ -296,6 +296,10 @@ _DriverUnloadHandler 8006 + + _ModuleEntryPoint + 8006 + ASSERT 10015 --=20 2.30.0.windows.1 =20 =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70657): https://edk2.groups.io/g/devel/message/70657 Mute This Topic: https://groups.io/mt/80019646/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- ------=_NextPart_000_014A_01D6F098.6FEB11A0 Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable
Got it. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn= >

 

Thanks

Liming

=B7=A2=BC=FE=C8=CB:= bounce+27952+70609+4= 905953+8761045@groups.io <bounce+27952+70609+4905953+8761045@groups.io&g= t; =B4=FA=B1=ED <= /b>Kun Qin
= =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA1=D4=C221=C8=D5 9:54
=CA=D5=BC=FE=C8=CB:<= /b> devel@edk2.groups.io; gaoliming@byosoft.com.cn
=B3=AD=CB=CD: 'Bob= Feng' <bob.c.feng@intel.com>; 'Yuwei Chen' <yuwei.chen@intel.com&= gt;
=D6=F7=CC=E2: Re: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _Mod= uleEntryPoint into exception list

<= p class=3DMsoNormal> 

Hi Liming,

 

It trips on the coding style where =A1=B0Function= name does not follow the rules: 1. First character should be upper case 2.= Must contain lower case characters 3. No white space characters=A1=B1. Ple= ase see detailed error info here:

https= ://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=3D18722&view= =3Dlogs&j=3Ddc79cb3a-f339-5fc0-73b1-0ff8c522379e&t=3Db5b21d01-2921= -57ea-8401-4c0ebee10613&l=3D69

 

<= span lang=3DEN-US>This patch ([PATCH v3 02/18] StandaloneMmPkg: StandaloneMmCoreEntryPoint: E= xtends support for X64 (groups.io)) added a new instance for Standalone= MmCoreEntryPoint library and failed on ECC check 8006 due to the function n= ame involved.

=  

Regards= ,

Kun

 

From: = gaoliming
Sent: Wednesday, January 20, 2021 17:45
To: 'Kun Qin'; devel@edk2.groups.io
Cc: 'Bob Feng'; 'Yuw= ei Chen'
Subject: =BB=D8=B8=B4: [edk2-devel] [PATCH v3 01/18]= BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list=

 <= /o:p>

Qin:<= /span>

 This change makes sense. Can you let me kn= ow which case trigs this ECC issue? Does your patch include such case?

 =

Thanks

Liming

= =B7=A2=BC=FE=C8=CB: Kun Qin <kun.q@outlook.com>
=B7=A2=CB=CD= =CA=B1=BC=E4: 2021=C4=EA1=D4=C221=C8=D5 9:37
=CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
=B3=AD=CB=CD: Bob Feng <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Yuwei Chen <<= a href=3D"mailto:yuwei.chen@intel.com">yuwei.chen@intel.com>
=D6=F7=CC=E2: RE: [e= dk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoi= nt into exception list

 

Hi Bob/Liming/Yuwei,

 

Do you mind providing some f= eedback on this patch? This is to unblock the second patch (adding driver e= ntry point instance for Standalone X64) of this patch series. Thanks in adv= ance!

 

Regards,

Kun

 

From: Kun Qin
Sent: Thursday, January 14, 2021 14:34
To: devel@edk2.groups.io
Cc: Bob Feng; = Liming Gao; Yuwei Chen
<= b>Subject: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Adde= d _ModuleEntryPoint into exception list

 

Function '_ModuleE= ntryPoint' is a pre-defined interface for various EFI
module types and s= hould not be caught violating EFI coding style. This
change added '_Modu= leEntryPoint' into exception list to fix EFI coding
style error 8006 dur= ing CI build.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen &= lt;yuwei.chen@intel.com>
=
Signed-off-by: Kun Qin <kun.q@o= utlook.com>
---

Notes:
    v3:
 =    - Newly added to fix CI build on changing '_ModuleEntryPoint'<= br>
 BaseTools/Source/Python/Ecc/exception.xml | 4 ++++
 1 = file changed, 4 insertions(+)

diff --git a/BaseTools/Source/Python/E= cc/exception.xml b/BaseTools/Source/Python/Ecc/exception.xml
index 81339= 04fbc7f..f2334aab8e52 100644
--- a/BaseTools/Source/Python/Ecc/exception= .xml
+++ b/BaseTools/Source/Python/Ecc/exception.xml
@@ -296,6 +296,1= 0 @@
     <KeyWord>_DriverUnloadHandler</Ke= yWord>
     <ErrorID>8006</ErrorID>   </Exception>
+  <Exception>
+ &n= bsp;  <KeyWord>_ModuleEntryPoint</KeyWord>
+  = ;  <ErrorID>8006</ErrorID>
+  </Exception>   <Exception>
     <KeyWord>= ;ASSERT</KeyWord>
     <ErrorID>10015<= ;/ErrorID>
--
2.30.0.windows.1



<= /p>

 

 

=

_._,_._,_
Gr= oups.io Links:

You receive all messages sent to this group.

Vie= w/Reply Online (#70657) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [importer@patchew.org]

_._,_._,_
=20 ------=_NextPart_000_014A_01D6F098.6FEB11A0--