From nobody Wed May 8 19:15:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70607+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70607+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1611193553; cv=none; d=zohomail.com; s=zohoarc; b=nqvENjIbxbqjOucZD87czPpD1sI5C6/iiooSQraNuaVWkZHHlXzgduoYdzpVeEDaWkQ719Wb/gDnwZ0V+07OByD84BaZV2b++S54oXe8rfOiy79aLcsW+0sr3TWJc9fa0Y2BTiy0uzhcSk0gL2qiTXIHnSieBSEzX2EmeXJFnT4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611193553; h=Content-Type:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=mhsuAyYA7waFXKSL+zEo3f6BawWIT+171J40EPvu2G8=; b=MlXVA5bsoxTr2TTuWI1P0a4SketaQ/S2CzmwOLwCeRfurJY6b7kwSJG6uCqWkPnW7PzvH3v2joSn9/oOEOEAEsfxx4SIDVSm0C8+qVzetAg2zHjeF1xjYgYZmuaql157sHwX6KLvRqweOooUDj6aTe9bU2l+cYdf+c3lG1n+Jfs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70607+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611193553309358.41651305889457; Wed, 20 Jan 2021 17:45:53 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id N5ApYY1788612xZn7tvj1qgr; Wed, 20 Jan 2021 17:45:52 -0800 X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.1041.1611193546391277652 for ; Wed, 20 Jan 2021 17:45:47 -0800 X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 21 Jan 2021 09:45:42 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Kun Qin'" , Cc: "'Bob Feng'" , "'Yuwei Chen'" References: <20210114223400.2596-1-kun.q@outlook.com>,<165A3A10BD6EE08F.30138@groups.io> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYzIDAxLzE4XSBCYXNlVG9vbHM6IEVjYy9leGNlcHRpb246IEFkZGVkIF9Nb2R1bGVFbnRyeVBvaW50IGludG8gZXhjZXB0aW9uIGxpc3Q=?= Date: Thu, 21 Jan 2021 09:45:45 +0800 Message-ID: <00c701d6ef97$22874980$6795dc80$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQG2Xa4cDUUqX77fSiNZQxL+hYHiYAKPEjxPAYYoIluqUcfroA== Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn X-Gm-Message-State: 8BlvcJkhcUXPGDyZE2POmEpbx1787277AA= Content-Type: multipart/alternative; boundary="----=_NextPart_000_00C8_01D6EFDA.30AB4CD0" Content-Language: zh-cn DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611193552; bh=kfUUgjCqcI1NqIH89gAoGiiv6+lwtSb4lmc/dkxENLE=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=KKjzq2FiI51N9PG/qH+WOAhGeaDe0aCsGBEk/MjXVUV0mqmjB4MbQIQxcXEhMIJB/az IRSMm/8G9ot/pTyEfpYQejK6xgaXl/poFU2YsbmPH1JZRupN8nibDEXMgBPNzOEg6V8H+ AkJXOCuXoPU24hRUGmUTEwNDy2XC3nU3qf0= X-ZohoMail-DKIM: pass (identity @groups.io) ------=_NextPart_000_00C8_01D6EFDA.30AB4CD0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Qin: This change makes sense. Can you let me know which case trigs this ECC issue? Does your patch include such case? =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: Kun Qin =20 =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B41=E6=9C=8821=E6=97=A5 9:= 37 =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E6=8A=84=E9=80=81: Bob Feng ; Liming Gao ; Yuwei Chen =E4=B8=BB=E9=A2=98: RE: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/except= ion: Added _ModuleEntryPoint into exception list =20 Hi Bob/Liming/Yuwei, =20 Do you mind providing some feedback on this patch? This is to unblock the second patch (adding driver entry point instance for Standalone X64) of this patch series. Thanks in advance! =20 Regards, Kun =20 From: Kun Qin =20 Sent: Thursday, January 14, 2021 14:34 To: devel@edk2.groups.io =20 Cc: Bob Feng ; Liming Gao ; Yuwei Chen Subject: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list =20 Function '_ModuleEntryPoint' is a pre-defined interface for various EFI module types and should not be caught violating EFI coding style. This change added '_ModuleEntryPoint' into exception list to fix EFI coding style error 8006 during CI build. Cc: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > Signed-off-by: Kun Qin > --- Notes: v3: - Newly added to fix CI build on changing '_ModuleEntryPoint' BaseTools/Source/Python/Ecc/exception.xml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BaseTools/Source/Python/Ecc/exception.xml b/BaseTools/Source/Python/Ecc/exception.xml index 8133904fbc7f..f2334aab8e52 100644 --- a/BaseTools/Source/Python/Ecc/exception.xml +++ b/BaseTools/Source/Python/Ecc/exception.xml @@ -296,6 +296,10 @@ _DriverUnloadHandler 8006 + + _ModuleEntryPoint + 8006 + ASSERT 10015 --=20 2.30.0.windows.1 =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70607): https://edk2.groups.io/g/devel/message/70607 Mute This Topic: https://groups.io/mt/79994517/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- ------=_NextPart_000_00C8_01D6EFDA.30AB4CD0 Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable
Qin:

 This change makes = sense. Can you let me know which case trigs this ECC issue? Does your patch= include such case?

 

Thanks

Liming

=B7=A2=BC=FE=C8=CB: Kun Qin <kun.q@outl= ook.com>
=B7=A2=CB=CD= = =CA=B1=BC=E4: 2021=C4=EA1=D4=C221=C8=D5<= span lang=3DEN-US> 9:37
=CA=D5=BC=FE=C8=CB:= devel@edk2.groups.io
=B3=AD=CB= =CD: Bob Feng <bob.c.f= eng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Yuwei Chen = <yuwei.chen@intel.com>
=D6=F7=CC=E2:<= /span> RE: [edk2-devel] [PATCH v3 01/18] BaseTools: = Ecc/exception: Added _ModuleEntryPoint into exception list

 =

Hi Bob/Liming/Yuwe= i,

 =

Do you mind provid= ing some feedback on this patch? This is to unblock the second patch (addin= g driver entry point instance for Standalone X64) of this patch series. Tha= nks in advance!

 

Regar= ds,

Kun

 

From: Kun Qin
Sent: Thursday, January 14, 2021 14:34
To: devel@edk2.groups.io
Cc: Bob Feng; Liming Gao; Yuwei Che= n
Subject: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/excep= tion: Added _ModuleEntryPoint into exception list

 

Function = '_ModuleEntryPoint' is a pre-defined interface for various EFI
module ty= pes and should not be caught violating EFI coding style. This
change add= ed '_ModuleEntryPoint' into exception list to fix EFI coding
style error= 8006 during CI build.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuw= ei Chen <yuwei.chen@intel.com>

Signed-off-by: Kun Qin <kun.q@outlook.com>
---

Notes:
    v3:<= br>    - Newly added to fix CI build on changing '_ModuleEnt= ryPoint'

 BaseTools/Source/Python/Ecc/exception.xml | 4 ++++ 1 file changed, 4 insertions(+)

diff --git a/BaseTools/Source= /Python/Ecc/exception.xml b/BaseTools/Source/Python/Ecc/exception.xml
in= dex 8133904fbc7f..f2334aab8e52 100644
--- a/BaseTools/Source/Python/Ecc/= exception.xml
+++ b/BaseTools/Source/Python/Ecc/exception.xml
@@ -296= ,6 +296,10 @@
     <KeyWord>_DriverUnloadHandl= er</KeyWord>
     <ErrorID>8006</Erro= rID>
   </Exception>
+  <Exception>
= +    <KeyWord>_ModuleEntryPoint</KeyWord>
+&n= bsp;   <ErrorID>8006</ErrorID>
+  </Except= ion>
   <Exception>
     <K= eyWord>ASSERT</KeyWord>
     <ErrorID>= ;10015</ErrorID>
--
2.30.0.windows.1



 

_._,_._,_
Gr= oups.io Links:

You receive all messages sent to this group.

Vie= w/Reply Online (#70607) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [importer@patchew.org]

_._,_._,_
=20 ------=_NextPart_000_00C8_01D6EFDA.30AB4CD0--