From nobody Mon May 6 15:42:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+77631+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+77631+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1625808255; cv=none; d=zohomail.com; s=zohoarc; b=A9sxVKic5RU7nIWbfiimTvXECAiSCIDjniMPRjTWaPf/kNlI08qTpo/RsIFAAdfmM9sD9Rq7YcDTb9FrcuyZ/4ys5U9D//d2ijRCh8isC3AeArXKLQnc3WU4b+qQu9LIUiaLRv85U/0lMjI2mrCDM2+TP1crfWvwZX8QEmwW6HQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625808255; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=0QEvMHs4mmDQU6bFos8DJxePQ9lVzIW0PXoRYGZSa34=; b=mV7w0LDNacAeYYWu38Y+2l0Vo/j5tVIvsp+QE6icN2wV3QIzBKBk3CEJf1ht3UWiETwY4WQEeIWD55DqmGaqp7HSR+V4G4JK3KhW4MK0R2Wz9prfGE3irOV1+qN89mngNggo1sg82hmxloSveNvLLet+ctMIyr0os+RslpjAqlE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+77631+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1625808255580741.9211798211759; Thu, 8 Jul 2021 22:24:15 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 76yBYY1788612xCU3u4dS5X3; Thu, 08 Jul 2021 22:24:15 -0700 X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.7223.1625808252829997638 for ; Thu, 08 Jul 2021 22:24:14 -0700 X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 09 Jul 2021 13:24:08 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Bret Barkelew'" Cc: "'Liu, Zhiguang'" References: <20210707224310.1665-1-michael.d.kinney@intel.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbRVhURVJOQUxdIFtlZGsyLWRldmVsXSBbUGF0Y2ggMS8xXSBNZGVQa2cvSW5jbHVkZTogQWRkIFNUQVRJQ19BU1NFUlQgZm9yIEwnJyBhbmQgTCIiIHN0cmluZ3M=?= Date: Fri, 9 Jul 2021 13:24:09 +0800 Message-ID: <008001d77482$a515f890$ef41e9b0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQDZ/oKLCJe06a1nk4VAM3Iy++xuCwLEm85+AQqwMwcCb2ZMyq0DEq4g Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn X-Gm-Message-State: zjoptgdnhO07vJWDvlO3h7dDx1787277AA= Content-Type: multipart/alternative; boundary="----=_NextPart_000_0081_01D774C5.B33A7110" Content-Language: zh-cn DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1625808255; bh=CDmVQDOSuDDhyYKdQbsdE7nIDdmUSXbVjJjqUqGFj2E=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=p+s2Js5j2dHEY+Z4rdd9uGD2aG1evEf7dYdgixH8XVWBdwBn8x/DwyjLq4H868jPiQO A/8/6kXXNKALZ4dnQS8wIqxS0VszMJyjhd77ZjlSsUoAQ/Rwj6DB5Fogoh3Hit+E7TB/u XBVke+4s1XJXcqMLy8kQqQ253H/GAV6UIbo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1625808256692100001 ------=_NextPart_000_0081_01D774C5.B33A7110 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Reviewed-by: Liming Gao =20 =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Michael D Kinney =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B47=E6=9C=888=E6=97=A5 10:= 40 =E6=94=B6=E4=BB=B6=E4=BA=BA: Bret Barkelew ; d= evel@edk2.groups.io; Kinney, Michael D =E6=8A=84=E9=80=81: Liming Gao ; Liu, Zhiguang =E4=B8=BB=E9=A2=98: Re: [EXTERNAL] [edk2-devel] [Patch 1/1] MdePkg/Include:= Add STATIC_ASSERT for L'' and L"" strings =20 The extra spaces are in purpose to align the =3D=3D =20 It looks correct with a fixed size font. =20 Mike =20 From: Kinney, Michael D >=20 Sent: Wednesday, July 7, 2021 7:20 PM To: Bret Barkelew >; devel@edk2.groups.io ; Kinney, Mi= chael D > Cc: Liming Gao = >; Liu, Zhiguang > Subject: RE: [EXTERNAL] [edk2-devel] [Patch 1/1] MdePkg/Include: Add STATIC= _ASSERT for L'' and L"" strings =20 Hi Bret, =20 I will fix the extra spaces. =20 Thanks, =20 Mike =20 From: Bret Barkelew >=20 Sent: Wednesday, July 7, 2021 4:00 PM To: devel@edk2.groups.io ; Kinney, Michael D = > Cc: Liming Gao = >; Liu, Zhiguang > Subject: RE: [EXTERNAL] [edk2-devel] [Patch 1/1] MdePkg/Include: Add STATIC= _ASSERT for L'' and L"" strings =20 I like it. Do you have an extra space after the (L=E2=80=99A=E2=80=99) and (L=E2=80=9D= A=E2=80=9D)? =20 Reviewed-by: Bret Barkelew > =20 - Bret =20 From: Michael D Kinney via groups.io =20 Sent: Wednesday, July 7, 2021 3:43 PM To: devel@edk2.groups.io =20 Cc: Liming Gao ; Zhiguang Liu =20 Subject: [EXTERNAL] [edk2-devel] [Patch 1/1] MdePkg/Include: Add STATIC_ASS= ERT for L'' and L"" strings =20 Add STATIC_ASSERT() macros to verify that the compiler is configured correctly for the use of L'' and L"" strings. Cc: Liming Gao > Cc: Zhiguang Liu > Signed-off-by: Michael D Kinney > --- MdePkg/Include/Base.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h index 8e4271f6eaf5..2da08b0c787f 100644 --- a/MdePkg/Include/Base.h +++ b/MdePkg/Include/Base.h @@ -6,7 +6,7 @@ environment. There are a set of base libraries in the Mde Package that c= an be used to implement base modules. =20 -Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.
Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -821,6 +821,8 @@ STATIC_ASSERT (sizeof (INT64) =3D=3D 8, "sizeof (INT6= 4) does not meet UEFI Specifi STATIC_ASSERT (sizeof (UINT64) =3D=3D 8, "sizeof (UINT64) does not meet U= EFI Specification Data Type requirements"); STATIC_ASSERT (sizeof (CHAR8) =3D=3D 1, "sizeof (CHAR8) does not meet UE= FI Specification Data Type requirements"); STATIC_ASSERT (sizeof (CHAR16) =3D=3D 2, "sizeof (CHAR16) does not meet U= EFI Specification Data Type requirements"); +STATIC_ASSERT (sizeof (L'A') =3D=3D 2, "sizeof (L'A') does not meet UEF= I Specification Data Type requirements"); +STATIC_ASSERT (sizeof (L"A") =3D=3D 4, "sizeof (L\"A\") does not meet U= EFI Specification Data Type requirements"); =20 // // The following three enum types are used to verify that the compiler --=20 2.32.0.windows.1 =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77631): https://edk2.groups.io/g/devel/message/77631 Mute This Topic: https://groups.io/mt/84085464/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- ------=_NextPart_000_0081_01D774C5.B33A7110 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn&g= t;

 

=

=E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.g= roups.io <devel@edk2.groups.io> =E4=BB=A3=E8=A1=A8 Michael D Kinney
=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4= : 2021=E5=B9=B47=E6=9C=888<= /span>=E6=97=A5 10:40
=E6=94=B6=E4=BB=B6=E4= = =BA=BA: Bret Barkelew <= ;Bret.Barkelew@microsoft.com>; devel@edk2.groups.io; Kinney, Michael D &= lt;michael.d.kinney@intel.com>
=E6=8A=84=E9=80=81: Liming Gao <gaoliming@byosoft.= com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>
=E4= =B8=BB=E9=A2=98: Re: [EXT= ERNAL] [edk2-devel] [Patch 1/1] MdePkg/Include: Add STATIC_ASSERT for L'' a= nd L"" strings

 

The extra spaces are in purpose to align the =3D= =3D

&nbs= p;

It looks correct= with a fixed size font.

 

Mike

=  

 =

Hi Bret,

 

<= p class=3DMsoNormal>I will fix the extra spaces.

 

Thanks,

 

Mike

 

=

From: Bret Barkelew <Bret.B= arkelew@microsoft.com>
Sent: Wednesday, July 7, 2021 4:00= PM
To: devel@edk2.groups= .io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>; Liu= , Zhiguang <zhiguang.liu@intel= .com>
Subject: RE: [EXTERNAL] [edk2-devel] [Patch 1/1] Mde= Pkg/Include: Add STATIC_ASSERT for L'' and L"" strings=

 <= /o:p>

I like it.

Do you have an extra s= pace after the (L=E2=80=99A=E2=80=99) and (L=E2=80=9DA=E2=80=9D)?

 

Reviewed-by: Bret Barkelew <= ;bret.barkelew@microsoft.com= >

=  

- Bret<= /o:p>

 

From: <= /b>Michael D Kinney via groups.io
Sent: Wednesday, July 7, = 2021 3:43 PM
To: devel@ed= k2.groups.io
Cc: = Liming Gao; Zhiguang Liu<= br>Subject: [EXTERNAL] [edk2-devel] [Patch 1/1] MdePkg/Include: Add = STATIC_ASSERT for L'' and L"" strings

=

 

Add STATIC_= ASSERT() macros to verify that the compiler is
configured correctly for = the use of L'' and L"" strings.

Cc: Liming Gao <gaoliming@byosoft.com.cn>
C= c: Zhiguang Liu <zhiguang.liu@= intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
&n= bsp;MdePkg/Include/Base.h | 4 +++-
 1 file changed, 3 insertions(+)= , 1 deletion(-)

diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/= Base.h
index 8e4271f6eaf5..2da08b0c787f 100644
--- a/MdePkg/Include/B= ase.h
+++ b/MdePkg/Include/Base.h
@@ -6,7 +6,7 @@
   env= ironment. There are a set of base libraries in the Mde Package that can
=    be used to implement base modules.
 
-Copyright (c)= 2006 - 2018, Intel Corporation. All rights reserved.<BR>
+Copyrig= ht (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
&n= bsp;Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<= BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent
 
@= @ -821,6 +821,8 @@ STATIC_ASSERT (sizeof (INT64)   =3D=3D 8, &quo= t;sizeof (INT64) does not meet UEFI Specifi
 STATIC_ASSERT (sizeof = (UINT64)  =3D=3D 8, "sizeof (UINT64) does not meet UEFI Specifica= tion Data Type requirements");
 STATIC_ASSERT (sizeof (CHAR8)&= nbsp;  =3D=3D 1, "sizeof (CHAR8) does not meet UEFI Specification= Data Type requirements");
 STATIC_ASSERT (sizeof (CHAR16)&nbs= p; =3D=3D 2, "sizeof (CHAR16) does not meet UEFI Specification Data Ty= pe requirements");
+STATIC_ASSERT (sizeof (L'A')    = = =3D=3D 2, "sizeof (L'A') does not meet UEFI Specification Data Type r= equirements");
+STATIC_ASSERT (sizeof (L"A")  &= nbsp; =3D=3D 4, "sizeof (L\"A\") does not meet UEFI Specific= ation Data Type requirements");
 
 //
 // The = following three enum types are used to verify that the compiler
--
2= .32.0.windows.1


 

_._,_._,_
= Groups.io Links:

You receive all messages sent to this group.

<= a target=3D"_blank" href=3D"https://edk2.groups.io/g/devel/message/77631">V= iew/Reply Online (#77631) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [importer@patchew.org]
_._,_._,_=20 ------=_NextPart_000_0081_01D774C5.B33A7110--