From nobody Sat May 4 02:02:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67166+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67166+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1604909497; cv=none; d=zohomail.com; s=zohoarc; b=jfRVj3blbv+Xt94j3jTV//1Pj3T0OYk4kU5/GmQQ6h0I4OmzVf6J/SFv8+AiE/NwUvclFhwYG0zWBrJHj49H+VZTl/E3zYF0mw6CI5P5W10F66WTwygWa94oiHYq2UJ4yq9VLPPBKWJ71pdQjD3Flv1BnsThCORrhhTSq/qEIkQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604909497; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=uM6wY6LnQGSsUTv5urT5r1nhROJQOdEZV69wRe5qSDY=; b=GSjkXGyO9Ev3zEHGoSBvIZ9SnuOwccZ4Pannd0yMEEDAQj3BIowjAd40+G7LsXjyKw/k0ZZNXExSSMkwneWTnWvBqP3/viqWKI7iNzP7mFCO1BjFiwo/GYQSFfYuZxRmw0PYmtoQxnCTFFPFSOFrXexSb9EJ/NYRiIoEcJhmjwg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67166+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 160490949782556.87176249155948; Mon, 9 Nov 2020 00:11:37 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id xLdnYY1788612xwBiwhMbqmU; Mon, 09 Nov 2020 00:11:37 -0800 X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.8554.1604909496283789628 for ; Mon, 09 Nov 2020 00:11:37 -0800 X-Received: from LAPTOP2AECFQIA ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 09 Nov 2020 16:11:34 +0800 X-WM-Sender: fengyunhua@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: fengyunhua@byosoft.com.cn From: "fengyunhua" To: , Cc: "'Liming Gao'" , "'Chen, Christine'" References: <20201030033939.2094-1-fengyunhua@byosoft.com.cn> <20201030033939.2094-3-fengyunhua@byosoft.com.cn> <000001d6b662$f4eef6c0$decce440$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYyIDIvMl0gQmFzZVRvb2xzOiB1cGRhdGUgcmVwb3J0IG1hcCBmaWxlIGZvcm1hdA==?= Date: Mon, 9 Nov 2020 16:11:33 +0800 Message-ID: <000701d6b66f$f03c3130$d0b49390$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQEswrjjJEBfHs6pNUEUQY+rCEqxJwJ+InjLAYoNF8EBc4HMJgGEgbTNqttYGQA= Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,fengyunhua@byosoft.com.cn X-Gm-Message-State: d1v5ozUkYnkJ8FMBAwXttihXx1787277AA= Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1604909497; bh=WHAZn4rTCm7B+AUl8CHB3e79mhi+47OSxgq4NsK6LPw=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=vF6qhuj7mDrJCTExQfH9H71fSNp0FaIkeGS6qPqWIPxlBBZkVXqckM+GmT/Oyf7SbLk JwkQpwLePbgGtYpFd3IixK2Cs5CZX/cpLx5x+T1U/Ux5E+Iw3jFvkTXtNhNZSAR8Jj85n iINFuGhSADUSSHtTzKqU0N/AdEe3RTsemSc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Ok, I have updated commit message with v3 Thanks, Yunhua -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+67162+5049190+8953120@groups.io <= bounce+27952+67162+5049190+8953120@groups.io> =E4=BB=A3=E8=A1=A8 Bob Feng =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B411=E6=9C=889=E6=97=A5 15= :09 =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; fengyunhua@byosoft.com.cn =E6=8A=84=E9=80=81: 'Liming Gao' ; Chen, Christin= e =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update repor= t map file format Yes. I know this from the code review mail. But only the patch subject and = message body will be recorded in commit log. People can not tell what the r= elationship between your patch 1/2 and patch 2/2 based on the commit histor= y. So I think each of the patches need to have a complete description. There s= hould be some necessary context info about this patch. Thanks, Bob -----Original Message----- From: devel@edk2.groups.io On Behalf Of fengyunhua Sent: Monday, November 9, 2020 2:39 PM To: devel@edk2.groups.io; Feng, Bob C Cc: 'Liming Gao' ; Chen, Christine Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH v2 2/2] BaseTools: update = report map file format Hi Bob, This series patch for BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2977 Because of .map file changed, so we should change the regular expression pa= ttern for the match Thanks, Yunhua -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+67141+5049190+8953120@groups.io =E4=BB=A3=E8=A1=A8 Bob Feng =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B411=E6=9C=889=E6=97=A5 14= :15 =E6=94=B6=E4=BB=B6=E4=BA=BA: Yunhua Feng ; devel= @edk2.groups.io =E6=8A=84=E9=80=81: Liming Gao ; Chen, Christine = =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update repor= t map file format Yuhuan, Would you please provide a complete commit message to this patch? Thanks, Bob -----Original Message----- From: Yunhua Feng Sent: Friday, October 30, 2020 11:40 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ; Chen, Christine Subject: [PATCH v2 2/2] BaseTools: update report map file format update report map file format Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Yunhua Feng --- BaseTools/Source/Python/build/BuildReport.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py index 8efa869162..330234e5af 100644 --- a/BaseTools/Source/Python/build/BuildReport.py +++ b/BaseTools/Source/Python/build/BuildReport.py @@ -60,7 +60,7 @@ gPcdGuidPattern =3D re.compile(r"PCD\((\w+)[.](\w+)\)") gOffsetGuidPattern =3D re.compile(r"(0x[0-9A-Fa-f]+) ([-A-Fa-f0-9]+)") =20 ## Pattern to find module base address and entry point in fixed flash map = file -gModulePattern =3D r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=3D%(Address)= s,\s*EntryPoint=3D%(Address)s\ )\s*\(GUID=3D([-0-9A-Fa-f]+)[^)]*\)" +gModulePattern =3D r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=3D%(Address)s,\s*EntryPoint=3D%(Addre= ss)s, \s*Type=3D\w+\)\s*\(GUID=3D([-0-9A-Fa-f]+)[^)]*\)" gMapFileItemPattern =3D re.compile(gModulePattern % {"Address" : "(-?0[xX][0-9A-Fa-f]+)"}) =20 ## Pattern to find all module referenced header files in source files -- 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67166): https://edk2.groups.io/g/devel/message/67166 Mute This Topic: https://groups.io/mt/78131426/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-