From nobody Fri Mar 29 07:59:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84072+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84072+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1637805184; cv=none; d=zohomail.com; s=zohoarc; b=I9dpcnMvkj01pu7wwa5ns7hQs4yXNbL3gldOXtw9zcHB3YZdDRz+/peMJ+qsrqple1UDABI/DvaTnRoOfOLy9oArCIIzK14xH+8eBMA2MMue+06plSoXn+ilAJrVWTexqpEM9kENVEuqL3gd3gWEEtqPT5nZjVjoaxc3y+n41gY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637805184; h=Content-Type:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=XO32/gClWSttN6NCWW+uQI2h4Qla73JgpniQ3nQpqs8=; b=m58txQQzZJazSt8a5c+qhoZ/7snoAEkoCQpy7WOPwFvejJdM8rJ8oQcBiMwBLR8ZBte8zvisgmvpV/jny23xly4Rph5CPRucHNBTNXiElo/qTOUaOVmtKrev2I/QSY4g5K7rHk6RPfrAWAgVaaWtgq8ChNLVYnazfieJNhdG6fE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84072+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1637805184559571.6198556515529; Wed, 24 Nov 2021 17:53:04 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id BDh9YY1788612xCx3OJTJhQe; Wed, 24 Nov 2021 17:53:04 -0800 X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.6895.1637805182805829450 for ; Wed, 24 Nov 2021 17:53:03 -0800 X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 25 Nov 2021 09:52:57 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Anbazhagan, Baraneedharan'" Cc: , "'Fu, Siyuan'" , , "'Andrew Fish'" , "'Michael D Kinney'" Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BhdGNoIGVkazItc3RhYmxlMjAyMTExXSBOZXR3b3JrUGtnOiBGaXggaW52YWxpZCBwb2ludGVyIGZvciBETlMgcmVzcG9uc2UgdG9rZW4gb24gZXJyb3I=?= Date: Thu, 25 Nov 2021 09:52:58 +0800 Message-ID: <000001d7e19f$2c08e8b0$841aba10$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: Adfhnh4nx7L7EObPSIa/w/Q1mC1yqQ== Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn X-Gm-Message-State: sti3qtLEsQ7GYpiX7MPokUCFx1787277AA= Content-Type: multipart/alternative; boundary="----=_NextPart_000_0001_01D7E1E2.3A2CEC00" Content-Language: zh-cn DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1637805184; bh=KI955p4W/nwFlFx9aZLA33MF2TRTXWSx+xhHKoRGYuQ=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=kiajRxf33k23uVXoTadAxiywyqrdcEakviSSRuxLobGWQ06uAaoM4GOcH67ukVI5ueS 4nwDA0qkVJ4XJru1VHodkB/S6JB4tPOhhVn6o9S8uJSjd02O6QpqOfC7MKvctX6EPV6xQ 3a99Q5hb6Du0KBE7nSoi5+InX5SCbWRYJkY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1637805185473100001 ------=_NextPart_000_0001_01D7E1E2.3A2CEC00 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" I suggest to merge this fix for the stable tag 202111. This fix is low risk. =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Wu, Jiaxin =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B411=E6=9C=8825=E6=97=A5 9= :37 =E6=94=B6=E4=BB=B6=E4=BA=BA: Anbazhagan, Baraneedharan ;= devel@edk2.groups.io =E6=8A=84=E9=80=81: maciej.rabeda@linux.intel.com; Fu, Siyuan =E4=B8=BB=E9=A2=98: Re: [edk2-devel] NetworkPkg: Fix invalid pointer for DN= S response token on error =20 Reviewed-by: Wu Jiaxin > =20 =20 =20 From: Anbazhagan, Baraneedharan >=20 Sent: Thursday, November 25, 2021 9:28 AM To: devel@edk2.groups.io =20 Cc: maciej.rabeda@linux.intel.com ; Wu, Jiaxin >; Fu, Siyuan > Subject: RE: NetworkPkg: Fix invalid pointer for DNS response token on error =20 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3719 =20 Token->RspData.H2AData is de-allocated on error but it is not set to NULL. HTTP module attempts to free again and cause assert. =20 Signed-off-by: Baraneedharan Anbazhagan anbazhagan@hp.com =20 Reviewed-by: Wu Jiaxin > --- NetworkPkg/DnsDxe/DnsImpl.c | 2 ++ 1 file changed, 2 insertions(+) =20 diff --git a/NetworkPkg/DnsDxe/DnsImpl.c b/NetworkPkg/DnsDxe/DnsImpl.c index 2edcb280ac..78a56f2b56 100644 --- a/NetworkPkg/DnsDxe/DnsImpl.c +++ b/NetworkPkg/DnsDxe/DnsImpl.c @@ -1700,6 +1700,7 @@ ON_EXIT: } =20 FreePool (Dns4TokenEntry->Token->RspData.H2AData); + Dns4TokenEntry->Token->RspData.H2AData =3D NULL; } } } @@ -1731,6 +1732,7 @@ ON_EXIT: } =20 FreePool (Dns6TokenEntry->Token->RspData.H2AData); + Dns6TokenEntry->Token->RspData.H2AData =3D NULL; } } } --=20 2.33.0.windows.2 =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84072): https://edk2.groups.io/g/devel/message/84072 Mute This Topic: https://groups.io/mt/87294818/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- ------=_NextPart_000_0001_01D7E1E2.3A2CEC00 Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

I suggest to merge this fix for the stable tag 202111. T= his fix is low risk.

 

Thanks

Liming

=B7=A2=BC=FE=C8=CB: devel@= edk2.groups.io <devel@edk2.groups.io> =B4=FA=B1=ED Wu, Jiaxin
=B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA11=D4=C225=C8=D5 9:37
=CA= =D5=BC=FE=C8=CB: Anbazhaga= n, Baraneedharan <anbazhagan@hp.com>; devel@edk2.groups.io
= =B3=AD=CB=CD: maciej.ra= beda@linux.intel.com; Fu, Siyuan <siyuan.fu@intel.com>
= =D6=F7=CC=E2: Re: [edk2-de= vel] NetworkPkg: Fix invalid pointer for DNS response token on error

<= o:p> 

Reviewed= -by: Wu Jiaxin <jiaxin.wu@intel.c= om>

 

 = ;

 =

= From: Anbazhagan, Baraneedharan <anbazhagan@hp.com>
Sent: Th= ursday, November 25, 2021 9:28 AM
To: devel@edk2.groups.io
Cc: maciej.rabeda@linux.intel.com; Wu, Jiaxin <= ;jiaxin.wu@intel.com>; Fu, Si= yuan <siyuan.fu@intel.com>=
Subject: RE: NetworkPkg: Fix invalid pointer for DNS response to= ken on error

 

Ref: = https://bugzilla.tianocore.org/show_bug.cgi?id=3D3719=

 

Token->RspData.H2AData is de-alloca= ted on error but it is not

set to NULL. HTTP module attempts to free again and cause asse= rt.

 = ;

Signed-off-by: Ba= raneedharan Anbazhagan anbazhagan@hp.c= om

---

NetworkPkg/DnsDxe= /DnsImpl.c | 2 ++

1 file changed, 2 insertions(+)

 

diff --git a/NetworkPkg/DnsDxe/DnsImpl.c b/NetworkPkg/DnsDxe= /DnsImpl.c

ind= ex 2edcb280ac..78a56f2b56 100644

= --- a/NetworkPkg/DnsDxe/DnsImpl.c

<= p class=3DMsoNormal>+++ b/NetworkPkg/DnsDxe/DnsImpl.c

@@ -1700,6 +1700= ,7 @@ ON_EXIT:

           }<= /span>

 <= /p>

     &n= bsp;     FreePool (Dns4TokenEntry->Token->Rs= pData.H2AData);

+          Dns4TokenEntry-&g= t;Token->RspData.H2AData =3D NULL;

         }<= o:p>

  &n= bsp;    }

     }

@@ -1731,6 +1732,7 @@ ON_EXIT:

     &nbs= p;     }

 

           = FreePool (Dns6TokenEntry->Token->RspData.H2AData);<= /p>

+     &= nbsp;    Dns6TokenEntry->Token->RspData.H2AData =3D NU= LL;

 &nbs= p;       }

       }

    = ; }

--

2.33.0.windows.2

 =

_._,_._,_

G= roups.io Links:

You receive all messages sent to this group.

Vi= ew/Reply Online (#84072) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [importer@patchew.org]
_._,_._,_=20 ------=_NextPart_000_0001_01D7E1E2.3A2CEC00--