BaseTools/Source/Python/build/BuildReport.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Hi Bob,
This series patch for BZ:
https://bugzilla.tianocore.org/show_bug.cgi?id=2977
Because of .map file changed, so we should change the regular expression
pattern for the match
Thanks,
Yunhua
-----邮件原件-----
发件人: bounce+27952+67141+5049190+8953120@groups.io
<bounce+27952+67141+5049190+8953120@groups.io> 代表 Bob Feng
发送时间: 2020年11月9日 14:15
收件人: Yunhua Feng <fengyunhua@byosoft.com.cn>; devel@edk2.groups.io
抄送: Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine
<yuwei.chen@intel.com>
主题: Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file
format
Yuhuan,
Would you please provide a complete commit message to this patch?
Thanks,
Bob
-----Original Message-----
From: Yunhua Feng <fengyunhua@byosoft.com.cn>
Sent: Friday, October 30, 2020 11:40 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao
<gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: [PATCH v2 2/2] BaseTools: update report map file format
update report map file format
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
---
BaseTools/Source/Python/build/BuildReport.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/build/BuildReport.py
b/BaseTools/Source/Python/build/BuildReport.py
index 8efa869162..330234e5af 100644
--- a/BaseTools/Source/Python/build/BuildReport.py
+++ b/BaseTools/Source/Python/build/BuildReport.py
@@ -60,7 +60,7 @@ gPcdGuidPattern = re.compile(r"PCD\((\w+)[.](\w+)\)")
gOffsetGuidPattern = re.compile(r"(0x[0-9A-Fa-f]+) ([-A-Fa-f0-9]+)")
## Pattern to find module base address and entry point in fixed flash map
file -gModulePattern =
r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s\
)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)"
+gModulePattern =
r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s,
\s*Type=\w+\)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)"
gMapFileItemPattern = re.compile(gModulePattern % {"Address" :
"(-?0[xX][0-9A-Fa-f]+)"})
## Pattern to find all module referenced header files in source files
--
2.27.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67145): https://edk2.groups.io/g/devel/message/67145
Mute This Topic: https://groups.io/mt/78130734/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Yes. I know this from the code review mail. But only the patch subject and message body will be recorded in commit log. People can not tell what the relationship between your patch 1/2 and patch 2/2 based on the commit history. So I think each of the patches need to have a complete description. There should be some necessary context info about this patch. Thanks, Bob -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of fengyunhua Sent: Monday, November 9, 2020 2:39 PM To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com> Cc: 'Liming Gao' <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com> Subject: 回复: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format Hi Bob, This series patch for BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2977 Because of .map file changed, so we should change the regular expression pattern for the match Thanks, Yunhua -----邮件原件----- 发件人: bounce+27952+67141+5049190+8953120@groups.io <bounce+27952+67141+5049190+8953120@groups.io> 代表 Bob Feng 发送时间: 2020年11月9日 14:15 收件人: Yunhua Feng <fengyunhua@byosoft.com.cn>; devel@edk2.groups.io 抄送: Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com> 主题: Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format Yuhuan, Would you please provide a complete commit message to this patch? Thanks, Bob -----Original Message----- From: Yunhua Feng <fengyunhua@byosoft.com.cn> Sent: Friday, October 30, 2020 11:40 AM To: devel@edk2.groups.io Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com> Subject: [PATCH v2 2/2] BaseTools: update report map file format update report map file format Cc: Bob Feng <bob.c.feng@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Yuwei Chen <yuwei.chen@intel.com> Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn> --- BaseTools/Source/Python/build/BuildReport.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py index 8efa869162..330234e5af 100644 --- a/BaseTools/Source/Python/build/BuildReport.py +++ b/BaseTools/Source/Python/build/BuildReport.py @@ -60,7 +60,7 @@ gPcdGuidPattern = re.compile(r"PCD\((\w+)[.](\w+)\)") gOffsetGuidPattern = re.compile(r"(0x[0-9A-Fa-f]+) ([-A-Fa-f0-9]+)") ## Pattern to find module base address and entry point in fixed flash map file -gModulePattern = r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s\ )\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)" +gModulePattern = r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s, \s*Type=\w+\)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)" gMapFileItemPattern = re.compile(gModulePattern % {"Address" : "(-?0[xX][0-9A-Fa-f]+)"}) ## Pattern to find all module referenced header files in source files -- 2.27.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67162): https://edk2.groups.io/g/devel/message/67162 Mute This Topic: https://groups.io/mt/78130929/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Ok, I have updated commit message with v3
Thanks,
Yunhua
-----邮件原件-----
发件人: bounce+27952+67162+5049190+8953120@groups.io <bounce+27952+67162+5049190+8953120@groups.io> 代表 Bob Feng
发送时间: 2020年11月9日 15:09
收件人: devel@edk2.groups.io; fengyunhua@byosoft.com.cn
抄送: 'Liming Gao' <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
主题: Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format
Yes. I know this from the code review mail. But only the patch subject and message body will be recorded in commit log. People can not tell what the relationship between your patch 1/2 and patch 2/2 based on the commit history.
So I think each of the patches need to have a complete description. There should be some necessary context info about this patch.
Thanks,
Bob
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of fengyunhua
Sent: Monday, November 9, 2020 2:39 PM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>
Cc: 'Liming Gao' <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: 回复: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format
Hi Bob,
This series patch for BZ:
https://bugzilla.tianocore.org/show_bug.cgi?id=2977
Because of .map file changed, so we should change the regular expression pattern for the match
Thanks,
Yunhua
-----邮件原件-----
发件人: bounce+27952+67141+5049190+8953120@groups.io
<bounce+27952+67141+5049190+8953120@groups.io> 代表 Bob Feng
发送时间: 2020年11月9日 14:15
收件人: Yunhua Feng <fengyunhua@byosoft.com.cn>; devel@edk2.groups.io
抄送: Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
主题: Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format
Yuhuan,
Would you please provide a complete commit message to this patch?
Thanks,
Bob
-----Original Message-----
From: Yunhua Feng <fengyunhua@byosoft.com.cn>
Sent: Friday, October 30, 2020 11:40 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: [PATCH v2 2/2] BaseTools: update report map file format
update report map file format
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
---
BaseTools/Source/Python/build/BuildReport.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/build/BuildReport.py
b/BaseTools/Source/Python/build/BuildReport.py
index 8efa869162..330234e5af 100644
--- a/BaseTools/Source/Python/build/BuildReport.py
+++ b/BaseTools/Source/Python/build/BuildReport.py
@@ -60,7 +60,7 @@ gPcdGuidPattern = re.compile(r"PCD\((\w+)[.](\w+)\)")
gOffsetGuidPattern = re.compile(r"(0x[0-9A-Fa-f]+) ([-A-Fa-f0-9]+)")
## Pattern to find module base address and entry point in fixed flash map file -gModulePattern = r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s\
)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)"
+gModulePattern =
r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s,
\s*Type=\w+\)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)"
gMapFileItemPattern = re.compile(gModulePattern % {"Address" :
"(-?0[xX][0-9A-Fa-f]+)"})
## Pattern to find all module referenced header files in source files
--
2.27.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67166): https://edk2.groups.io/g/devel/message/67166
Mute This Topic: https://groups.io/mt/78131426/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Created a PR: https://github.com/tianocore/edk2/pull/1104 -----Original Message----- From: fengyunhua <fengyunhua@byosoft.com.cn> Sent: Monday, November 9, 2020 4:12 PM To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com> Cc: 'Liming Gao' <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com> Subject: 回复: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format Ok, I have updated commit message with v3 Thanks, Yunhua -----邮件原件----- 发件人: bounce+27952+67162+5049190+8953120@groups.io <bounce+27952+67162+5049190+8953120@groups.io> 代表 Bob Feng 发送时间: 2020年11月9日 15:09 收件人: devel@edk2.groups.io; fengyunhua@byosoft.com.cn 抄送: 'Liming Gao' <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com> 主题: Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format Yes. I know this from the code review mail. But only the patch subject and message body will be recorded in commit log. People can not tell what the relationship between your patch 1/2 and patch 2/2 based on the commit history. So I think each of the patches need to have a complete description. There should be some necessary context info about this patch. Thanks, Bob -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of fengyunhua Sent: Monday, November 9, 2020 2:39 PM To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com> Cc: 'Liming Gao' <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com> Subject: 回复: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format Hi Bob, This series patch for BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2977 Because of .map file changed, so we should change the regular expression pattern for the match Thanks, Yunhua -----邮件原件----- 发件人: bounce+27952+67141+5049190+8953120@groups.io <bounce+27952+67141+5049190+8953120@groups.io> 代表 Bob Feng 发送时间: 2020年11月9日 14:15 收件人: Yunhua Feng <fengyunhua@byosoft.com.cn>; devel@edk2.groups.io 抄送: Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com> 主题: Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format Yuhuan, Would you please provide a complete commit message to this patch? Thanks, Bob -----Original Message----- From: Yunhua Feng <fengyunhua@byosoft.com.cn> Sent: Friday, October 30, 2020 11:40 AM To: devel@edk2.groups.io Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com> Subject: [PATCH v2 2/2] BaseTools: update report map file format update report map file format Cc: Bob Feng <bob.c.feng@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Yuwei Chen <yuwei.chen@intel.com> Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn> --- BaseTools/Source/Python/build/BuildReport.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py index 8efa869162..330234e5af 100644 --- a/BaseTools/Source/Python/build/BuildReport.py +++ b/BaseTools/Source/Python/build/BuildReport.py @@ -60,7 +60,7 @@ gPcdGuidPattern = re.compile(r"PCD\((\w+)[.](\w+)\)") gOffsetGuidPattern = re.compile(r"(0x[0-9A-Fa-f]+) ([-A-Fa-f0-9]+)") ## Pattern to find module base address and entry point in fixed flash map file -gModulePattern = r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s\ )\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)" +gModulePattern = r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s, \s*Type=\w+\)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)" gMapFileItemPattern = re.compile(gModulePattern % {"Address" : "(-?0[xX][0-9A-Fa-f]+)"}) ## Pattern to find all module referenced header files in source files -- 2.27.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67216): https://edk2.groups.io/g/devel/message/67216 Mute This Topic: https://groups.io/mt/78153544/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.