ubd: Remove unused mutex 'ubd_mutex'

[PATCH] ubd: Remove unused mutex 'ubd_mutex'

Posted by linux@treblig.org 1 year, 9 months ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

Commit fb5d1d389c9e ("ubd: open the backing files in ubd_add")

removed the last use of ubd_mutex.
Remove it.

Build and kernel startup test only.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 arch/um/drivers/ubd_kern.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index 63fc062add708..2b855240fbabf 100644
--- a/arch/um/drivers/ubd_kern.c
+++ b/arch/um/drivers/ubd_kern.c
@@ -106,7 +106,6 @@ static inline void ubd_set_bit(__u64 bit, unsigned char *data)
 #define DRIVER_NAME "uml-blkdev"
 
 static DEFINE_MUTEX(ubd_lock);
-static DEFINE_MUTEX(ubd_mutex); /* replaces BKL, might not be needed */
 
 static int ubd_ioctl(struct block_device *bdev, blk_mode_t mode,
 		     unsigned int cmd, unsigned long arg);
-- 
2.45.0

Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex'

Posted by Christoph Hellwig 1 year, 9 months ago

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex'

Posted by Dr. David Alan Gilbert 1 year, 8 months ago

* Christoph Hellwig (hch@lst.de) wrote:
> Looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks Christoph; any ideas who might take this?

Dave
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex'

Posted by Christoph Hellwig 1 year, 8 months ago

On Mon, May 20, 2024 at 03:12:20PM +0000, Dr. David Alan Gilbert wrote:
> * Christoph Hellwig (hch@lst.de) wrote:
> > Looks good:
> > 
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
> Thanks Christoph; any ideas who might take this?

Probably Richard who is alredy on Cc.

Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex'

Posted by Richard Weinberger 1 year, 8 months ago

----- Ursprüngliche Mail -----
> Von: "hch" <hch@lst.de>
> An: "Dr. David Alan Gilbert" <linux@treblig.org>
> CC: "hch" <hch@lst.de>, "richard" <richard@nod.at>, "linux-um" <linux-um@lists.infradead.org>, "linux-kernel"
> <linux-kernel@vger.kernel.org>
> Gesendet: Montag, 20. Mai 2024 17:20:49
> Betreff: Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex'

> On Mon, May 20, 2024 at 03:12:20PM +0000, Dr. David Alan Gilbert wrote:
>> * Christoph Hellwig (hch@lst.de) wrote:
>> > Looks good:
>> > 
>> > Reviewed-by: Christoph Hellwig <hch@lst.de>
>> 
>> Thanks Christoph; any ideas who might take this?
> 
> Probably Richard who is alredy on Cc.

Yes, after the merge window.

Thanks,
//richard

Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex'

Posted by Dr. David Alan Gilbert 1 year, 8 months ago

* Richard Weinberger (richard@nod.at) wrote:
> ----- Ursprüngliche Mail -----
> > Von: "hch" <hch@lst.de>
> > An: "Dr. David Alan Gilbert" <linux@treblig.org>
> > CC: "hch" <hch@lst.de>, "richard" <richard@nod.at>, "linux-um" <linux-um@lists.infradead.org>, "linux-kernel"
> > <linux-kernel@vger.kernel.org>
> > Gesendet: Montag, 20. Mai 2024 17:20:49
> > Betreff: Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex'
> 
> > On Mon, May 20, 2024 at 03:12:20PM +0000, Dr. David Alan Gilbert wrote:
> >> * Christoph Hellwig (hch@lst.de) wrote:
> >> > Looks good:
> >> > 
> >> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> >> 
> >> Thanks Christoph; any ideas who might take this?
> > 
> > Probably Richard who is alredy on Cc.
> 
> Yes, after the merge window.

Thanks; no rush, just trying to keep an eye on where each patch is
going.

Dave

> Thanks,
> //richard
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/