[PATCH v6 0/7] dso/dsos memory savings and clean up

Ian Rogers posted 7 patches 2 weeks ago
There is a newer version of this series
tools/perf/builtin-annotate.c                 |   6 +-
tools/perf/builtin-buildid-cache.c            |   2 +-
tools/perf/builtin-buildid-list.c             |  18 +-
tools/perf/builtin-inject.c                   |  71 ++-
tools/perf/builtin-kallsyms.c                 |   2 +-
tools/perf/builtin-mem.c                      |   4 +-
tools/perf/builtin-report.c                   |   6 +-
tools/perf/builtin-script.c                   |   8 +-
tools/perf/builtin-top.c                      |   4 +-
tools/perf/builtin-trace.c                    |   2 +-
tools/perf/tests/code-reading.c               |   8 +-
tools/perf/tests/dso-data.c                   |  67 ++-
tools/perf/tests/hists_common.c               |   6 +-
tools/perf/tests/hists_cumulate.c             |   4 +-
tools/perf/tests/hists_output.c               |   2 +-
tools/perf/tests/maps.c                       |   4 +-
tools/perf/tests/symbols.c                    |   8 +-
tools/perf/tests/vmlinux-kallsyms.c           |   6 +-
tools/perf/ui/browsers/annotate.c             |   6 +-
tools/perf/ui/browsers/hists.c                |   8 +-
tools/perf/ui/browsers/map.c                  |   4 +-
tools/perf/util/annotate-data.c               |  18 +-
tools/perf/util/annotate.c                    |  17 +-
tools/perf/util/auxtrace.c                    |   2 +-
tools/perf/util/block-info.c                  |   2 +-
tools/perf/util/bpf-event.c                   |   8 +-
tools/perf/util/build-id.c                    |  38 +-
tools/perf/util/callchain.c                   |   2 +-
tools/perf/util/data-convert-json.c           |   2 +-
tools/perf/util/db-export.c                   |   6 +-
tools/perf/util/disasm.c                      |  40 +-
tools/perf/util/dlfilter.c                    |  12 +-
tools/perf/util/dso.c                         | 429 ++++++++-------
tools/perf/util/dso.h                         | 500 ++++++++++++++++--
tools/perf/util/dsos.c                        | 286 +++++-----
tools/perf/util/dsos.h                        |  18 +-
tools/perf/util/event.c                       |   8 +-
tools/perf/util/header.c                      |   8 +-
tools/perf/util/hist.c                        |   4 +-
tools/perf/util/intel-pt.c                    |  22 +-
tools/perf/util/machine.c                     |  50 +-
tools/perf/util/map.c                         |  78 +--
tools/perf/util/maps.c                        |  14 +-
tools/perf/util/print_insn.c                  |   2 +-
tools/perf/util/probe-event.c                 |  25 +-
.../util/scripting-engines/trace-event-perl.c |   6 +-
.../scripting-engines/trace-event-python.c    |  21 +-
tools/perf/util/sort.c                        |  19 +-
tools/perf/util/srcline.c                     |  65 +--
tools/perf/util/symbol-elf.c                  | 145 +++--
tools/perf/util/symbol-minimal.c              |   4 +-
tools/perf/util/symbol.c                      | 186 +++----
tools/perf/util/symbol_fprintf.c              |   4 +-
tools/perf/util/synthetic-events.c            |  24 +-
tools/perf/util/thread.c                      |   4 +-
tools/perf/util/unwind-libunwind-local.c      |  18 +-
tools/perf/util/unwind-libunwind.c            |   2 +-
tools/perf/util/vdso.c                        |   8 +-
58 files changed, 1410 insertions(+), 933 deletions(-)
[PATCH v6 0/7] dso/dsos memory savings and clean up
Posted by Ian Rogers 2 weeks ago
7 more patches from:
https://lore.kernel.org/lkml/20240202061532.1939474-1-irogers@google.com/
a near half year old adventure in trying to lower perf's dynamic
memory use. Bits like the memory overhead of opendir are on the
sidelines for now, too much fighting over how
distributions/C-libraries present getdents. These changes are more
good old fashioned replace an rb-tree with a sorted array and add
reference count tracking.

The changes migrate dsos code, the collection of dso structs, more
into the dsos.c/dsos.h files. As with maps and threads, this is done
so the internals can be changed - replacing a linked list (for fast
iteration) and an rb-tree (for fast finds) with a lazily sorted
array. The complexity of operations remain roughly the same, although
iterating an array is likely faster than iterating a linked list, the
memory usage is at least reduced by half.

As fixing the memory usage necessitates changing operations like find,
modify these operations so that they increment the reference count to
avoid races like a find in dsos and a remove. Similarly tighten up
lock usage so that operations working on dsos state hold the
appropriate lock. Note, since this series is partially applied in the
perf-tools-next tree currently some memory leaks have been introduced.

v5. Rebase, adding use of accessors to dso as necessary. Previous
    versions were all rebases or dropping merged patches.

v6. Rebase, move dsos__purge NULL assignment to dso->dsos to above
    dso__put to avoid a warning reported by Arnaldo. This was part of
    patch 5 in the v5 series.

Ian Rogers (7):
  perf dsos: Switch backing storage to array from rbtree/list
  perf dsos: Remove __dsos__addnew
  perf dsos: Remove __dsos__findnew_link_by_longname_id
  perf dsos: Switch hand code to bsearch
  perf dso: Add reference count checking and accessor functions
  perf dso: Reference counting related fixes
  perf dso: Use container_of to avoid a pointer in dso_data

 tools/perf/builtin-annotate.c                 |   6 +-
 tools/perf/builtin-buildid-cache.c            |   2 +-
 tools/perf/builtin-buildid-list.c             |  18 +-
 tools/perf/builtin-inject.c                   |  71 ++-
 tools/perf/builtin-kallsyms.c                 |   2 +-
 tools/perf/builtin-mem.c                      |   4 +-
 tools/perf/builtin-report.c                   |   6 +-
 tools/perf/builtin-script.c                   |   8 +-
 tools/perf/builtin-top.c                      |   4 +-
 tools/perf/builtin-trace.c                    |   2 +-
 tools/perf/tests/code-reading.c               |   8 +-
 tools/perf/tests/dso-data.c                   |  67 ++-
 tools/perf/tests/hists_common.c               |   6 +-
 tools/perf/tests/hists_cumulate.c             |   4 +-
 tools/perf/tests/hists_output.c               |   2 +-
 tools/perf/tests/maps.c                       |   4 +-
 tools/perf/tests/symbols.c                    |   8 +-
 tools/perf/tests/vmlinux-kallsyms.c           |   6 +-
 tools/perf/ui/browsers/annotate.c             |   6 +-
 tools/perf/ui/browsers/hists.c                |   8 +-
 tools/perf/ui/browsers/map.c                  |   4 +-
 tools/perf/util/annotate-data.c               |  18 +-
 tools/perf/util/annotate.c                    |  17 +-
 tools/perf/util/auxtrace.c                    |   2 +-
 tools/perf/util/block-info.c                  |   2 +-
 tools/perf/util/bpf-event.c                   |   8 +-
 tools/perf/util/build-id.c                    |  38 +-
 tools/perf/util/callchain.c                   |   2 +-
 tools/perf/util/data-convert-json.c           |   2 +-
 tools/perf/util/db-export.c                   |   6 +-
 tools/perf/util/disasm.c                      |  40 +-
 tools/perf/util/dlfilter.c                    |  12 +-
 tools/perf/util/dso.c                         | 429 ++++++++-------
 tools/perf/util/dso.h                         | 500 ++++++++++++++++--
 tools/perf/util/dsos.c                        | 286 +++++-----
 tools/perf/util/dsos.h                        |  18 +-
 tools/perf/util/event.c                       |   8 +-
 tools/perf/util/header.c                      |   8 +-
 tools/perf/util/hist.c                        |   4 +-
 tools/perf/util/intel-pt.c                    |  22 +-
 tools/perf/util/machine.c                     |  50 +-
 tools/perf/util/map.c                         |  78 +--
 tools/perf/util/maps.c                        |  14 +-
 tools/perf/util/print_insn.c                  |   2 +-
 tools/perf/util/probe-event.c                 |  25 +-
 .../util/scripting-engines/trace-event-perl.c |   6 +-
 .../scripting-engines/trace-event-python.c    |  21 +-
 tools/perf/util/sort.c                        |  19 +-
 tools/perf/util/srcline.c                     |  65 +--
 tools/perf/util/symbol-elf.c                  | 145 +++--
 tools/perf/util/symbol-minimal.c              |   4 +-
 tools/perf/util/symbol.c                      | 186 +++----
 tools/perf/util/symbol_fprintf.c              |   4 +-
 tools/perf/util/synthetic-events.c            |  24 +-
 tools/perf/util/thread.c                      |   4 +-
 tools/perf/util/unwind-libunwind-local.c      |  18 +-
 tools/perf/util/unwind-libunwind.c            |   2 +-
 tools/perf/util/vdso.c                        |   8 +-
 58 files changed, 1410 insertions(+), 933 deletions(-)

-- 
2.45.0.rc1.225.g2a3ae87e7f-goog