1. Patchew
  2. linux
  3. View series

[PATCH] virt: acrn: Remove unusted list 'acrn_irqfd_clients'

linux@treblig.org posted 1 patch 1 year, 9 months ago 
drivers/virt/acrn/irqfd.c | 2 --
1 file changed, 2 deletions(-)
[PATCH] virt: acrn: Remove unusted list 'acrn_irqfd_clients'
Posted by linux@treblig.org 1 year, 9 months ago 
From: "Dr. David Alan Gilbert" <linux@treblig.org>

It doesn't look like this was ever used.

Build tested only.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/virt/acrn/irqfd.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/virt/acrn/irqfd.c b/drivers/virt/acrn/irqfd.c
index d4ad211dce7a3..346cf0be4aac7 100644
--- a/drivers/virt/acrn/irqfd.c
+++ b/drivers/virt/acrn/irqfd.c
@@ -16,8 +16,6 @@
 
 #include "acrn_drv.h"
 
-static LIST_HEAD(acrn_irqfd_clients);
-
 /**
  * struct hsm_irqfd - Properties of HSM irqfd
  * @vm:		Associated VM pointer
-- 
2.45.0
Re: [PATCH] virt: acrn: Remove unusted list 'acrn_irqfd_clients'
Posted by Dr. David Alan Gilbert 1 year, 8 months ago 
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> It doesn't look like this was ever used.
> 
> Build tested only.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Ping

> ---
>  drivers/virt/acrn/irqfd.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/virt/acrn/irqfd.c b/drivers/virt/acrn/irqfd.c
> index d4ad211dce7a3..346cf0be4aac7 100644
> --- a/drivers/virt/acrn/irqfd.c
> +++ b/drivers/virt/acrn/irqfd.c
> @@ -16,8 +16,6 @@
>  
>  #include "acrn_drv.h"
>  
> -static LIST_HEAD(acrn_irqfd_clients);
> -
>  /**
>   * struct hsm_irqfd - Properties of HSM irqfd
>   * @vm:		Associated VM pointer
> -- 
> 2.45.0
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
Re: [PATCH] virt: acrn: Remove unusted list 'acrn_irqfd_clients'
Posted by Fei Li 1 year, 8 months ago 
On 2024-05-18 at 00:12:46 +0000, Dr. David Alan Gilbert wrote:
> * linux@treblig.org (linux@treblig.org) wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > It doesn't look like this was ever used.
> > 
> > Build tested only.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> Ping

Acked-by: Fei Li <fei1.li@intel.com>

Thanks.

> 
> > ---
> >  drivers/virt/acrn/irqfd.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/virt/acrn/irqfd.c b/drivers/virt/acrn/irqfd.c
> > index d4ad211dce7a3..346cf0be4aac7 100644
> > --- a/drivers/virt/acrn/irqfd.c
> > +++ b/drivers/virt/acrn/irqfd.c
> > @@ -16,8 +16,6 @@
> >  
> >  #include "acrn_drv.h"
> >  
> > -static LIST_HEAD(acrn_irqfd_clients);
> > -
> >  /**
> >   * struct hsm_irqfd - Properties of HSM irqfd
> >   * @vm:		Associated VM pointer
> > -- 
> > 2.45.0
> > 
> -- 
>  -----Open up your eyes, open up your mind, open up your code -------   
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/
>
Re: [PATCH] virt: acrn: Remove unusted list 'acrn_irqfd_clients'
Posted by Dr. David Alan Gilbert 1 year, 6 months ago 
* Fei Li (fei1.li@intel.com) wrote:
> On 2024-05-18 at 00:12:46 +0000, Dr. David Alan Gilbert wrote:
> > * linux@treblig.org (linux@treblig.org) wrote:
> > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > 
> > > It doesn't look like this was ever used.
> > > 
> > > Build tested only.
> > > 
> > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > 
> > Ping
> 
> Acked-by: Fei Li <fei1.li@intel.com>

Hi Fei,
  Do you know which way this is likely to get picked up?
(I don't see it in -next)

 Thanks,

Dave

> Thanks.
> 
> > 
> > > ---
> > >  drivers/virt/acrn/irqfd.c | 2 --
> > >  1 file changed, 2 deletions(-)
> > > 
> > > diff --git a/drivers/virt/acrn/irqfd.c b/drivers/virt/acrn/irqfd.c
> > > index d4ad211dce7a3..346cf0be4aac7 100644
> > > --- a/drivers/virt/acrn/irqfd.c
> > > +++ b/drivers/virt/acrn/irqfd.c
> > > @@ -16,8 +16,6 @@
> > >  
> > >  #include "acrn_drv.h"
> > >  
> > > -static LIST_HEAD(acrn_irqfd_clients);
> > > -
> > >  /**
> > >   * struct hsm_irqfd - Properties of HSM irqfd
> > >   * @vm:		Associated VM pointer
> > > -- 
> > > 2.45.0
> > > 
> > -- 
> >  -----Open up your eyes, open up your mind, open up your code -------   
> > / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> > \        dave @ treblig.org |                               | In Hex /
> >  \ _________________________|_____ http://www.treblig.org   |_______/
> > 
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
RE: [PATCH] virt: acrn: Remove unusted list 'acrn_irqfd_clients'
Posted by Li, Fei1 1 year, 6 months ago 
> -----Original Message-----
> From: Dr. David Alan Gilbert <linux@treblig.org>
> Sent: Friday, July 19, 2024 1:44 AM
> To: Li, Fei1 <fei1.li@intel.com>
> Cc: linux-kernel@vger.kernel.org; virtualization@lists.linux.dev
> Subject: Re: [PATCH] virt: acrn: Remove unusted list 'acrn_irqfd_clients'
> 
> * Fei Li (fei1.li@intel.com) wrote:
> > On 2024-05-18 at 00:12:46 +0000, Dr. David Alan Gilbert wrote:
> > > * linux@treblig.org (linux@treblig.org) wrote:
> > > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > >
> > > > It doesn't look like this was ever used.
> > > >
> > > > Build tested only.
> > > >
> > > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > >
> > > Ping
> >
> > Acked-by: Fei Li <fei1.li@intel.com>
> 
> Hi Fei,
>   Do you know which way this is likely to get picked up?
> (I don't see it in -next)
> 
>  Thanks,
> 
> Dave
> 
> > Thanks.

Hi Dave

For this patch, you could refer to https://lore.kernel.org/all/20210910094708.3430340-1-bigeasy@linutronix.de/ to cc Thomas Gleixner <tglx@linutronix.de> to help review.

Thanks.

> >
> > >
> > > > ---
> > > >  drivers/virt/acrn/irqfd.c | 2 --
> > > >  1 file changed, 2 deletions(-)
> > > >
> > > > diff --git a/drivers/virt/acrn/irqfd.c b/drivers/virt/acrn/irqfd.c
> > > > index d4ad211dce7a3..346cf0be4aac7 100644
> > > > --- a/drivers/virt/acrn/irqfd.c
> > > > +++ b/drivers/virt/acrn/irqfd.c
> > > > @@ -16,8 +16,6 @@
> > > >
> > > >  #include "acrn_drv.h"
> > > >
> > > > -static LIST_HEAD(acrn_irqfd_clients);
> > > > -
> > > >  /**
> > > >   * struct hsm_irqfd - Properties of HSM irqfd
> > > >   * @vm:		Associated VM pointer
> > > > --
> > > > 2.45.0
> > > >
> > > --
> > >  -----Open up your eyes, open up your mind, open up your code -------
> > > / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
> > > \        dave @ treblig.org |                               | In Hex /
> > >  \ _________________________|_____ http://www.treblig.org   |_______/
> > >
> >
> --
>  -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/
Re: [PATCH] virt: acrn: Remove unusted list 'acrn_irqfd_clients'
Posted by Dr. David Alan Gilbert 1 year, 6 months ago 
* Li, Fei1 (fei1.li@intel.com) wrote:
> > -----Original Message-----
> > From: Dr. David Alan Gilbert <linux@treblig.org>
> > Sent: Friday, July 19, 2024 1:44 AM
> > To: Li, Fei1 <fei1.li@intel.com>
> > Cc: linux-kernel@vger.kernel.org; virtualization@lists.linux.dev
> > Subject: Re: [PATCH] virt: acrn: Remove unusted list 'acrn_irqfd_clients'
> > 
> > * Fei Li (fei1.li@intel.com) wrote:
> > > On 2024-05-18 at 00:12:46 +0000, Dr. David Alan Gilbert wrote:
> > > > * linux@treblig.org (linux@treblig.org) wrote:
> > > > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > > >
> > > > > It doesn't look like this was ever used.
> > > > >
> > > > > Build tested only.
> > > > >
> > > > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > > >
> > > > Ping
> > >
> > > Acked-by: Fei Li <fei1.li@intel.com>
> > 
> > Hi Fei,
> >   Do you know which way this is likely to get picked up?
> > (I don't see it in -next)
> > 
> >  Thanks,
> > 
> > Dave
> > 
> > > Thanks.
> 
> Hi Dave
> 
> For this patch, you could refer to https://lore.kernel.org/all/20210910094708.3430340-1-bigeasy@linutronix.de/ to cc Thomas Gleixner <tglx@linutronix.de> to help review.

OK, I've added Thomas to the To: on this mail;
note he's not listed in Maintainers for drivers/virt/acrn

Dave

> Thanks.
> 
> > >
> > > >
> > > > > ---
> > > > >  drivers/virt/acrn/irqfd.c | 2 --
> > > > >  1 file changed, 2 deletions(-)
> > > > >
> > > > > diff --git a/drivers/virt/acrn/irqfd.c b/drivers/virt/acrn/irqfd.c
> > > > > index d4ad211dce7a3..346cf0be4aac7 100644
> > > > > --- a/drivers/virt/acrn/irqfd.c
> > > > > +++ b/drivers/virt/acrn/irqfd.c
> > > > > @@ -16,8 +16,6 @@
> > > > >
> > > > >  #include "acrn_drv.h"
> > > > >
> > > > > -static LIST_HEAD(acrn_irqfd_clients);
> > > > > -
> > > > >  /**
> > > > >   * struct hsm_irqfd - Properties of HSM irqfd
> > > > >   * @vm:		Associated VM pointer
> > > > > --
> > > > > 2.45.0
> > > > >
> > > > --
> > > >  -----Open up your eyes, open up your mind, open up your code -------
> > > > / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
> > > > \        dave @ treblig.org |                               | In Hex /
> > > >  \ _________________________|_____ http://www.treblig.org   |_______/
> > > >
> > >
> > --
> >  -----Open up your eyes, open up your mind, open up your code -------
> > / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
> > \        dave @ treblig.org |                               | In Hex /
> >  \ _________________________|_____ http://www.treblig.org   |_______/
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.