[v1] Fix reset issue with QEMU -machine q35

[SeaBIOS] [PATCH 0/2] Fix reset issue with QEMU -machine q35

Volker Rümelin posted 2 patches 2 years, 1 month ago

Diff against v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/seabios tags/patchew/69efc2d8-3bc5-48b8-238c-172af136d61c@t-online.de

There is a newer version of this series

src/fw/shadow.c | 16 +++++----
src/hw/pci.c    | 86 ++++++++++++++++++++++++++++++++++++++++++-------
src/hw/pci.h    | 19 ++++++++++-
3 files changed, 101 insertions(+), 20 deletions(-)

Expand all Fold all

[SeaBIOS] [PATCH 0/2] Fix reset issue with QEMU -machine q35

Posted by Volker Rümelin 2 years, 1 month ago

This reset issue was reported on the QEMU issue tracker at
https://gitlab.com/qemu-project/qemu/-/issues/766

A reset with QEMU -machine q35 -accel tcg leads to a reset loop
and with -machine q35 -accel kvm the reset only works because
KVM ignores the read-only semantics of the C-F segments.

Details about the issue are in "reset: force standard PCI
configuration access".

Volker Rümelin (2):
   pci: refactor the pci_config_*() functions
   reset: force standard PCI configuration access

  src/fw/shadow.c | 16 +++++----
  src/hw/pci.c    | 86 ++++++++++++++++++++++++++++++++++++++++++-------
  src/hw/pci.h    | 19 ++++++++++-
  3 files changed, 101 insertions(+), 20 deletions(-)

-- 
2.34.1
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH 0/2] Fix reset issue with QEMU -machine q35

Posted by Gerd Hoffmann 2 years, 1 month ago

On Sun, Mar 20, 2022 at 10:45:00AM +0100, Volker Rümelin wrote:
> This reset issue was reported on the QEMU issue tracker at
> https://gitlab.com/qemu-project/qemu/-/issues/766
> 
> A reset with QEMU -machine q35 -accel tcg leads to a reset loop
> and with -machine q35 -accel kvm the reset only works because
> KVM ignores the read-only semantics of the C-F segments.
> 
> Details about the issue are in "reset: force standard PCI
> configuration access".
> 
> Volker Rümelin (2):
>   pci: refactor the pci_config_*() functions
>   reset: force standard PCI configuration access

Series looks good to me.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org