[SeaBIOS] [PATCH 0/4] RFC: add CRB TPM device

marcandre.lureau@redhat.com posted 4 patches 6 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/seabios tags/patchew/20171006143327.25874-1-marcandre.lureau@redhat.com
src/hw/tpm_drivers.c | 226 ++++++++++++++++++++++++++++++++++++++++++++++++---
src/hw/tpm_drivers.h |  26 ++++++
src/x86.h            |   5 ++
3 files changed, 245 insertions(+), 12 deletions(-)
[SeaBIOS] [PATCH 0/4] RFC: add CRB TPM device
Posted by marcandre.lureau@redhat.com 6 years, 6 months ago
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Hi,

The following series implements a limited TPM CRB driver. The TIS
device with a TPM 2.0 seems to be ignored by Windows 10, so I
implemented a simple CRB device that I will send shortly on the
qemu-devel. With the CRB device, Windows 10 correctly recognized and
exchange with a TPM 2.0.

As long as the device isn't in qemu, I suppose this series should
remain RFC.

Feedback welcome!

Marc-André Lureau (4):
  x86: add readq()
  tpm: generalize init_timeout()
  tpm: use get_tpm_version() callback
  WIP: add TPM CRB device support

 src/hw/tpm_drivers.c | 226 ++++++++++++++++++++++++++++++++++++++++++++++++---
 src/hw/tpm_drivers.h |  26 ++++++
 src/x86.h            |   5 ++
 3 files changed, 245 insertions(+), 12 deletions(-)

-- 
2.14.1.146.gd35faa819


_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios
Re: [SeaBIOS] [PATCH 0/4] RFC: add CRB TPM device
Posted by Kevin O'Connor 6 years, 6 months ago
On Fri, Oct 06, 2017 at 04:33:23PM +0200, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Hi,
> 
> The following series implements a limited TPM CRB driver. The TIS
> device with a TPM 2.0 seems to be ignored by Windows 10, so I
> implemented a simple CRB device that I will send shortly on the
> qemu-devel. With the CRB device, Windows 10 correctly recognized and
> exchange with a TPM 2.0.
> 
> As long as the device isn't in qemu, I suppose this series should
> remain RFC.

Thanks.  The patches look fine to me, but the corresponding patches
will need to be committed to qemu before seabios.

-Kevin

_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios
Re: [SeaBIOS] [PATCH 0/4] RFC: add CRB TPM device
Posted by Stefan Berger 6 years, 2 months ago
On 10/06/2017 10:33 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Hi,
>
> The following series implements a limited TPM CRB driver. The TIS
> device with a TPM 2.0 seems to be ignored by Windows 10, so I
> implemented a simple CRB device that I will send shortly on the
> qemu-devel. With the CRB device, Windows 10 correctly recognized and
> exchange with a TPM 2.0.
>
> As long as the device isn't in qemu, I suppose this series should
> remain RFC.

I think you can repost it now...


_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios
Re: [SeaBIOS] [PATCH 0/4] RFC: add CRB TPM device
Posted by Marc-Andre Lureau 6 years, 2 months ago
Hi

On Sun, Feb 11, 2018 at 5:53 PM, Stefan Berger
<stefanb@linux.vnet.ibm.com> wrote:
> On 10/06/2017 10:33 AM, marcandre.lureau@redhat.com wrote:
>>
>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>> Hi,
>>
>> The following series implements a limited TPM CRB driver. The TIS
>> device with a TPM 2.0 seems to be ignored by Windows 10, so I
>> implemented a simple CRB device that I will send shortly on the
>> qemu-devel. With the CRB device, Windows 10 correctly recognized and
>> exchange with a TPM 2.0.
>>
>> As long as the device isn't in qemu, I suppose this series should
>> remain RFC.
>
>
> I think you can repost it now...

Indeed, the device is now in qemu. However, I don't have much time /
priority to work on seabios support for now. Since you have additional
patches on top, and you are experienced with that, perhaps you could
send the whole series including my patches (adding your reviewed-by /
signed-off and some text if you modified my patches)?  I suppose that
would work for Kevin too?

thanks

_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios
Re: [SeaBIOS] [PATCH 0/4] RFC: add CRB TPM device
Posted by Stefan Berger 6 years, 2 months ago
On 02/12/2018 01:17 PM, Marc-Andre Lureau wrote:
> Hi
>
> On Sun, Feb 11, 2018 at 5:53 PM, Stefan Berger
> <stefanb@linux.vnet.ibm.com> wrote:
>> On 10/06/2017 10:33 AM, marcandre.lureau@redhat.com wrote:
>>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>>
>>> Hi,
>>>
>>> The following series implements a limited TPM CRB driver. The TIS
>>> device with a TPM 2.0 seems to be ignored by Windows 10, so I
>>> implemented a simple CRB device that I will send shortly on the
>>> qemu-devel. With the CRB device, Windows 10 correctly recognized and
>>> exchange with a TPM 2.0.
>>>
>>> As long as the device isn't in qemu, I suppose this series should
>>> remain RFC.
>>
>> I think you can repost it now...
> Indeed, the device is now in qemu. However, I don't have much time /
> priority to work on seabios support for now. Since you have additional
> patches on top, and you are experienced with that, perhaps you could
> send the whole series including my patches (adding your reviewed-by /
> signed-off and some text if you modified my patches)?  I suppose that
> would work for Kevin too?
Fine by me.

    Stefan


_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios