[v1] Fix CRB probing to work with real hardware

[SeaBIOS] [PATCH 0/3] Fix CRB probing to work with real hardware

Posted by Stefan Berger 6 years, 1 month ago

This series of patches attempts to fix the probing of the CRB interface
for real hardware.

Stephen Douthit should test this on real hardware.

Regards,
   Stefan

Stefan Berger (3):
  tpm: Wait for tpmRegValidSts flags on CRQ interface before probing
  tpm: revert return values for successful/failed CRB probing
  tpm: when CRB is active, select, lock it, and check addresses

 src/hw/tpm_drivers.c | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

-- 
2.5.5


_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios

Re: [SeaBIOS] [PATCH 0/3] Fix CRB probing to work with real hardware

Posted by Stephen Douthit 6 years, 1 month ago

On 03/14/2018 01:42 PM, Stefan Berger wrote:
> This series of patches attempts to fix the probing of the CRB interface
> for real hardware.
> 
> Stephen Douthit should test this on real hardware.

Thanks for putting this together.

The modded unit is tied up in other development work that I need to
complete this week.  It will probably be a few days before I can get back
to this.

Regards,
Steve

_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios

Re: [SeaBIOS] [PATCH 0/3] Fix CRB probing to work with real hardware

Posted by Paul Menzel 6 years, 1 month ago

Dear Stefan,

On 03/14/18 18:42, Stefan Berger wrote:
> This series of patches attempts to fix the probing of the CRB interface
> for real hardware.
> 
> Stephen Douthit should test this on real hardware.

I tested this series on the Lenovo X60, where coreboot doesn’t set up 
the TPM, and the long delay is indeed gone. I didn’t do any measurements 
though, if there are small delays.

So, the bug fix commits fix real problems.

Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>

Kind regards,

Paul

_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios

Re: [SeaBIOS] [PATCH 0/3] Fix CRB probing to work with real hardware

Posted by Stefan Berger 6 years, 1 month ago

On 03/19/2018 09:02 AM, Paul Menzel wrote:
> Dear Stefan,
>
>
> On 03/14/18 18:42, Stefan Berger wrote:
>> This series of patches attempts to fix the probing of the CRB interface
>> for real hardware.
>>
>> Stephen Douthit should test this on real hardware.
>
> I tested this series on the Lenovo X60, where coreboot doesn’t set up 
> the TPM, and the long delay is indeed gone. I didn’t do any 
> measurements though, if there are small delays.
>
> So, the bug fix commits fix real problems.
>
> Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>

Thank you!

    Stefan

>
>
> Kind regards,
>
> Paul
>


_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios