From nobody Mon Apr 29 13:15:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1490906836765372.08229623055945; Thu, 30 Mar 2017 13:47:16 -0700 (PDT) Received: from localhost ([::1]:37593 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctgyR-0000uq-CM for importer@patchew.org; Thu, 30 Mar 2017 16:47:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctfft-0006qp-RK for qemu-devel@nongnu.org; Thu, 30 Mar 2017 15:24:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctffo-00063e-Tx for qemu-devel@nongnu.org; Thu, 30 Mar 2017 15:24:01 -0400 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]:35676) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ctffo-000622-NP for qemu-devel@nongnu.org; Thu, 30 Mar 2017 15:23:56 -0400 Received: by mail-wr0-x244.google.com with SMTP id p52so14842870wrc.2 for ; Thu, 30 Mar 2017 12:23:56 -0700 (PDT) Received: from [192.168.1.3] (host185-222-dynamic.104-80-r.retail.telecomitalia.it. [80.104.222.185]) by smtp.gmail.com with ESMTPSA id g141sm56299wmd.10.2017.03.30.12.23.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Mar 2017 12:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:cc:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=xMX0SsMrz1/R7CRqeFG/eYP6g9jgamwemU90pclRVds=; b=KtHZu2vG3ag83jQSDhLBq5c3sUO1oX3MZxOwmFt7bPWeeMJ/74llaf1F9vXzeCcT+i u6dIpKOZBBor1+fXGF/A4dxeqmLjXgTCoZP3QH1VatU99AvJDt7jLJe9XXahsRHXA0UG GAZw+mK9WwLzGpZA+y1hhYe4gwII/hLiIzt1UoKheajd0oRhO4rXCZ9TAxomjDIGy7Y/ 7+oJ63j/8oIBOcJV3Q94fdcn54V/TmDDvuYVXVTRnXnf7n9y7FASk/TFl5C5+oau3kqG 0Nx1MdNklMEAr/Fjwei4mnkKJ9k74jei+mdGDcEKh6yc9cdU/60lVgwkU7CktlWlv7mD Rirg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:cc:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=xMX0SsMrz1/R7CRqeFG/eYP6g9jgamwemU90pclRVds=; b=iY3X9bCodOQq6ZjtcAfY0lzB828W4ygsiTeaeccGo8e5bMv8y7rwgOnXeGu61UCZkW Xxu8sBUr17aXD583zTtuvoLIv6t6GanL99kIHiApAnF2UICNOennDsfYrYcsvilkNe9u twmX2MJfreMFAxxq4vxWAxno9f9MKCIeLEfjJvcUznNJwTRHuAX+gnJZc9dZaqxYNqkY iQZ8IHTjsvDRgFNuiRlQvk5si7DY50pr1mk+rNqxx6Vo5/nTKt6KAMC/AqDv63xSRNU8 694Rs44RQBlXcQl+/jWeyFN8IWWUARt9JMcMB941Heo77li0QbPgdGoWsTOjzOTphy14 +w8w== X-Gm-Message-State: AFeK/H1pUlaVeCy+eHIgYEhWQbeb1sqOXaZR9FYFOGFDl+EYyj/f5s9DhrMIOI8ZCUmYqQ== X-Received: by 10.28.175.129 with SMTP id y123mr5124683wme.67.1490901835331; Thu, 30 Mar 2017 12:23:55 -0700 (PDT) To: qemu-devel@nongnu.org From: Gabriele Galeotti Message-ID: Date: Thu, 30 Mar 2017 21:30:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::244 X-Mailman-Approved-At: Thu, 30 Mar 2017 16:45:03 -0400 Subject: [Qemu-devel] LEON3 timer patch X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: chouteau@adacore.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Hi all. According to "GR712RC Dual-Core LEON3FT SPARC V8 Processor User=E2=80=99s M= anual", "11.3 Registers", pg 87-88, Table 55 Timer control register, the IP=20 "interrupt pending" bit: Interrupt Pending (IP): The core sets this bit to =E2=80=981=E2=80=99 when = an interrupt=20 is signalled. This bit remains =E2=80=981=E2=80=99 until cleared by writing =E2=80=980=E2=80=99 to this bit. Thus the code handling should changed so that the pending bit is=20 mantained when "value" has a 1 in that position. Signed-off-by: Gabriele Galeotti --- hw/timer/grlib_gptimer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/timer/grlib_gptimer.c b/hw/timer/grlib_gptimer.c index 4ed96e9..c555ae8 100644 --- a/hw/timer/grlib_gptimer.c +++ b/hw/timer/grlib_gptimer.c @@ -276,9 +276,6 @@ static void grlib_gptimer_write(void *opaque, hwaddr=20 addr, trace_grlib_gptimer_writel(id, addr, value); =2E if (value & GPTIMER_INT_PENDING) { - /* clear pending bit */ - value &=3D ~GPTIMER_INT_PENDING; - } else { /* keep pending bit */ value |=3D unit->timers[id].config & GPTIMER_INT_PENDING; } --. 2.9.0