From nobody Sat May 4 09:05:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524247561675929.2796899569596; Fri, 20 Apr 2018 11:06:01 -0700 (PDT) Received: from localhost ([::1]:48941 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9aPv-0006dR-Fm for importer@patchew.org; Fri, 20 Apr 2018 14:05:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9aOn-000632-Np for qemu-devel@nongnu.org; Fri, 20 Apr 2018 14:04:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f9aOk-0007ls-Ko for qemu-devel@nongnu.org; Fri, 20 Apr 2018 14:04:41 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:41573) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f9aOk-0007js-E3 for qemu-devel@nongnu.org; Fri, 20 Apr 2018 14:04:38 -0400 Received: by mail-wr0-f194.google.com with SMTP id v24-v6so25103761wra.8 for ; Fri, 20 Apr 2018 11:04:37 -0700 (PDT) Received: from fiorina.redhat.com (ip-94-112-73-67.net.upcbroadband.cz. [94.112.73.67]) by smtp.gmail.com with ESMTPSA id b83sm151549wmb.0.2018.04.20.11.04.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Apr 2018 11:04:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fQbzzYI4IdUpZk15WXqxxfNw2IclXXKrL8g7zJr1aYo=; b=pGe10B20UaywPJb81e0HF7ypWJmUay5mKKY77tiIYcOGt5Dzw+xA3s6BEWjUaB6m42 CXf/51yZF/Au4pYsISHFq6EEG39FdfdEEvvw/BC2z11DnARsd+EbKJNhsod/lFzrH50T bJjL8n1hXG73zY2PoUwFGxnMwwNcI+GwuwyvHEyFyQtJ29G1AWQZaDD/4RsP+mo4R6Wh K88ilZ7PCGJDiGI1cJOhSbtdJ+s2q8afzXvBR0qRw13oQLUZQmtjBKlx3TcQsHjop4DC NUN02tpjok5q5/Y4I1EIVoa++Cmw4xYA0GhbX7IMoNqP1tp5jEnFTPUOi3AeItwjaFvJ 0DyQ== X-Gm-Message-State: ALQs6tDjKPss2ICBeLIsQgANigWtZcr1FGDtmASL3NIDsFKHZmk7Knp1 syAyah7J6wmE083xrlQJSL1y1Q== X-Google-Smtp-Source: AIpwx49oy1sZtcU+SM8CxI1mr9dTLofPcGLqU7TcaTUox/TP6j+KXA229Ts4R1KR1zQuYqbd2bFFOQ== X-Received: by 2002:adf:a004:: with SMTP id k4-v6mr8950878wrk.259.1524247476378; Fri, 20 Apr 2018 11:04:36 -0700 (PDT) From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Golembiovsk=C3=BD?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Michael Roth , Eric Blake Date: Fri, 20 Apr 2018 20:04:34 +0200 Message-Id: X-Mailer: git-send-email 2.17.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.128.194 Subject: [Qemu-devel] [PATCH] test-qga: add trivial tests for some commands X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Tom=C3=A1=C5=A1=20Golembiovsk=C3=BD?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 These commands did not get their tests in the original commits: - guest-get-host-name - guest-get-timezone - guest-get-users Trivial tests that mostly only call the commands were added. Signed-off-by: Tom=C3=A1=C5=A1 Golembiovsk=C3=BD Reviewed-by: Marc-Andr=C3=A9 Lureau --- tests/test-qga.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/tests/test-qga.c b/tests/test-qga.c index e6ab788f31..503f48bacf 100644 --- a/tests/test-qga.c +++ b/tests/test-qga.c @@ -856,6 +856,54 @@ static void test_qga_guest_exec_invalid(gconstpointer = fix) QDECREF(ret); } =20 +static void test_qga_guest_get_host_name(gconstpointer fix) +{ + const TestFixture *fixture =3D fix; + QDict *ret, *val; + + ret =3D qmp_fd(fixture->fd, "{'execute': 'guest-get-host-name'}"); + g_assert_nonnull(ret); + qmp_assert_no_error(ret); + + val =3D qdict_get_qdict(ret, "return"); + g_assert(qdict_haskey(val, "host-name")); + + QDECREF(ret); +} + +static void test_qga_guest_get_timezone(gconstpointer fix) +{ + const TestFixture *fixture =3D fix; + QDict *ret, *val; + + ret =3D qmp_fd(fixture->fd, "{'execute': 'guest-get-timezone'}"); + g_assert_nonnull(ret); + qmp_assert_no_error(ret); + + /* Make sure there's at least offset */ + val =3D qdict_get_qdict(ret, "return"); + g_assert(qdict_haskey(val, "offset")); + + QDECREF(ret); +} + +static void test_qga_guest_get_users(gconstpointer fix) +{ + const TestFixture *fixture =3D fix; + QDict *ret; + QList *val; + + ret =3D qmp_fd(fixture->fd, "{'execute': 'guest-get-users'}"); + g_assert_nonnull(ret); + qmp_assert_no_error(ret); + + /* There is not much to test here */ + val =3D qdict_get_qlist(ret, "return"); + g_assert_nonnull(val); + + QDECREF(ret); +} + static void test_qga_guest_get_osinfo(gconstpointer data) { TestFixture fixture; @@ -948,6 +996,12 @@ int main(int argc, char **argv) test_qga_guest_exec_invalid); g_test_add_data_func("/qga/guest-get-osinfo", &fix, test_qga_guest_get_osinfo); + g_test_add_data_func("/qga/guest-get-host-name", &fix, + test_qga_guest_get_host_name); + g_test_add_data_func("/qga/guest-get-timezone", &fix, + test_qga_guest_get_timezone); + g_test_add_data_func("/qga/guest-get-users", &fix, + test_qga_guest_get_users); =20 ret =3D g_test_run(); =20 --=20 2.17.0