[v2] qga: Add optional `merge-output` flag to guest-exec QAPI

[PATCH v2 0/3] qga: Add optional `merge-output` flag to guest-exec QAPI

Daniel Xu posted 3 patches 1 year, 2 months ago

Diff against v1 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1677609866.git.dxu@dxuuu.xyz

Maintainers: "Daniel P. Berrangé" <berrange@redhat.com>, Michael Roth <michael.roth@amd.com>, Konstantin Kostiuk <kkostiuk@redhat.com>

There is a newer version of this series

crypto/block-luks.c   |   2 +-
qga/commands.c        |  14 ++++-
qga/qapi-schema.json  |   6 +-
tests/unit/test-qga.c | 133 ++++++++++++++++++++++++++++++++++++------
4 files changed, 134 insertions(+), 21 deletions(-)

Expand all Fold all

[PATCH v2 0/3] qga: Add optional `merge-output` flag to guest-exec QAPI

Posted by Daniel Xu 1 year, 2 months ago

Currently, the captured output (via `capture-output`) is segregated into
separate GuestExecStatus fields (`out-data` and `err-data`). This means
that downstream consumers have no way to reassemble the captured data
back into the original stream.

This is relevant for chatty and semi-interactive (ie. read only) CLI
tools.  Such tools may deliberately interleave stdout and stderr for
visual effect. If segregated, the output becomes harder to visually
understand.

This patchset adds support for merging stderr and stdout output streams
via a new QAPI flag.

Changes from v1:
* Drop invalid test fix
* Do not support `merge-output` on windows guests
* Fix a UAF in tests


Daniel Xu (3):
  crypto/luks: Initialize stack variable to silence warning
  qga: Add optional `merge-output` flag to guest-exec qapi
  qga: test: Add tests for `merge-output` flag

 crypto/block-luks.c   |   2 +-
 qga/commands.c        |  14 ++++-
 qga/qapi-schema.json  |   6 +-
 tests/unit/test-qga.c | 133 ++++++++++++++++++++++++++++++++++++------
 4 files changed, 134 insertions(+), 21 deletions(-)

-- 
2.39.1