Misc sm501 clean ups

[PATCH 0/3] Misc sm501 clean ups

Posted by BALATON Zoltan 1 year, 3 months ago

Some small trivial clean ups I've found while looking at this file.

BALATON Zoltan (3):
  hw/display/sm501: Remove parenthesis around consant macro definitions
  hw/display/sm501: Remove unneeded casts from void pointer
  hw/display/sm501: Code style fix

 hw/display/sm501.c | 419 +++++++++++++++++++++++----------------------
 1 file changed, 210 insertions(+), 209 deletions(-)

-- 
2.30.6

Re: [PATCH 0/3] Misc sm501 clean ups

Posted by Philippe Mathieu-Daudé 1 year, 3 months ago

On 21/1/23 21:35, BALATON Zoltan wrote:
> Some small trivial clean ups I've found while looking at this file.
> 
> BALATON Zoltan (3):
>    hw/display/sm501: Remove parenthesis around consant macro definitions
>    hw/display/sm501: Remove unneeded casts from void pointer
>    hw/display/sm501: Code style fix
> 
>   hw/display/sm501.c | 419 +++++++++++++++++++++++----------------------
>   1 file changed, 210 insertions(+), 209 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH 0/3] Misc sm501 clean ups

Posted by BALATON Zoltan 1 year, 3 months ago

On Mon, 23 Jan 2023, Philippe Mathieu-Daudé wrote:
> On 21/1/23 21:35, BALATON Zoltan wrote:
>> Some small trivial clean ups I've found while looking at this file.
>> 
>> BALATON Zoltan (3):
>>    hw/display/sm501: Remove parenthesis around consant macro definitions
>>    hw/display/sm501: Remove unneeded casts from void pointer
>>    hw/display/sm501: Code style fix
>>
>>   hw/display/sm501.c | 419 +++++++++++++++++++++++----------------------
>>   1 file changed, 210 insertions(+), 209 deletions(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Ping? Who will merge this series? Should Daniel take it via PPC or Gerd 
for display? I only care that it gets in one way or another and not lost 
between maintainers.

Regards,
BALATON Zoltan

Re: [PATCH 0/3] Misc sm501 clean ups

Posted by Daniel Henrique Barboza 1 year, 3 months ago


On 1/28/23 23:43, BALATON Zoltan wrote:
> On Mon, 23 Jan 2023, Philippe Mathieu-Daudé wrote:
>> On 21/1/23 21:35, BALATON Zoltan wrote:
>>> Some small trivial clean ups I've found while looking at this file.
>>>
>>> BALATON Zoltan (3):
>>>    hw/display/sm501: Remove parenthesis around consant macro definitions
>>>    hw/display/sm501: Remove unneeded casts from void pointer
>>>    hw/display/sm501: Code style fix
>>>
>>>   hw/display/sm501.c | 419 +++++++++++++++++++++++----------------------
>>>   1 file changed, 210 insertions(+), 209 deletions(-)
>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> 
> Ping? Who will merge this series? Should Daniel take it via PPC or Gerd for display? I only care that it gets in one way or another and not lost between maintainers.

I'm planning a PR at the end of this week. I can take these in.

Thanks,

Daniel

> 
> Regards,
> BALATON Zoltan

Re: [PATCH 0/3] Misc sm501 clean ups

Posted by Daniel Henrique Barboza 1 year, 3 months ago


On 1/30/23 06:43, Daniel Henrique Barboza wrote:
> 
> 
> On 1/28/23 23:43, BALATON Zoltan wrote:
>> On Mon, 23 Jan 2023, Philippe Mathieu-Daudé wrote:
>>> On 21/1/23 21:35, BALATON Zoltan wrote:
>>>> Some small trivial clean ups I've found while looking at this file.
>>>>
>>>> BALATON Zoltan (3):
>>>>    hw/display/sm501: Remove parenthesis around consant macro definitions
>>>>    hw/display/sm501: Remove unneeded casts from void pointer
>>>>    hw/display/sm501: Code style fix
>>>>
>>>>   hw/display/sm501.c | 419 +++++++++++++++++++++++----------------------
>>>>   1 file changed, 210 insertions(+), 209 deletions(-)
>>>
>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>
>> Ping? Who will merge this series? Should Daniel take it via PPC or Gerd for display? I only care that it gets in one way or another and not lost between maintainers.
> 
> I'm planning a PR at the end of this week. I can take these in.


Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,


Daniel


> 
> Thanks,
> 
> Daniel
> 
>>
>> Regards,
>> BALATON Zoltan